From 08753eedcd3902c85a2732acff1d30c526552a0f Mon Sep 17 00:00:00 2001 From: Wahaj18 <48466561+Wahaj18@users.noreply.github.com> Date: Sat, 21 Nov 2026 17:08:46 +0500 Subject: [PATCH] Show the identifier of auto-added talker alias radios (#2743) Radio and P25FullyQualifiedRadio didn't set the value property when built with the value constructor, which is how TalkerAliasAutoAdder creates the radio ID for a new alias. The Identifier column in the alias view by identifier type binds to that property, so it stayed blank until the alias was edited or the playlist was reloaded through the setters. Fixes #2730 --- .../github/dsheirer/alias/id/radio/P25FullyQualifiedRadio.java | 1 + src/main/java/io/github/dsheirer/alias/id/radio/Radio.java | 1 + .../io/github/dsheirer/alias/TalkerAliasAutoAdderTest.java | 3 +++ 3 files changed, 5 insertions(+) diff --git a/src/main/java/io/github/dsheirer/alias/id/radio/P25FullyQualifiedRadio.java b/src/main/java/io/github/dsheirer/alias/id/radio/P25FullyQualifiedRadio.java index eeb72683..770926ed 100644 --- a/src/main/java/io/github/dsheirer/alias/id/radio/P25FullyQualifiedRadio.java +++ b/src/main/java/io/github/dsheirer/alias/id/radio/P25FullyQualifiedRadio.java @@ -48,6 +48,7 @@ public class P25FullyQualifiedRadio extends Radio super(Protocol.APCO25, id); mWacn = wacn; mSystem = system; + updateValueProperty(); } @Override diff --git a/src/main/java/io/github/dsheirer/alias/id/radio/Radio.java b/src/main/java/io/github/dsheirer/alias/id/radio/Radio.java index ef29788f..48d53fa1 100644 --- a/src/main/java/io/github/dsheirer/alias/id/radio/Radio.java +++ b/src/main/java/io/github/dsheirer/alias/id/radio/Radio.java @@ -45,6 +45,7 @@ public class Radio extends AliasID implements Comparable { mProtocol = protocol; mValue = value; + updateValueProperty(); } @Override diff --git a/src/test/java/io/github/dsheirer/alias/TalkerAliasAutoAdderTest.java b/src/test/java/io/github/dsheirer/alias/TalkerAliasAutoAdderTest.java index 857803ba..dfeffbab 100644 --- a/src/test/java/io/github/dsheirer/alias/TalkerAliasAutoAdderTest.java +++ b/src/test/java/io/github/dsheirer/alias/TalkerAliasAutoAdderTest.java @@ -82,6 +82,7 @@ public class TalkerAliasAutoAdderTest assertEquals(TalkerAliasAutoAdder.ALIAS_GROUP, alias.getGroup()); assertTrue(alias.getAliasIdentifiers().get(0) instanceof Radio radio && radio.getValue() == 1234 && radio.getProtocol() == Protocol.APCO25); + assertEquals("Radio ID:1234 Protocol:APCO-25", alias.getAliasIdentifiers().get(0).valueProperty().get()); decode(RADIO, "ENGINE 12"); assertEquals(1, aliases().size(), "no duplicate alias"); @@ -252,6 +253,8 @@ public class TalkerAliasAutoAdderTest decode(roaming, "ROAMER"); Alias alias = alias(roaming); assertTrue(alias.getAliasIdentifiers().get(0) instanceof P25FullyQualifiedRadio); + assertEquals("Fully Qualified Radio ID:781824.291.777 Protocol:APCO-25", + alias.getAliasIdentifiers().get(0).valueProperty().get()); assertNull(alias(RADIO), "local radio with the same value isn't aliased"); }