Merge branch 'master' into #90-channel_processing_list_and_gui_reformat

# Conflicts:
#	src/alias/AliasList.java
This commit is contained in:
Denny
2017-01-18 19:07:39 -05:00
3 changed files with 100 additions and 85 deletions

View File

@@ -48,16 +48,16 @@ public class AliasList implements Listener<AliasEvent>
public static final String WILDCARD = "*"; public static final String WILDCARD = "*";
public static final String REGEX_WILDCARD = "."; public static final String REGEX_WILDCARD = ".";
private Map<String,Alias> mESN = new HashMap<>(); private Map<String, Alias> mESN = new HashMap<>();
private Map<String,Alias> mFleetsync = new HashMap<>(); private Map<String, Alias> mFleetsync = new HashMap<>();
private Map<LoJackFunctionAndID,Alias> mLoJack = new HashMap<>(); private Map<LoJackFunctionAndID, Alias> mLoJack = new HashMap<>();
private Map<String,Alias> mMDC1200 = new HashMap<>(); private Map<String, Alias> mMDC1200 = new HashMap<>();
private Map<String,Alias> mMobileID = new HashMap<>(); private Map<String, Alias> mMobileID = new HashMap<>();
private Map<String,Alias> mMPT1327 = new HashMap<>(); private Map<String, Alias> mMPT1327 = new HashMap<>();
private Map<String,Alias> mSiteID = new HashMap<>(); private Map<String, Alias> mSiteID = new HashMap<>();
private Map<Integer,Alias> mStatus = new HashMap<>(); private Map<Integer, Alias> mStatus = new HashMap<>();
private Map<String,Alias> mTalkgroup = new HashMap<>(); private Map<String, Alias> mTalkgroup = new HashMap<>();
private Map<Integer,Alias> mUniqueID = new HashMap<>(); private Map<Integer, Alias> mUniqueID = new HashMap<>();
private List<WildcardID> mESNWildcards = new ArrayList<>(); private List<WildcardID> mESNWildcards = new ArrayList<>();
private List<WildcardID> mMobileIDWildcards = new ArrayList<>(); private List<WildcardID> mMobileIDWildcards = new ArrayList<>();
@@ -124,7 +124,7 @@ public class AliasList implements Listener<AliasEvent>
if(fleetsync != null) if(fleetsync != null)
{ {
if(fleetsync.contains(WILDCARD)) if (fleetsync.contains(WILDCARD))
{ {
mFleetsyncWildcards.add(new WildcardID(fleetsync)); mFleetsyncWildcards.add(new WildcardID(fleetsync));
Collections.sort(mFleetsyncWildcards); Collections.sort(mFleetsyncWildcards);
@@ -137,11 +137,11 @@ public class AliasList implements Listener<AliasEvent>
mLoJack.put((LoJackFunctionAndID) id, alias); mLoJack.put((LoJackFunctionAndID) id, alias);
break; break;
case MDC1200: case MDC1200:
String mdc = ((MDC1200ID) id).getIdent(); String mdc = ((MDC1200ID)id).getIdent();
if(mdc != null) if(mdc != null)
{ {
if(mdc.contains(WILDCARD)) if (mdc.contains(WILDCARD))
{ {
mMDC1200Wildcards.add(new WildcardID(mdc)); mMDC1200Wildcards.add(new WildcardID(mdc));
Collections.sort(mMDC1200Wildcards); Collections.sort(mMDC1200Wildcards);
@@ -151,11 +151,11 @@ public class AliasList implements Listener<AliasEvent>
} }
break; break;
case MPT1327: case MPT1327:
String mpt = ((MPT1327ID) id).getIdent(); String mpt = ((MPT1327ID)id).getIdent();
if(mpt != null) if(mpt != null)
{ {
if(mpt.contains(WILDCARD)) if (mpt.contains(WILDCARD))
{ {
mMPT1327Wildcards.add(new WildcardID(mpt)); mMPT1327Wildcards.add(new WildcardID(mpt));
Collections.sort(mMPT1327Wildcards); Collections.sort(mMPT1327Wildcards);
@@ -165,11 +165,11 @@ public class AliasList implements Listener<AliasEvent>
} }
break; break;
case MIN: case MIN:
String min = ((Min) id).getMin(); String min = ((Min)id).getMin();
if(min != null) if(min != null)
{ {
if(min.contains(WILDCARD)) if (min.contains(WILDCARD))
{ {
mMobileIDWildcards.add(new WildcardID(min)); mMobileIDWildcards.add(new WildcardID(min));
Collections.sort(mMobileIDWildcards); Collections.sort(mMobileIDWildcards);
@@ -179,14 +179,14 @@ public class AliasList implements Listener<AliasEvent>
} }
break; break;
case LTR_NET_UID: case LTR_NET_UID:
mUniqueID.put(((UniqueID) id).getUid(), alias); mUniqueID.put(((UniqueID)id).getUid(), alias);
break; break;
case SITE: case SITE:
String siteID = ((SiteID) id).getSite(); String siteID = ((SiteID)id).getSite();
if(siteID != null) if(siteID != null)
{ {
if(siteID.contains(WILDCARD)) if (siteID.contains(WILDCARD))
{ {
mSiteWildcards.add(new WildcardID(siteID)); mSiteWildcards.add(new WildcardID(siteID));
Collections.sort(mSiteWildcards); Collections.sort(mSiteWildcards);
@@ -199,11 +199,11 @@ public class AliasList implements Listener<AliasEvent>
mStatus.put(((StatusID) id).getStatus(), alias); mStatus.put(((StatusID) id).getStatus(), alias);
break; break;
case TALKGROUP: case TALKGROUP:
String tgid = ((TalkgroupID) id).getTalkgroup(); String tgid = ((TalkgroupID)id).getTalkgroup();
if(tgid != null) if(tgid != null)
{ {
if(tgid.contains(WILDCARD)) if (tgid.contains(WILDCARD))
{ {
mTalkgroupWildcards.add(new WildcardID(tgid)); mTalkgroupWildcards.add(new WildcardID(tgid));
Collections.sort(mTalkgroupWildcards); Collections.sort(mTalkgroupWildcards);
@@ -222,7 +222,7 @@ public class AliasList implements Listener<AliasEvent>
break; break;
} }
} }
catch(Exception e) catch (Exception e)
{ {
mLog.error("Couldn't add alias ID " + id + " for alias " + alias); mLog.error("Couldn't add alias ID " + id + " for alias " + alias);
} }
@@ -234,9 +234,9 @@ public class AliasList implements Listener<AliasEvent>
*/ */
public void removeAlias(Alias alias) public void removeAlias(Alias alias)
{ {
if(alias != null) if (alias != null)
{ {
for(AliasID aliasID : alias.getId()) for (AliasID aliasID : alias.getId())
{ {
removeAliasID(aliasID, alias); removeAliasID(aliasID, alias);
} }
@@ -247,7 +247,7 @@ public class AliasList implements Listener<AliasEvent>
{ {
if(value != null) if(value != null)
{ {
for(WildcardID wildcardID : wildcards) for(WildcardID wildcardID: wildcards)
{ {
if(wildcardID.value().equals(value)) if(wildcardID.value().equals(value))
{ {
@@ -262,12 +262,12 @@ public class AliasList implements Listener<AliasEvent>
*/ */
private void removeAliasID(AliasID id, Alias alias) private void removeAliasID(AliasID id, Alias alias)
{ {
if(id.isValid()) if (id.isValid())
{ {
switch(id.getType()) switch (id.getType())
{ {
case ESN: case ESN:
String esn = ((Esn) id).getEsn(); String esn = ((Esn)id).getEsn();
if(esn != null) if(esn != null)
{ {
@@ -280,13 +280,13 @@ public class AliasList implements Listener<AliasEvent>
mESN.remove(esn); mESN.remove(esn);
break; break;
case FLEETSYNC: case FLEETSYNC:
String fleetsync = ((FleetsyncID) id).getIdent(); String fleetsync = ((FleetsyncID)id).getIdent();
if(fleetsync != null) if(fleetsync != null)
{ {
if(fleetsync.contains(WILDCARD)) if(fleetsync.contains(WILDCARD))
{ {
removeWildcard(fleetsync, mFleetsyncWildcards); removeWildcard(fleetsync,mFleetsyncWildcards);
} }
mFleetsync.remove(fleetsync); mFleetsync.remove(fleetsync);
@@ -296,7 +296,7 @@ public class AliasList implements Listener<AliasEvent>
mLoJack.remove((LoJackFunctionAndID) id); mLoJack.remove((LoJackFunctionAndID) id);
break; break;
case MDC1200: case MDC1200:
String mdc = ((MDC1200ID) id).getIdent(); String mdc = ((MDC1200ID)id).getIdent();
if(mdc != null) if(mdc != null)
{ {
@@ -309,7 +309,7 @@ public class AliasList implements Listener<AliasEvent>
} }
break; break;
case MPT1327: case MPT1327:
String mpt = ((MPT1327ID) id).getIdent(); String mpt = ((MPT1327ID)id).getIdent();
if(mpt != null) if(mpt != null)
{ {
@@ -322,7 +322,7 @@ public class AliasList implements Listener<AliasEvent>
} }
break; break;
case MIN: case MIN:
String min = ((Min) id).getMin(); String min = ((Min)id).getMin();
if(min != null) if(min != null)
{ {
@@ -344,7 +344,7 @@ public class AliasList implements Listener<AliasEvent>
mStatus.remove(((StatusID) id).getStatus()); mStatus.remove(((StatusID) id).getStatus());
break; break;
case TALKGROUP: case TALKGROUP:
String tgid = ((TalkgroupID) id).getTalkgroup(); String tgid = ((TalkgroupID)id).getTalkgroup();
if(tgid != null) if(tgid != null)
{ {
@@ -378,11 +378,11 @@ public class AliasList implements Listener<AliasEvent>
*/ */
private String getWildcardMatch(String id, List<WildcardID> wildcards) private String getWildcardMatch(String id, List<WildcardID> wildcards)
{ {
if(id != null) if (id != null)
{ {
for(WildcardID wildcard : wildcards) for (WildcardID wildcard : wildcards)
{ {
if(wildcard.matches(id)) if (wildcard.matches(id))
{ {
return wildcard.value(); return wildcard.value();
} }
@@ -399,15 +399,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(siteID != null) if (siteID != null)
{ {
alias = mSiteID.get(siteID); alias = mSiteID.get(siteID);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(siteID, mSiteWildcards); String wildcard = getWildcardMatch(siteID, mSiteWildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mSiteID.get(wildcard); alias = mSiteID.get(wildcard);
} }
@@ -440,15 +440,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(esn != null) if (esn != null)
{ {
alias = mESN.get(esn); alias = mESN.get(esn);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(esn, mESNWildcards); String wildcard = getWildcardMatch(esn, mESNWildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mESN.get(wildcard); alias = mESN.get(wildcard);
} }
@@ -465,15 +465,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(ident != null) if (ident != null)
{ {
alias = mFleetsync.get(ident); alias = mFleetsync.get(ident);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(ident, mFleetsyncWildcards); String wildcard = getWildcardMatch(ident, mFleetsyncWildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mFleetsync.get(wildcard); alias = mFleetsync.get(wildcard);
} }
@@ -488,11 +488,11 @@ public class AliasList implements Listener<AliasEvent>
*/ */
public Alias getLoJackAlias(Function function, String id) public Alias getLoJackAlias(Function function, String id)
{ {
if(id != null) if (id != null)
{ {
for(LoJackFunctionAndID lojack : mLoJack.keySet()) for (LoJackFunctionAndID lojack : mLoJack.keySet())
{ {
if(lojack.matches(function, id)) if (lojack.matches(function, id))
{ {
return mLoJack.get(lojack); return mLoJack.get(lojack);
} }
@@ -509,15 +509,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(ident != null) if (ident != null)
{ {
alias = mMDC1200.get(ident); alias = mMDC1200.get(ident);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(ident, mMDC1200Wildcards); String wildcard = getWildcardMatch(ident, mMDC1200Wildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mMDC1200.get(wildcard); alias = mMDC1200.get(wildcard);
} }
@@ -534,15 +534,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(ident != null) if (ident != null)
{ {
alias = mMPT1327.get(ident); alias = mMPT1327.get(ident);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(ident, mMPT1327Wildcards); String wildcard = getWildcardMatch(ident, mMPT1327Wildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mMPT1327.get(wildcard); alias = mMPT1327.get(wildcard);
} }
@@ -559,15 +559,15 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = null; Alias alias = null;
if(ident != null) if (ident != null)
{ {
alias = mMobileID.get(ident); alias = mMobileID.get(ident);
if(alias == null) if (alias == null)
{ {
String wildcard = getWildcardMatch(ident, mMobileIDWildcards); String wildcard = getWildcardMatch(ident, mMobileIDWildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mMobileID.get(wildcard); alias = mMobileID.get(wildcard);
} }
@@ -579,20 +579,24 @@ public class AliasList implements Listener<AliasEvent>
/** /**
* Lookup alias by talkgroup * Lookup alias by talkgroup
*
* @param tgid to use when searching for an alias
* @param includeWildcards true if you want to additionally search for a matching alias that contains wildcard(s)
* when there is not a direct match to the TGID.
*/ */
public Alias getTalkgroupAlias(String tgid) public Alias getTalkgroupAlias(String tgid, boolean includeWildcards)
{ {
Alias alias = null; Alias alias = null;
if(tgid != null) if (tgid != null)
{ {
alias = mTalkgroup.get(tgid); alias = mTalkgroup.get(tgid);
if(alias == null) if (alias == null && includeWildcards)
{ {
String wildcard = getWildcardMatch(tgid, mTalkgroupWildcards); String wildcard = getWildcardMatch(tgid, mTalkgroupWildcards);
if(wildcard != null) if (wildcard != null)
{ {
alias = mTalkgroup.get(wildcard); alias = mTalkgroup.get(wildcard);
} }
@@ -603,8 +607,16 @@ public class AliasList implements Listener<AliasEvent>
} }
/** /**
* Alias list name * Lookup alias by talkgroup. Defaults to matching to wildcard talkgroups.
*/ */
public Alias getTalkgroupAlias(String tgid)
{
return getTalkgroupAlias(tgid, true);
}
/**
* Alias list name
*/
public String toString() public String toString()
{ {
return mName; return mName;
@@ -627,22 +639,22 @@ public class AliasList implements Listener<AliasEvent>
{ {
Alias alias = event.getAlias(); Alias alias = event.getAlias();
switch(event.getEvent()) switch (event.getEvent())
{ {
case ADD: case ADD:
if(alias.getList() != null && getName().equalsIgnoreCase(alias.getList())) if (alias.getList() != null && getName().equalsIgnoreCase(alias.getList()))
{ {
addAlias(alias); addAlias(alias);
} }
break; break;
case CHANGE: case CHANGE:
if(alias.getList() != null && getName().equalsIgnoreCase(alias.getList())) if (alias.getList() != null && getName().equalsIgnoreCase(alias.getList()))
{ {
addAlias(alias); addAlias(alias);
} }
break; break;
case DELETE: case DELETE:
if(alias.getList() != null && getName().equalsIgnoreCase(alias.getList())) if (alias.getList() != null && getName().equalsIgnoreCase(alias.getList()))
{ {
removeAlias(alias); removeAlias(alias);
} }

View File

@@ -144,19 +144,16 @@ public class PatchGroupAlias extends Alias
} }
else else
{ {
if(getId().size() > 0) for(AliasID id: getId())
{ {
for(AliasID id: getId()) if(id.getType() == AliasIDType.TALKGROUP)
{ {
if(id.getType() == AliasIDType.TALKGROUP) return "PATCH:" + ((TalkgroupID)id).getTalkgroup();
{
return "PATCH:" + ((TalkgroupID)id).getTalkgroup();
}
} }
} }
} }
return "PATCH"; return "PATCH:****";
} }
@Override @Override
@@ -164,16 +161,22 @@ public class PatchGroupAlias extends Alias
{ {
List<AliasAction> aliasActions = new ArrayList<>(); List<AliasAction> aliasActions = new ArrayList<>();
for(Alias alias: mPatchedAliases)
{
aliasActions.addAll(alias.getAction());
}
if(hasPatchGroupAlias()) if(hasPatchGroupAlias())
{ {
aliasActions.addAll(getPatchGroupAlias().getAction()); aliasActions.addAll(getPatchGroupAlias().getAction());
} }
for(Alias alias: mPatchedAliases)
{
for(AliasAction action: alias.getAction())
{
if(!aliasActions.contains(action))
{
aliasActions.add(action);
}
}
}
return aliasActions; return aliasActions;
} }
@@ -198,7 +201,7 @@ public class PatchGroupAlias extends Alias
for(Alias alias: mPatchedAliases) for(Alias alias: mPatchedAliases)
{ {
if(alias.getCallPriority() < highestPriority) if(alias.hasCallPriority() && alias.getCallPriority() < highestPriority)
{ {
highestPriority = alias.getCallPriority(); highestPriority = alias.getCallPriority();
} }

View File

@@ -2917,8 +2917,8 @@ public class P25DecoderState extends DecoderState
{ {
PatchGroupAlias patchGroupAlias = null; PatchGroupAlias patchGroupAlias = null;
//Check for an existing alias for the patch talkgroup //Check for an existing alias for the patch talkgroup - do not include wildcard aliases
Alias existingAlias = getAliasList().getTalkgroupAlias(patchGroupID); Alias existingAlias = getAliasList().getTalkgroupAlias(patchGroupID, false);
if(existingAlias instanceof PatchGroupAlias) if(existingAlias instanceof PatchGroupAlias)
{ {
@@ -2928,6 +2928,8 @@ public class P25DecoderState extends DecoderState
{ {
patchGroupAlias = new PatchGroupAlias(); patchGroupAlias = new PatchGroupAlias();
patchGroupAlias.addAliasID(new TalkgroupID(patchGroupID));
if(existingAlias != null) if(existingAlias != null)
{ {
getAliasList().removeAlias(existingAlias); getAliasList().removeAlias(existingAlias);
@@ -2935,8 +2937,6 @@ public class P25DecoderState extends DecoderState
patchGroupAlias.setPatchGroupAlias(existingAlias); patchGroupAlias.setPatchGroupAlias(existingAlias);
} }
patchGroupAlias.addAliasID(new TalkgroupID(patchGroupID));
getAliasList().addAlias(patchGroupAlias); getAliasList().addAlias(patchGroupAlias);
} }