GitHub/sdrtrunk
1
0
Fork 0
mirror of https://github.com/DSheirer/sdrtrunk.git synced 2026-11-13 17:17:29 -05:00
Code Issues Packages Projects Releases 2 Wiki Activity

#1670 Resolves missing audio segments for some DMR Cap+ call events.

Browse Source
This commit is contained in:
Dennis Sheirer
2023-10-15 08:47:42 -04:00
parent bad5a1f9f0
commit b391ebbb5f
2 changed files with 38 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

82
src/main/java/io/github/dsheirer/module/decode/dmr/audio/DMRAudioModule.java
View File

@@ -1,6 +1,6 @@
/* /*
* ***************************************************************************** * *****************************************************************************
* Copyright (C) 2014-2022 Dennis Sheirer * Copyright (C) 2014-2023 Dennis Sheirer
* *
* This program is free software: you can redistribute it and/or modify * This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by * it under the terms of the GNU General Public License as published by
@@ -38,7 +38,6 @@ import io.github.dsheirer.module.decode.dmr.message.data.lc.LCMessage;
import io.github.dsheirer.module.decode.dmr.message.data.lc.full.AbstractVoiceChannelUser; import io.github.dsheirer.module.decode.dmr.message.data.lc.full.AbstractVoiceChannelUser;
import io.github.dsheirer.module.decode.dmr.message.data.lc.full.FullLCMessage; import io.github.dsheirer.module.decode.dmr.message.data.lc.full.FullLCMessage;
import io.github.dsheirer.module.decode.dmr.message.data.terminator.Terminator; import io.github.dsheirer.module.decode.dmr.message.data.terminator.Terminator;
import io.github.dsheirer.module.decode.dmr.message.type.ServiceOptions;
import io.github.dsheirer.module.decode.dmr.message.voice.VoiceEMBMessage; import io.github.dsheirer.module.decode.dmr.message.voice.VoiceEMBMessage;
import io.github.dsheirer.module.decode.dmr.message.voice.VoiceMessage; import io.github.dsheirer.module.decode.dmr.message.voice.VoiceMessage;
import io.github.dsheirer.preference.UserPreferences; import io.github.dsheirer.preference.UserPreferences;
@@ -105,63 +104,54 @@ public class DMRAudioModule extends AmbeAudioModule implements IdentifierUpdateP
{ {
if(hasAudioCodec() && message.getTimeslot() == getTimeslot()) if(hasAudioCodec() && message.getTimeslot() == getTimeslot())
{ {
//DCDM doesn't provide FLCs or EMBs ... assume that the call is unencrypted. //Attempt to set the audio encryption state from certain types of messages
if(!mEncryptedCallStateEstablished && message instanceof VoiceMessage vm && if(!mEncryptedCallStateEstablished)
vm.getSyncPattern().isDirectMode())
{ {
mEncryptedCallStateEstablished = true; //DCDM doesn't provide FLCs or EMBs ... assume that the call is unencrypted.
mEncryptedCall = false; if(message instanceof VoiceMessage vm && vm.getSyncPattern().isDirectMode())
List<byte[]> frames = vm.getAMBEFrames();
for(byte[] frame: frames)
{ {
processAudio(frame, message.getTimestamp()); mEncryptedCallStateEstablished = true;
mEncryptedCall = false;
} }
} //Both Motorola and Hytera signal their Basic Privacy (BP) scrambling in some of the Voice B-F frames
//Both Motorola and Hytera signal their Basic Privacy (BP) scrambling in some of the Voice B-F frames //in the EMB field.
//in the EMB field. else if(message instanceof VoiceEMBMessage voiceMessage && voiceMessage.getEMB().isValid())
else if(!mEncryptedCallStateEstablished && message instanceof VoiceEMBMessage voiceMessage)
{
if(voiceMessage.getEMB().isValid())
{ {
mEncryptedCallStateEstablished = true; mEncryptedCallStateEstablished = true;
mEncryptedCall = voiceMessage.getEMB().isEncrypted(); mEncryptedCall = voiceMessage.getEMB().isEncrypted();
} }
else if(message instanceof VoiceHeader voiceHeader)
{
LCMessage lc = voiceHeader.getLCMessage();
List<byte[]> frames = voiceMessage.getAMBEFrames(); if(lc instanceof FullLCMessage flc) //We know it is, but this null checks as well
for(byte[] frame: frames)
{
processAudio(frame, message.getTimestamp());
}
}
else if(message instanceof VoiceMessage voiceMessage)
{
List<byte[]> frames = voiceMessage.getAMBEFrames();
for(byte[] frame: frames)
{
processAudio(frame, message.getTimestamp());
}
}
else if(!mEncryptedCallStateEstablished && message instanceof VoiceHeader voiceHeader)
{
LCMessage lc = voiceHeader.getLCMessage();
if(lc instanceof FullLCMessage flc) //We know it is, but this null checks as well
{
if(flc.isValid())
{ {
mEncryptedCallStateEstablished = true; if(flc.isValid())
mEncryptedCall = flc.isEncrypted(); {
mEncryptedCallStateEstablished = true;
mEncryptedCall = flc.isEncrypted();
}
} }
} }
//Note: the DMRMessageProcessor extracts Full Link Control messages from Voice Frames B-C and sends them
// independent of any DMR Burst messaging. When encountered, it can be assumed that they are part of
// an ongoing call and can be used to establish encryption state when the FLC is a voice channel user.
else if(message instanceof AbstractVoiceChannelUser avcu)
{
mEncryptedCallStateEstablished = true;
mEncryptedCall = avcu.getServiceOptions().isEncrypted();
}
} }
//Note: the DMRMessageProcess extracts Full Link Control messages from Voice Frames B-C and sends them
// independent of any DMR Burst messaging. When encountered, it can be assumed that they are part of //Queue or process audio frames. Note: audio frames are held/queued until encrypted state is established
// an ongoing call and can be used to establish encryption state when the FLC is a voice channel user. //before any audio is generated for the audio segment.
else if(!mEncryptedCallStateEstablished && message instanceof AbstractVoiceChannelUser avcu) if(message instanceof VoiceMessage voiceMessage)
{ {
ServiceOptions serviceOptions = avcu.getServiceOptions(); List<byte[]> frames = voiceMessage.getAMBEFrames();
mEncryptedCallStateEstablished = true; for(byte[] frame: frames)
mEncryptedCall = serviceOptions.isEncrypted(); {
processAudio(frame, message.getTimestamp());
}
} }
else if(message instanceof Terminator) else if(message instanceof Terminator)
{ {

4
src/main/java/io/github/dsheirer/module/decode/dmr/message/data/lc/full/motorola/CapacityPlusVoiceChannelUser.java
View File

@@ -21,13 +21,13 @@ package io.github.dsheirer.module.decode.dmr.message.data.lc.full.motorola;
import io.github.dsheirer.bits.CorrectedBinaryMessage; import io.github.dsheirer.bits.CorrectedBinaryMessage;
import io.github.dsheirer.module.decode.dmr.message.IServiceOptionsProvider; import io.github.dsheirer.module.decode.dmr.message.IServiceOptionsProvider;
import io.github.dsheirer.module.decode.dmr.message.data.lc.full.FullLCMessage; import io.github.dsheirer.module.decode.dmr.message.data.lc.full.AbstractVoiceChannelUser;
import io.github.dsheirer.module.decode.dmr.message.type.CapacityPlusServiceOptions; import io.github.dsheirer.module.decode.dmr.message.type.CapacityPlusServiceOptions;
/** /**
* Any Capacity Plus Voice Channel User link control message that contains vendor-specific service options. * Any Capacity Plus Voice Channel User link control message that contains vendor-specific service options.
*/ */
public abstract class CapacityPlusVoiceChannelUser extends FullLCMessage implements IServiceOptionsProvider public abstract class CapacityPlusVoiceChannelUser extends AbstractVoiceChannelUser implements IServiceOptionsProvider
{ {
private static final int[] SERVICE_OPTIONS = new int[]{16, 17, 18, 19, 20, 21, 22, 23}; private static final int[] SERVICE_OPTIONS = new int[]{16, 17, 18, 19, 20, 21, 22, 23};
//Reed Solomon FEC: 72-95 //Reed Solomon FEC: 72-95