There may be two separate formats that are used for LRRP position fields where one treats the value as a two's complement field and the other as a 1-bit hemisphere indicator followed by a 31-bit positive integer. If so, we'll need to expose a user-selectable flag to toggle one format or the other.
For now, this change won't impact any Northern hemisphere users.
Co-authored-by: Dennis Sheirer <dsheirer@github.com>
* Add failing test for toCSV()
* Add missing " to timeslot value
* Add failing test for quotes and commas in details
* Separate comma and quote tests
* Escape toCSV cells using utility
* Use CSVFormatter instead of escape utils
Allows us to control exactly how we want to format a CSV-valid row.
* Never have a null cell
Instead of using a stream map, opting for an explicit handling so the logger can explode when an unexpected null shows up. Prevents the situation where things are mysteriously blank, forcing developers to handle known null scenarios.
* #775 Adds frequency column to channel editor
* #775 Resolves issue with changing channel processing flag on FX event thread
* #775 Removes auto-detect channel settings for P25 Phase 2 configurations.
* #775 Playlist editor cleanup actions. Changes style of segmented buttons. Fix issue with channel set processing not on FX thread. Removes P25P2 auto-detect settings feature. Adds frequency column to channel editor.
Co-authored-by: Denny <denny@denny-desktop>
* WIP - Adds support for aliasing P25 Phase 2 tones.Playlist editor - adds editor support for alias actions
* Playlist editor implementation and integration into application is complete. Adds JavaFX window monitoring to persist window size/location across application runs.
Co-authored-by: Denny <denny@denny-desktop>
* Misc minor performance improvements
* Use more concise loop syntax
* Use more concise Collection sort syntax
* Use StringUtils pad methods
* Optimize some loops and double-map-lookups
* Optimize array instantiation
There are two styles to convert a collection to an array: either
using a pre-sized array (like c.toArray(new String[c.size()])) or
using an empty array (like c.toArray(new String[0]).
In older Java versions using pre-sized array was recommended,
as the reflection call which is necessary to create an array
of proper size was quite slow. However since late updates of
OpenJDK 6 this call was intrinsified, making the performance
of the empty array version the same and sometimes even better,
compared to the pre-sized version. Also passing pre-sized array
is dangerous for a concurrent or synchronized collection as
a data race is possible between the size and toArray call
which may result in extra nulls at the end of the array,
if the collection was concurrently shrunk during the operation.
* Cleanup string concatenation
* Use EnumMap where possible
* Use FastMath instead of Math
* Initialize complex things only once
* Reduce method size to aloow more JIT inlining
* remove map of short->float
* Move field to local variable
* Cleanup Map lookup
Co-authored-by: Rob Ekl <xwq876@zebra.com>
* Include other member variables in copy constructor
* Add break to switch cases
* Implement equals() in classes extending Comparable
If equals() is not overridden, the equals() implementation is not consistent
with the compareTo() implementation. If an object of such a class is added
to a collection such as java.util.SortedSet, this collection will violate
the contract of java.util.Set, which is defined in terms of equals().
Co-authored-by: Rob Ekl <xwq876@zebra.com>
-Separates USB timeout event processing to a dedicated thread
-Updates USB transfer buffer processor to better detect errors and auto-restart on error (max 3 times)
-Updates Tuner to add an error state and SourceManager to not select tuners with an error state
-Updates ChannelProcessingManager to auto-shutdown channels sourced from tuners set with error state
-Improves logging of USB related errors.
* #576 Updates P25 activity summaries to list values in hex and decimal. Resolves issue with P25 explicit channel uplink frequency calculations. Resolves issue with Motorola base station id messages and traffic channel messages. Resolves issue with RFSS link control message control channel frequency calculations. Resolves issue with error when using recording tuners.
