* WIP - Adds support for aliasing P25 Phase 2 tones.Playlist editor - adds editor support for alias actions
* Playlist editor implementation and integration into application is complete. Adds JavaFX window monitoring to persist window size/location across application runs.
Co-authored-by: Denny <denny@denny-desktop>
* Misc minor performance improvements
* Use more concise loop syntax
* Use more concise Collection sort syntax
* Use StringUtils pad methods
* Optimize some loops and double-map-lookups
* Optimize array instantiation
There are two styles to convert a collection to an array: either
using a pre-sized array (like c.toArray(new String[c.size()])) or
using an empty array (like c.toArray(new String[0]).
In older Java versions using pre-sized array was recommended,
as the reflection call which is necessary to create an array
of proper size was quite slow. However since late updates of
OpenJDK 6 this call was intrinsified, making the performance
of the empty array version the same and sometimes even better,
compared to the pre-sized version. Also passing pre-sized array
is dangerous for a concurrent or synchronized collection as
a data race is possible between the size and toArray call
which may result in extra nulls at the end of the array,
if the collection was concurrently shrunk during the operation.
* Cleanup string concatenation
* Use EnumMap where possible
* Use FastMath instead of Math
* Initialize complex things only once
* Reduce method size to aloow more JIT inlining
* remove map of short->float
* Move field to local variable
* Cleanup Map lookup
Co-authored-by: Rob Ekl <xwq876@zebra.com>
* Include other member variables in copy constructor
* Add break to switch cases
* Implement equals() in classes extending Comparable
If equals() is not overridden, the equals() implementation is not consistent
with the compareTo() implementation. If an object of such a class is added
to a collection such as java.util.SortedSet, this collection will violate
the contract of java.util.Set, which is defined in terms of equals().
Co-authored-by: Rob Ekl <xwq876@zebra.com>
radio reference client library and adds support for storing user
credentials in user preferences.
Removes legacy apache axis SOAP and WSDL libraries calls to radio
reference web services -- not required by the new library.
- Clears stale patch groups
- Reworks the audio playback panel label update code to properly update
talkgroups and aliases in concert with the audio playback.
- Removes code that was truncating playback aliases at 32 characters.
* Resolves#502
Resolves issue with connecting to icecast http streaming server.
The issue stems from Icecast HTTP (2.4+) servers not sending a full
HTTP OK response (missing header tokens) to a connection request.
Prior to the upgrade to apache mina 2.0.19, we received a specific
exception and handled it and set the status to connected.
After the upgrade, apache mina is now sending an array index out of
bounds exception when it decodes the incomplete http response.
So, we now catch that specific exception, inspect the http response
hex bytes and set the status to connected.
* Stores minimal main application window location and size/layout settings
to allow application to be restored to the same size/location on
restart.
* Adds column width monitor to all tables in application that stores the
column width settings in the user preferences so that on restarting
the application the table column widths are restored to the previous
widths.
* Resolves issue with non-aliased talkgroup values not displaying in
audio playback (left/right/mono) windows.
* Adds buildSdr build target back into gradle script.
we can account for multi-alias identifiers like patch groups and ensure
that patch group alias intentions are carried throughout the system for
recording, streaming, etc.
Updates all consumers of alias list data to ensure it can operate with
a list of aliases versus an assumed single alias.
Refactors APCO25 unit/user status identifiers from a base status class
so that alias list can support status identifiers.
* Refactors DirectoryPreference from PLaylistPreference.
Adds editor to PreferenceEditor for directories.
Organizes preference editor tree.
* Adds recording directory preference to editor and updates recording
manager to dynamically use this property for recordings.
* Adds event logs directory preference to editor and updates event log
manager to dynamically use this property for event logging.
* Adds application log directory preference. Updates logging to use user
preference for application log directory. Moves logging initialization
into the main application class and removes file based logging configs
from the logback.xml configuration file.
* Refactors application logging into its own class and adds prefeence
update monitoring to dynamically stop/start the logger in the new
directory location.
* Adds streaming and screen capture directories to the user preferences
editor and updates streaming and screen captures to dynamically adapt
to user changes.
* WIP on new P25 message framer.
* WIP on new P25 message framer.
* Adds new 1/2 and 3/4 rate trellis decoders. Still trying to chase
down why there is a sync pattern mismatch in the NID buffer queue.
* WIP - new p25 message framer works correctly now. PDU's are dectected
and decoded using the 1/2 and 3/4 rate trellis decoders. Packet
Sequences are assembled. Need to add a new packet sequence message
factory that can detect Motorola Auto Registration Service (ARS)
formatted UDP/ID packets and SNDCP command packets.
* WIP - removes nullify on channel results queue.
* WIP - updates message framer for TSBK 1/2/3 processing.
* WIP removing P25 sync pattern and nid bits from all message parsers.
* WIP - merges identifier framework branch changes into this branch.
* WIP on updating link control words to new format and identifier framework.
* WIP - implements rest of link control words for extended formats
* WIP - initial work on ISP/OSP TSBK message restructuring.
* WIP - adds more TSBK ISP and OSP messages
* WIP - finished updating most of the TSBK ISP and OSP messages. Converted
all messages to no longer include the NID (nac + dataunitID) so that
each message can simply hold the parsed values. Removed AliasList as
an argument to each message and updated all messges to use the new
IIdentifer and IAPCO25Channel interfaces.
Removed legacy TDU and LDU link control messages and replaced with a
single LinkControlWord class hierarchy.
P25 decoder state is not yet updated for the new message structure.
PDU message parsing is not fully implemented.
* WIP - adds some Multi-Block trunking control messages with Alternate
and Unconfirmed formats.
* WIP - Fully implements AMBTC and UMBTC PDU message parsers.
Some package restructuring.
* WIP - Resolves Link control parsing in LDU1 and 2 messages.
* WIP - finishes updating TSBK and Link Control messages. Adds support
for moto link control messages for patch groups.
* WIP - finishes updating TSBK and Link Control messages. Adds support
for moto link control messages for patch groups. Adds support for moto
ARS service, IPV4 decoding, and UDP/IP packets.
* WIP - finishes SNDCP packet data with header parsing. Compressed IP or
UDP headers are not yet supported, but are logged as such.
* WIP - converts all talkgroup identifiers to integers and updates
alias list to create a per-protocol map of talkgroup id's to alias.
Inserts a legacy talkgroup (ltr, p25, passport, mpt1327, mdc, etc.)
conversion utility to convert existing legacy (string) talkgroups to
new integer talkgroup format.
Creates an audio packet manager to insert metadata into audio packets
before streaming packets for playback, recording, and/or streaming.
Creates identifier collection to manage current identifiers in each of
the channel and decoder states.
Creates simplified channel metadata to maintain the now playing display.
Moves channel attributes (alias list, system, site, name) as configuration
identifiers in the channel state.
Many other refactoring and updates.
* WIP - numerous updates to push use of identifier collection throughout
the system. Updates the channel metadata and audio packet processing
logic. Implements a large portion of the P25 decode state processing.
Updates traffic channel management. Adds user preferences for timestamp
and identifier formatting, however doesn't add a user interface yet.
* WIP - initial implementation of user preferences editor window.
* WIP - updates preferences editor window to close and dispose window but
retain javafx event thread running.
* WIP - fully updates p25 decoder state and traffic channel processing to
use the new identifier framework.
Cleans up channel event processing and removes channel model as the sole
broadcaster of channel events. Channel processing manager now listens
for all start/stop events and requestors dispatch event directly to the
channel processing manager.
Resolves issue in airspy that was causing user interface to lock-up. The
issue appears to occur when the dongle is plugged into a usb port that
can't fully support the data rate. sdrtrunk now recognizes these errors
and warns the user that they should use another usb port.
* WIP - updates alias action manager and adds new talkgroup range alias identifier.
Updates playlist to incorporate a version number so that the playlist
updater only runs when needed, to update a playlist to the correct
version format.
Updates user preferences to use the google event bus to broadcast
preference update notifications to remove the need for listeners to
register directly on the user preferences instance.
* WIP - updates alias id editors to flag invalid values and moves legacy
alias ids to legacy package.
Updates event logging configuration to add traffic channel decode events
and decoded message logging. Removes binary message logging since that
is now replaced with demodulated bitstream recording.
* Removes system properties from user preferences. Preferences are stored
in the OS-dependent settings store (windows - registry)
* Updates MapService to use new PlottableDecodeEvent instead of monitoring
all of the decoded messages.
Updates Fleetsync decoder and related messages to identifier framework.
* Updates LTR-Net, Fleetsync and LJ1200 decoders to new identifier
framework and adds support for user preferences for formatting of
LTR-Net and fleetsync talkgroup identifiers.
Breaks LTR-Net messages into various message types and uses a new
message factory.
Removes alias list from message processing for ltr-net, fleetsync and
lj1200.
* Updates LTR-Standard messages to Identifier framework.
* Removes Plottable and IPlottable from codebase.
* wip
* WIP on MPT-1327 messages.
* Updates MPT1327 decoder to identifier framework and new traffic channel
manager. This decoder still needs to be updated with a new message
parser factory and a sync detector like what is now used for P25.
* Updates MDC1200 decoder and message to identifier framework.
* Updates Tait1200 and Passport decoders to identifier framework.
* Merges changes from master branch.
* Removes legacy alias support classes. Updates passport message processor
to only pass valid messages. Adds support to playlist updater for
converting passport mobile ids to become passport talkgroup values.
* Updates P25 decoder state and channel state to better track allocated
traffic channels. Resolves issue in timestamp manager for trackig
message timestamps. Resolves issue in airspy tuner that was causing
the tuner to stop sending samples to the application.
* Update P25 Decoder state to process SNDCP management messages and
PDU messages.
Updates P25 activity summary to display network and site details.
Resolves issue with overlay panel that prevented enabled channels from
rendering correctly when zoomed in.
* Creates a new FilePreferences as part of the user preferences to begin
the transition of SystemProperties over to user preferences and consolidate
file preferences in one location.
Updates playlist manager to use the new file preferences and to use
default.xml as the new default playlist name, following conversion of
a playlist_v2.xml format to the new format.
In the near future, the user will be able to edit file locations and to
create/use other playlists.
Resolved an issue with all decoder states where not all identifiers were
being included in decode events.
buffers. None of the decoders currently support this yet, but the P25
will be updated to provide bitstream output for recording.
Renames the ReusableBuffer class to ReusableFloatBuffer for
consistency.
the lost connection timeout from default of 60 seconds down to 5 seconds
so that the connection state updates more quickly. Removed complex
error handling and replaced with a simpler approach to catch an error
and disconnect and then attempt a reconnect.
Added new 'Network Unavailable' error state that detects when the network
connection is unavaialable.
Updated the icecast metadata updater to close the TCP session after
successfully writing metadata to the socket.
