zstrike/lucida
1
0
Fork 0
mirror of https://codeberg.org/lucida/lucida.git synced 2026-11-13 23:27:24 -05:00
Code Issues Packages Projects Releases Wiki Activity

drop node-fetch dependency, use undici

Browse Source 
undici's fetch implementation is included in node and has been considered stable since version 21.
for some time I think depending on the undici package instead of the built-in is a good idea so that older nodejs versions will still work correctly.
This commit is contained in:
hazycora
2024-07-30 14:43:25 -04:00
committed by hazel
parent ac1fcc1a44
commit d7ceecb8a5
7 changed files with 26 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/streamers/soundcloud/main.ts
View File

@@ -1,4 +1,4 @@
import fetch, { HeadersInit } from 'node-fetch'
import { fetch, HeadersInit } from 'undici'
import { DEFAULT_HEADERS, SC_VERSION } from './constants.js'
import {
ItemType,
@@ -20,6 +20,7 @@ import {
RawArtist,
ScClient
} from './parse.js'
import { Readable } from 'stream'
function headers(oauthToken?: string | undefined): HeadersInit {
const headers: HeadersInit = DEFAULT_HEADERS
@@ -307,8 +308,8 @@ async function getStream(
const streamResp = await fetch(json.url)
return {
mimeType: transcoding.format.mime_type,
sizeBytes: parseInt(<string>streamResp.headers.get('Content-Length')),
stream: <NodeJS.ReadableStream>streamResp.body
sizeBytes: parseInt(streamResp.headers.get('Content-Length')!),
stream: Readable.fromWeb(streamResp.body!)
}
} else {
const container = transcoding.format.mime_type.split('/')[1].split(';')[0].split('+')[0]

9
src/streamers/soundcloud/parse.ts
View File

@@ -1,6 +1,6 @@
import { Artist, Album, Track } from '../../types.js'
import { spawn } from 'child_process'
import fetch from 'node-fetch'
import { fetch } from 'undici'
import { imageSize as sizeOf } from 'image-size'
import os from 'node:os'
import fs from 'node:fs'
@@ -9,11 +9,8 @@ import path from 'node:path'
async function parseCoverArtwork(url: string) {
const resp = await fetch(url)
if (!resp.body) throw new Error('No body on image')
const chunks = []
for await (const chunk of resp.body) {
chunks.push(Buffer.from(chunk))
}
const dimensions = sizeOf(Buffer.concat(chunks))
const body = await resp.arrayBuffer()
const dimensions = sizeOf(new Uint8Array(body))
if (!dimensions.width || !dimensions.height) throw new Error(`Couldn't get dimensions`)
return {
url,