#2634 Gradle build now uses git tag for versioning (#2635)

Co-authored-by: denny <dennis.sheirer@gmail.com>

.github/workflows/nightly.yml

@@ -14,6 +14,9 @@ jobs:
 
     steps:
       - uses: actions/checkout@v7
+        with:
+          # Full history and tags, so the build can describe the commit relative to the latest version tag
+          fetch-depth: 0
 
       - name: Set up JDK 27
         uses: actions/setup-java@v6
@@ -34,7 +37,7 @@ jobs:
 
       - name: Create Build Info file
         run: |
-          echo -e "ref: $GITHUB_REF \ncommit: $GITHUB_SHA\nbuild: $(date +"%Y-%m-%dT%H:%M:%SZ")" > build/image/build_info.txt
+          echo -e "ref: $GITHUB_REF \ncommit: $GITHUB_SHA\ndescribe: $(git describe --tags --match 'v[0-9]*' --dirty)\nbuild: $(date +"%Y-%m-%dT%H:%M:%SZ")" > build/image/build_info.txt
 
       - name: Add build artifacts to nightly release
         uses: softprops/action-gh-release@v3

.github/workflows/release.yml

@@ -1,6 +1,6 @@
-# Publishes a release when a version tag is pushed. The tag has to match
-# projectVersion in gradle.properties with a leading 'v': v0.6.2 for a final
-# release, or v0.6.2-beta-1 / v0.6.2-alpha-1 for a pre-release.
+# Publishes a release when a version tag is pushed: v0.6.2 for a final release,
+# or v0.6.2-beta-1 / v0.6.2-alpha-1 for a pre-release. The build derives the
+# version from the tag (see build.gradle).
 name: Release
 
 on:
@@ -22,15 +22,6 @@ jobs:
           # Full history and tags, to find the previous release tag for the release notes
           fetch-depth: 0
 
-      - id: version
-        run: |
-          expected="v$(sed -n 's/^projectVersion=//p' gradle.properties | tr -d '[:space:]')"
-          if [ "$GITHUB_REF_NAME" != "$expected" ]; then
-            echo "::error::Tag $GITHUB_REF_NAME does not match projectVersion in gradle.properties ($expected)"
-            exit 1
-          fi
-          echo "version=${GITHUB_REF_NAME#v}" >> "$GITHUB_OUTPUT"
-
       # Release notes list the PRs since the previous version tag (never 'nightly'). A final release
       # starts from the previous final release, so it covers every alpha and beta in between.
       - id: previous
@@ -54,6 +45,17 @@ jobs:
       - name: Set up Gradle
         uses: gradle/actions/setup-gradle@v6
 
+      # The version comes from 'git describe', which can pick a different tag when more than one
+      # version tag points at the same commit. Fail rather than publish zips with the wrong version.
+      - id: version
+        run: |
+          version="$(./gradlew -q printVersion --console=plain | tail -n 1)"
+          if [ "v$version" != "$GITHUB_REF_NAME" ]; then
+            echo "::error::Build version $version does not match tag $GITHUB_REF_NAME"
+            exit 1
+          fi
+          echo "version=$version" >> "$GITHUB_OUTPUT"
+
       - name: Build and test
         run: ./gradlew clean build --console=plain
 

README.md

@@ -54,17 +54,19 @@ committed to the code base, so it's not really 'nightly' as much as it is 'curre
 Releases are built and published automatically by the [Release](.github/workflows/release.yml) GitHub workflow
 whenever a version tag is pushed to the repository.
 
-1. Update `projectVersion` in `gradle.properties` to the new version, following the naming convention described in
-that file (e.g. `0.6.2-alpha-1`, `0.6.2-beta-1` or `0.6.2`).
-2. Commit and push the change to `master`.
-3. Create and push a tag that matches the version with a leading `v`:
+The version is taken from the tag, so there is no version number to update in the code. Create and push a tag
+with a leading `v`, following the naming convention described in `gradle.properties` (e.g. `v0.6.2-alpha-1`,
+`v0.6.2-beta-1` or `v0.6.2`):
 ```
 git tag v0.6.2-beta-1
 git push origin v0.6.2-beta-1
 ```
 
+Builds made from an untagged commit get a version like `0.6.2-beta-1-14-g4626d567` (14 commits after the
+`v0.6.2-beta-1` tag, at commit `4626d567`), with `-dirty` appended when there are uncommitted changes.
+
 The workflow then:
-* Verifies that the tag matches `projectVersion` in `gradle.properties` and fails if it does not.
+* Verifies that the version the build derives from git matches the tag and fails if it does not.
 * Builds and tests the code, then creates the release zips for Linux, Mac and Windows (x86-64 and aarch64).
 * Creates a GitHub release titled `Version <version>` with auto-generated release notes (a "What's Changed" list of
 the PRs merged since the previous version tag), and attaches the six zip

build.gradle

@@ -52,8 +52,44 @@ plugins {
     id 'org.beryx.runtime' version '2.0.1'
 }
 
-//Version is defined in gradle.properties so that we can CLI override it for nightly builds.
-version = project.findProperty('projectVersion')
+/**
+ * Version is derived from the most recent 'v<version>' git tag (e.g. v1.0.0-beta-1 -> 1.0.0-beta-1).  Commits after
+ * the tag produce a version like 1.0.0-beta-1-14-g4626d567 and uncommitted changes append '-dirty'.  The moving
+ * 'nightly' tag is ignored.  Override with -PprojectVersion=<version> (the nightly build uses 'nightly' so that the
+ * nightly release asset names stay the same).  Falls back to 'unknown' when built outside a git checkout.
+ */
+String gitDescribe = describeGitVersion()
+version = project.findProperty('projectVersion') ?: (gitDescribe ? gitDescribe.substring(1) : 'unknown')
+
+String describeGitVersion()
+{
+    try
+    {
+        def describe = providers.exec {
+            commandLine 'git', 'describe', '--tags', '--match', 'v[0-9]*', '--dirty'
+            ignoreExitValue = true
+        }
+
+        if(describe.result.get().exitValue == 0)
+        {
+            return describe.standardOutput.asText.get().trim()
+        }
+    }
+    catch(Exception e)
+    {
+        logger.warn("Unable to determine version from git tags: " + e.message)
+    }
+
+    return null
+}
+
+tasks.register('printVersion') {
+    description = 'Prints the project version'
+    def projectVersion = version
+    doLast {
+        println projectVersion
+    }
+}
 
 //Java 27 is required for this version of the Project Panama preview/incubator feature
 java {
@@ -95,35 +131,34 @@ test {
 dependencies {
 
     // JUnit Tests
-    testImplementation(platform("org.junit:junit-bom:6.0.1"))
-    testImplementation 'org.junit.jupiter:junit-jupiter-api:6.0.1'
-    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:6.0.1")
-    testRuntimeOnly("org.junit.vintage:junit-vintage-engine:6.0.1")
+    testImplementation(platform("org.junit:junit-bom:6.1.3"))
+    testImplementation 'org.junit.jupiter:junit-jupiter-api'
+    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine")
     testRuntimeOnly("org.junit.platform:junit-platform-launcher")
 
     //Jitpack imports
     implementation 'com.github.dnault:libresample4j:master'
-    implementation 'com.github.DSheirer.jmbe:api:v2.1.0'
+    implementation 'com.github.DSheirer.jmbe:api:v2.1.1'
     implementation 'com.github.nwaldispuehl:java-lame:v3.98.4'
 
     //mavenCentral/jcenter imports
-    implementation 'ch.qos.logback:logback-classic:1.6.3'
-    implementation 'ch.qos.logback:logback-core:1.5.38'
-    implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.22.4'
-    implementation 'com.fazecast:jSerialComm:2.11.4'
-    implementation 'com.formdev:flatlaf:3.7.2'
-    implementation 'com.formdev:flatlaf-intellij-themes:3.7.2'
+    implementation 'ch.qos.logback:logback-classic:1.6.6'
+    implementation 'ch.qos.logback:logback-core:1.6.6'
+    implementation 'com.fasterxml.jackson.dataformat:jackson-dataformat-xml:2.23.0'
+    implementation 'com.formdev:flatlaf:3.8'
+    implementation 'com.formdev:flatlaf-intellij-themes:3.8' //Not imported - Theme.java loads these themes by class name
     implementation 'com.github.jiconfont:jiconfont-font_awesome:4.7.0.1'
     implementation 'com.github.jiconfont:jiconfont-javafx:1.0.0'
     implementation 'com.github.jiconfont:jiconfont-swing:1.0.1'
-    implementation 'com.github.wendykierp:JTransforms:3.2'
-    implementation 'com.google.code.gson:gson:2.14.0'
-    implementation 'com.google.guava:guava:33.6.0-jre'
+    implementation('com.github.wendykierp:JTransforms:3.2') {
+        exclude group: 'junit' //JLargeArrays 1.7 declares junit as a compile dependency
+    }
+    implementation 'com.google.code.gson:gson:2.15.0'
+    implementation 'com.google.guava:guava:33.8.0-jre'
     implementation 'com.jidesoft:jide-oss:3.6.18'
-    implementation 'com.miglayout:miglayout-swing:11.4.3'
+    implementation 'com.miglayout:miglayout-swing:11.5.2'
     implementation 'com.mpatric:mp3agic:0.9.1'
     implementation 'commons-io:commons-io:2.22.0'
-    implementation 'eu.hansolo:charts:1.0.5'
     implementation 'io.github.dsheirer:jairspy:1.0.12.1' //Airspy tuners - GitHub release, see settings.gradle
     implementation 'io.github.dsheirer:jairspyhf:1.8.1.1' //Airspy HF+ tuners - GitHub release, see settings.gradle
     implementation 'io.github.dsheirer:jbladerf:2.6.0.1' //bladeRF tuners - GitHub release, see settings.gradle
@@ -131,20 +166,18 @@ dependencies {
     implementation 'io.github.dsheirer:jlibusb:1.0.30.1' //libusb and USB hotplug for the tuner libraries - GitHub release; not pulled in transitively
     implementation 'io.github.dsheirer:jhydrasdr:1.1.4.1' //HydraSDR tuners - GitHub release, see settings.gradle
     implementation 'io.github.dsheirer:jlimesdr:25.1.0.2' //LimeSDR tuners - GitHub release, see settings.gradle
-    implementation 'io.github.dsheirer:jrtl:1.4.0.2' //RTL-SDR tuners - GitHub release, see settings.gradle
+    implementation 'io.github.dsheirer:jrtl:1.4.0.3' //RTL-SDR tuners - GitHub release, see settings.gradle
     implementation 'io.github.dsheirer:jsdrplay:3.15.3' //SDRplay RSP tuners - GitHub release, see settings.gradle
     implementation 'io.github.dsheirer:radio-reference-api:18.0.0'
-    implementation 'net.coderazzi:tablefilter-swing:5.5.4'
-    implementation 'org.apache.commons:commons-compress:1.28.0'
-    implementation 'org.apache.commons:commons-lang3:3.20.0'
+    implementation 'org.apache.commons:commons-compress:1.28.0' //Not used directly - overrides the vulnerable 1.21 version from jarchivelib
+    implementation 'org.apache.commons:commons-lang3:3.21.0'
     implementation 'org.apache.commons:commons-math3:3.6.1'
     implementation 'org.apache.commons:commons-csv:1.14.1'
-    implementation 'org.apache.mina:mina-core:2.2.9'
-    implementation 'org.apache.mina:mina-http:2.2.9'
-    implementation 'org.controlsfx:controlsfx:11.2.3'
+    implementation 'org.apache.mina:mina-core:2.2.10'
+    implementation 'org.apache.mina:mina-http:2.2.10'
+    implementation 'org.controlsfx:controlsfx:11.2.6'
     implementation 'org.rauschig:jarchivelib:1.2.0'
-    implementation 'org.slf4j:slf4j-api:2.0.17'
-    implementation 'pl.edu.icm:JLargeArrays:1.6'
+    implementation 'org.slf4j:slf4j-api:2.0.20'
 }
 
 def os = DefaultNativePlatform.currentOperatingSystem
@@ -205,6 +238,7 @@ jar {
         attributes (
                 'Implementation-Title'  : 'sdrtrunk project',
                 'Implementation-Version' : archiveVersion,
+                'Git-Describe'          : gitDescribe ?: 'unknown',
                 'Created-By'            : "Gradle ${gradle.gradleVersion}",
                 'Build-Timestamp'       : new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSSZ").format(new Date()),
                 'Build-JDK'             : "${System.properties['java.version']} (${System.properties['java.vendor']} ${System.properties['java.vm.version']}",
@@ -235,18 +269,6 @@ String targetOsxX86_64 = 'osx-x86_64-v' + version
 String targetWindowsX86_64 = 'windows-x86_64-v' + version
 String targetWindowsAarch64 = 'windows-aarch64-v' + version
 
-/**
- * Optional pre-downloaded Java Development Kit (JDK) for each target OS and CPU.  These locations are hard-coded to the
- * author's development environment, but can be changed to your environment if you want to use this build pattern.
- */
-String jdk_base = '/home/denny/java_jdks/'
-String jdk_linux_aarch64 = jdk_base + 'linux-arm64/jdk-25.0.1-full'
-String jdk_linux_x86_64 = jdk_base + 'linux-x64/jdk-25.0.1-full'
-String jdk_osx_x86_64 = jdk_base + 'osx-x64/jdk-25.0.1-full.jdk'
-String jdk_osx_aarch64 = jdk_base + 'osx-arm64/jdk-25.0.1-full.jdk'
-String jdk_windows_x86_64 = jdk_base + 'windows-x64/jdk-25.0.1-full'
-String jdk_windows_aarch64 = jdk_base + 'windows-arm64/jdk-25.0.1-full'
-
 /**
  * Download URLs to download the JDK as part of the gradle build packaging process
  */
@@ -275,19 +297,138 @@ def configure(RuntimeZipTask rt, List<String> jvmArgs) {
     //jdk.incubator.vector - needed for Project Panama foreign function and vector apis
     //jdk.accessibility is used with assistive technologies like screen readers
     //java.management for JVM resource monitoring
-    rt.extension.addModules('jdk.charsets', 'jdk.crypto.ec', 'jdk.incubator.vector', 'jdk.accessibility', 'java.management')
+    //java.base, java.logging, java.net.http, java.prefs, javafx.controls, javafx.swing - required by sdrtrunk (jdeps)
+    rt.extension.addModules('jdk.charsets', 'jdk.crypto.ec', 'jdk.incubator.vector', 'jdk.accessibility', 'java.management',
+            'java.base', 'java.logging', 'java.net.http', 'java.prefs', 'javafx.controls', 'javafx.swing')
 
-    //Use auto-detected modules and 'add' any specified modules.
-    rt.extension.additive.set(true)
+    //Use only the modules listed above.  The runtime plugin's module auto-detection uses a bundled ASM library that
+    //can't read Java 27 class files and logs a 'Failed to scan' error for each sdrtrunk class.  The jdeps module check
+    //on the runtime task verifies that this list is complete.
+    rt.extension.additive.set(false)
 
     //Recommended options for reducing/shrinking runtime target image size
-    rt.extension.addOptions('--strip-debug', '--compress', '2', '--no-header-files', '--no-man-pages')
+    rt.extension.addOptions('--strip-debug', '--compress', 'zip-6', '--no-header-files', '--no-man-pages')
 
     //Runtime images have auto appended version in image zip name.  Override to include version in single target image.
 //    rt.extension.imageDir=layout.buildDirectory.dir('image')
     rt.extension.imageZip.set(file(layout.buildDirectory.dir('image').get().file('sdr-trunk.zip')))
 }
 
+/**
+ * Rewrites the jar file without the native library folders for other operating systems and architectures.  Fails the
+ * build if a jar that contains native libraries doesn't contain the folder for the target.
+ * @param jar file to rewrite
+ * @param keep native folder for the target
+ * @return number of bytes removed from the jar
+ */
+long stripJar(File jar, String keep) {
+    def tunerPattern = ~/^[^\/]+\/native\/([^\/]+)\/.*/
+    def removed = [] as Set
+    def hadTuner = false, keptTuner = false
+    File temp = new File(jar.parentFile, jar.name + '.tmp')
+
+    new java.util.zip.ZipFile(jar).withCloseable { zip ->
+        def entries = zip.entries().toList()
+
+        entries.each { e ->
+            def tuner = tunerPattern.matcher(e.name)
+
+            if(tuner.matches()) {
+                hadTuner = true
+                if(tuner.group(1) == keep) { keptTuner = true } else { removed << e.name }
+            }
+        }
+
+        if(hadTuner && !keptTuner) {
+            throw new GradleException("Native strip: ${jar.name} has no native/${keep} folder")
+        }
+
+        if(!removed.isEmpty()) {
+            new java.util.zip.ZipOutputStream(new FileOutputStream(temp)).withCloseable { out ->
+                entries.findAll { !removed.contains(it.name) }.each { e ->
+                    def copy = new java.util.zip.ZipEntry(e)
+                    if(copy.method == java.util.zip.ZipEntry.DEFLATED) {
+                        copy.compressedSize = -1
+                    }
+                    out.putNextEntry(copy)
+                    zip.getInputStream(e).withCloseable { out << it }
+                    out.closeEntry()
+                }
+            }
+        }
+    }
+
+    if(removed.isEmpty()) {
+        return 0
+    }
+
+    long before = jar.length()
+    java.nio.file.Files.move(temp.toPath(), jar.toPath(), java.nio.file.StandardCopyOption.REPLACE_EXISTING)
+    return before - jar.length()
+}
+
+/**
+ * Removes the native libraries for other operating systems and architectures from the jars in each runtime target
+ * image, before the runtimeZip tasks package the images.  The tuner libraries (jRTL, jAirspy, etc.) package their
+ * native libraries under '<library>/native/<os>-<arch>/', where the folder name matches the runtime target name
+ * '<os>-<arch>-v<version>' without the version suffix, except that the libraries use 'macos' where the target uses 'osx'.
+ */
+tasks.named('runtime') {rt ->
+    rt.doLast {
+        rt.targetPlatforms.get().keySet().each { target ->
+            def nativeFolder = (target - "-v${version}").replaceFirst(/^osx-/, 'macos-')
+            def lib = new File(rt.imageDir.asFile, "${project.name}-${target}/lib")
+            long total = 0
+            lib.listFiles({ File f -> f.name.endsWith('.jar') } as FileFilter).each { jar ->
+                total += stripJar(jar, nativeFolder)
+            }
+            logger.lifecycle("Native strip: removed ${String.format('%.1f', total / 1048576)} MB of other " +
+                    "platform native libraries from [${target}]")
+        }
+    }
+}
+
+/**
+ * Verifies that each runtime target image contains every module that the sdrtrunk jar requires, as reported by jdeps.
+ * This guards against the runtime plugin's module auto-detection silently missing modules (e.g. when it can't parse
+ * class files compiled for a newer Java version).
+ */
+def jdepsHome = javaToolchains.launcherFor(java.toolchain).map { it.metadata.installationPath.asFile }
+def mainJar = tasks.named('jar').flatMap { it.archiveFile }
+
+tasks.named('runtime') {rt ->
+    rt.doLast {
+        def jdeps = new File(jdepsHome.get(), 'bin/' + (os.isWindows() ? 'jdeps.exe' : 'jdeps')).absolutePath
+        def process = new ProcessBuilder(jdeps, '--multi-release', java.toolchain.languageVersion.get().toString(),
+                '--ignore-missing-deps', '--print-module-deps', '-q', mainJar.get().asFile.absolutePath)
+                .redirectErrorStream(true).start()
+        def output = process.inputStream.text.trim()
+
+        if(process.waitFor() != 0) {
+            throw new GradleException("Module check: jdeps failed: ${output}")
+        }
+
+        def required = output.split(',')*.trim().findAll { it } as Set
+
+        rt.targetPlatforms.get().keySet().each { target ->
+            def release = new File(rt.imageDir.asFile, "${project.name}-${target}/release")
+            def match = release.text =~ /(?m)^MODULES="([^"]*)"/
+
+            if(!match.find()) {
+                throw new GradleException("Module check: no MODULES entry in ${release}")
+            }
+
+            def missing = required - (match.group(1).split(' ') as Set)
+
+            if(missing) {
+                throw new GradleException("Module check: runtime image [${target}] is missing required modules " +
+                        "${missing.sort()} - add them to addModules() in build.gradle")
+            }
+        }
+        logger.lifecycle("Module check: runtime images contain all modules required by sdrtrunk: ${required.sort()}")
+    }
+}
+
 /**
  * Creates a release package for the current operating system.
  *
@@ -344,22 +485,12 @@ tasks.register('runtimeZipCurrent', RuntimeZipTask) {rt ->
  */
 tasks.register('runtimeZipWindows', RuntimeZipTask) {rt ->
     //Windows aarch64
-    if(file(jdk_windows_aarch64).exists()) {
-        rt.extension.targetPlatform(targetWindowsAarch64, jdk_windows_aarch64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetWindowsAarch64) {
-            jdkHome = jdkDownload(jdk_download_windows_aarch64)
-        }
+    rt.extension.targetPlatform(targetWindowsAarch64) {
+        jdkHome = jdkDownload(jdk_download_windows_aarch64)
     }
     //Windows x86-64
-    if(file(jdk_windows_x86_64).exists()) {
-        rt.extension.targetPlatform(targetWindowsX86_64, jdk_windows_x86_64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetWindowsX86_64) {
-            jdkHome = jdkDownload(jdk_download_windows_x86_64)
-        }
+    rt.extension.targetPlatform(targetWindowsX86_64) {
+        jdkHome = jdkDownload(jdk_download_windows_x86_64)
     }
 
     configure(rt, jvmArgsWindows)
@@ -376,40 +507,20 @@ tasks.register('runtimeZipWindows', RuntimeZipTask) {rt ->
  */
 tasks.register('runtimeZipOthers', RuntimeZipTask) {rt ->
     //Linux aarch64
-    if(file(jdk_linux_aarch64).exists()) {
-        rt.extension.targetPlatform(targetLinuxAarch64, jdk_linux_aarch64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetLinuxAarch64) {
-            jdkHome = jdkDownload(jdk_download_linux_aarch64)
-        }
+    rt.extension.targetPlatform(targetLinuxAarch64) {
+        jdkHome = jdkDownload(jdk_download_linux_aarch64)
     }
     //Linux x86-64
-    if(file(jdk_linux_x86_64).exists()) {
-        rt.extension.targetPlatform(targetLinuxX86_64, jdk_linux_x86_64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetLinuxX86_64) {
-            jdkHome = jdkDownload(jdk_download_linux_x86_64)
-        }
+    rt.extension.targetPlatform(targetLinuxX86_64) {
+        jdkHome = jdkDownload(jdk_download_linux_x86_64)
     }
     //OSX aarch64
-    if(file(jdk_osx_aarch64).exists()) {
-        rt.extension.targetPlatform(targetOsxAarch64, jdk_osx_aarch64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetOsxAarch64) {
-            jdkHome = jdkDownload(jdk_download_osx_aarch64)
-        }
+    rt.extension.targetPlatform(targetOsxAarch64) {
+        jdkHome = jdkDownload(jdk_download_osx_aarch64)
     }
     //OSX x86-64
-    if(file(jdk_osx_x86_64).exists()) {
-        rt.extension.targetPlatform(targetOsxX86_64, jdk_osx_x86_64, [])
-    }
-    else {
-        rt.extension.targetPlatform(targetOsxX86_64) {
-            jdkHome = jdkDownload(jdk_download_osx_x86_64)
-        }
+    rt.extension.targetPlatform(targetOsxX86_64) {
+        jdkHome = jdkDownload(jdk_download_osx_x86_64)
     }
 
     configure(rt, jvmArgsLinux)

gradle.properties

@@ -17,15 +17,16 @@
 # *****************************************************************************
 #
 
-# Version naming conventions:
-#   Alpha: maj.min.patch-alpha-build
-#    Beta: maj.min.patch-beta-build
-# Release: maj.min.patch
+# The project version is no longer defined here.  It is derived from the most recent 'v<version>' git tag (see
+# build.gradle) and can be overridden with -PprojectVersion=<version>.
 #
-# Example: 0.6.0-beta-5
+# Version tag naming conventions:
+#   Alpha: vmaj.min.patch-alpha-build
+#    Beta: vmaj.min.patch-beta-build
+# Release: vmaj.min.patch
 #
-# Note: this is so that the file names for the resultant release build products match the GitLab release asset
+# Example: v0.6.0-beta-5
+#
+# Note: this is so that the file names for the resultant release build products match the GitHub release asset
 # tag name, specifically the dashes inserted before and after the alpha/beta labels.
 # See: https://github.com/DSheirer/sdrtrunk/issues/1651
-
-projectVersion=1.0.0-beta-1

gradle/wrapper/gradle-wrapper.properties

@@ -1,6 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-9.9.0-bin.zip
 networkTimeout=10000
 retries=0
 retryBackOffMs=500

gradlew.bat

@@ -26,6 +26,33 @@
 @rem Set local scope for the variables, and ensure extensions are enabled
 setlocal EnableExtensions
 
+@rem Catch executions from older scripts and ensure they exit cleanly.
+@rem This can be removed once we can be reasonably confident that few people
+@rem will be migrating directly to this new wrapper.
+goto afterSafetyNet
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
+goto exitWithErrorLevel
+:afterSafetyNet
+
 set DIRNAME=%~dp0
 if "%DIRNAME%"=="" set DIRNAME=.
 @rem This is normally unused
@@ -45,13 +72,14 @@ set JAVA_EXE=java.exe
 %JAVA_EXE% -version >NUL 2>&1
 if %ERRORLEVEL% equ 0 goto execute
 
-echo. 1>&2
-echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2
-echo. 1>&2
-echo Please set the JAVA_HOME variable in your environment to match the 1>&2
-echo location of your Java installation. 1>&2
+1>&2 echo.
+1>&2 echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.
+1>&2 echo.
+1>&2 echo Please set the JAVA_HOME variable in your environment to match the
+1>&2 echo location of your Java installation.
 
 "%COMSPEC%" /c exit 1
+goto exitWithErrorLevel
 
 :findJavaFromJavaHome
 set JAVA_HOME=%JAVA_HOME:"=%
@@ -59,13 +87,14 @@ set JAVA_EXE=%JAVA_HOME%/bin/java.exe
 
 if exist "%JAVA_EXE%" goto execute
 
-echo. 1>&2
-echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2
-echo. 1>&2
-echo Please set the JAVA_HOME variable in your environment to match the 1>&2
-echo location of your Java installation. 1>&2
+1>&2 echo.
+1>&2 echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME%
+1>&2 echo.
+1>&2 echo Please set the JAVA_HOME variable in your environment to match the
+1>&2 echo location of your Java installation.
 
 "%COMSPEC%" /c exit 1
+goto exitWithErrorLevel
 
 :execute
 @rem Setup the command line
@@ -75,8 +104,9 @@ echo location of your Java installation. 1>&2
 @rem Execute gradlew
 @rem endlocal doesn't take effect until after the line is parsed and variables are expanded
 @rem which allows us to clear the local environment before executing the java command
-endlocal & "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* & call :exitWithErrorLevel
+endlocal & "%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -jar "%APP_HOME%\gradle\wrapper\gradle-wrapper.jar" %* & call :exitWithErrorLevel & goto exitWithErrorLevel
 
+@rem This label must not be changed. We rely on old scripts being able to jump to this point.
 :exitWithErrorLevel
 @rem Use "%COMSPEC%" /c exit to allow operators to work properly in scripts
 "%COMSPEC%" /c exit %ERRORLEVEL%

settings.gradle

@@ -7,7 +7,7 @@ dependencyResolutionManagement {
     repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
     repositories {
         mavenCentral()
-        maven { url 'https://jitpack.io' }
+        maven { url = 'https://jitpack.io' }
 
         //jAirspy is published as a GitHub release, with the native libraries for all platforms in the jar
         ivy {

src/main/java/io/github/dsheirer/audio/convert/thumbdv/ThumbDv.java

@@ -1,483 +0,0 @@
-/*
- * *****************************************************************************
- * Copyright (C) 2014-2022 Dennis Sheirer
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- * ****************************************************************************
- */
-
-package io.github.dsheirer.audio.convert.thumbdv;
-
-import com.fazecast.jSerialComm.SerialPort;
-import io.github.dsheirer.audio.convert.thumbdv.message.AmbeMessage;
-import io.github.dsheirer.audio.convert.thumbdv.message.AmbeMessageFactory;
-import io.github.dsheirer.audio.convert.thumbdv.message.VocoderRate;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.AmbeRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.DecodeSpeechRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.EncodeSpeechRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.ResetRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.SetVocoderParametersRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.request.SetVocoderRequest;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.DecodeSpeechResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.ReadyResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetVocoderParameterResponse;
-import io.github.dsheirer.sample.Listener;
-import io.github.dsheirer.util.ThreadPool;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.io.InputStream;
-import java.util.ArrayList;
-import java.util.Arrays;
-import java.util.List;
-import java.util.concurrent.LinkedTransferQueue;
-import java.util.concurrent.ScheduledFuture;
-import java.util.concurrent.TimeUnit;
-
-/**
- * Northwest Digital Radio (NWDR) ThumbDv dongle.
- *
- * Note: linux users must allow access to the serial port:
- *
- * sudo usermod -a -G uucp username
- * sudo usermod -a -G dialout username
- * sudo usermod -a -G lock username
- * sudo usermod -a -G tty username
- */
-public class ThumbDv implements AutoCloseable
-{
-    private final static Logger mLog = LoggerFactory.getLogger(ThumbDv.class);
-    private static final String PORT_DESCRIPTION = "USB-to-Serial Port (ftdi_sio)";
-    private static final String PORT_DESCRIPTION_FRAGMENT = "USB Serial Port";
-    private static final int BAUD_RATE = 460800;
-    private static final byte PACKET_START = (byte) 0x61;
-
-    public enum AudioProtocol
-    {
-        DMR,
-        DSTAR,
-        NXDN,
-        P25_PHASE2,
-    }
-
-    private SerialPort mSerialPort;
-    private ScheduledFuture mSerialPortReaderHandle;
-    private ScheduledFuture mAudioDecodeProcessorHandle;
-    private LinkedTransferQueue<DecodeSpeechRequest> mDecodeSpeechRequests = new LinkedTransferQueue<>();
-    private AudioProtocol mAudioProtocol;
-    private Listener<float[]> mAudioBufferListener;
-    private boolean mStarted;
-
-    public ThumbDv(AudioProtocol audioProtocol, Listener<float[]> listener)
-    {
-        mAudioProtocol = audioProtocol;
-        mAudioBufferListener = listener;
-    }
-
-    /**
-     * Enqueues the audio code frame for decoding.  Decoded PCM speech packet will be sent to the registered
-     * audio packet listener.
-     *
-     * @param codecFrame
-     */
-    public void decode(byte[] codecFrame)
-    {
-        if(!mStarted || mSerialPort == null)
-        {
-            throw new IllegalStateException("Must invoke start() method and thumbdv serial device must be available");
-        }
-
-        mDecodeSpeechRequests.offer(new DecodeSpeechRequest(codecFrame));
-    }
-
-    public void close() throws IOException
-    {
-        if(mSerialPortReaderHandle != null)
-        {
-            mSerialPortReaderHandle.cancel(true);
-            mSerialPortReaderHandle = null;
-        }
-
-        if(mSerialPort != null)
-        {
-            mSerialPort.closePort();
-        }
-    }
-
-    public void start() throws IOException
-    {
-        if(mSerialPort == null)
-        {
-            SerialPort[] ports = SerialPort.getCommPorts();
-
-            for(SerialPort port : ports)
-            {
-                mLog.debug("Serial Port Name:" + port.getDescriptivePortName());
-                if(port.getDescriptivePortName().contentEquals(PORT_DESCRIPTION) ||
-                        port.getDescriptivePortName().contains(PORT_DESCRIPTION_FRAGMENT))
-                {
-                    mSerialPort = port;
-                    mSerialPort.setBaudRate(BAUD_RATE);
-                    mSerialPort.openPort(0, 5000, 10000);
-
-                    if(mSerialPort.isOpen())
-                    {
-                        mLog.info("Resetting ThumbDv Device");
-                        send(new ResetRequest());
-
-                        mLog.info("Creating Serial Port Reader");
-                        final Runnable r = new SerialPortReader(mSerialPort.getInputStream());
-                        mLog.info("Starting Serial Port Reader");
-                        mSerialPortReaderHandle = ThreadPool.SCHEDULED.scheduleAtFixedRate(r, 0,
-                                5, TimeUnit.MILLISECONDS);
-
-                        mStarted = true;
-                        mLog.info("Startup complete - awaiting reset response");
-                    }
-                    else
-                    {
-                        mLog.warn("Could not open serial port: " + mSerialPort.getSystemPortName());
-                        throw new IOException("Could not open serial port:" + mSerialPort.getSystemPortName());
-                    }
-
-                    break;
-                }
-            }
-        }
-
-        if(mSerialPort == null)
-        {
-            throw new IOException("ThumbDV serial port not found");
-        }
-
-
-        return;
-    }
-
-    public void send(byte[] message) throws IOException
-    {
-        if(mSerialPort == null)
-        {
-            throw new IOException("ThumbDv must be started before use");
-        }
-
-        int bytesWritten = mSerialPort.writeBytes(message, message.length);
-
-        if(bytesWritten < 0)
-        {
-            throw new IOException("Unable to write message:" + Arrays.toString(message));
-        }
-        else if(bytesWritten != message.length)
-        {
-            throw new IOException("Unable to write message:" + Arrays.toString(message) + " Bytes Written:" + bytesWritten);
-        }
-    }
-
-    /**
-     * Sends the AMBE request message
-     *
-     * @param request message
-     * @throws IOException if there is an error
-     */
-    public void send(AmbeRequest request) throws IOException
-    {
-        send(request.getData());
-    }
-
-    private void receive(byte[] bytes)
-    {
-        AmbeMessage message = AmbeMessageFactory.getMessage(bytes);
-
-        if(message instanceof DecodeSpeechResponse && mAudioBufferListener != null)
-        {
-            float[] samples = ((DecodeSpeechResponse)message).getSamples();
-            mAudioBufferListener.receive(samples);
-        }
-        else if(message instanceof ReadyResponse && mAudioDecodeProcessorHandle == null)
-        {
-            if(mAudioDecodeProcessorHandle == null)
-            {
-                try
-                {
-                    switch(mAudioProtocol)
-                    {
-                        case DSTAR:
-                            send(new SetVocoderRequest(VocoderRate.RATE_33));
-                            send(new SetVocoderParametersRequest(0x0130, 0x0763, 0x4000, 0x0000, 0x0000, 0x0048));
-                            break;
-                        case DMR:
-                        case NXDN:
-                        case P25_PHASE2:
-                            send(new SetVocoderRequest(VocoderRate.RATE_33));
-                            send(new SetVocoderParametersRequest(0x0431, 0x0754, 0x2400, 0x0000, 0x0000, 0x6F48));
-                            break;
-                        default:
-                            throw new IllegalStateException("Unrecognized audio protocol:" + mAudioProtocol);
-                    }
-                }
-                catch(IOException ioe)
-                {
-                    mLog.error("Error setting audio protocol vocoder parameters");
-                }
-
-                mLog.info("ThumbDv Reset Complete");
-            }
-            else
-            {
-                mLog.info("ThumbDv Reset Detected");
-            }
-        }
-        else if(message instanceof SetVocoderParameterResponse)
-        {
-            if(((SetVocoderParameterResponse)message).isSuccessful())
-            {
-                mLog.info("Audio vocoder parameters configured for " + mAudioProtocol);
-                //Start the audio frame decode processor
-                mAudioDecodeProcessorHandle = ThreadPool.SCHEDULED.scheduleAtFixedRate(new AudioDecodeProcessor(), 0,
-                        10, TimeUnit.MILLISECONDS);
-            }
-        }
-        else if(message != null)
-        {
-            mLog.debug("RECEIVED:" + message.toString());
-        }
-    }
-
-    /**
-     * Logs the current settings of the serial port.  Note: you must invoke start() before this method so that
-     * the serial port can be discovered and opened.
-     */
-    public void logSerialPort()
-    {
-        if(mSerialPort != null)
-        {
-            StringBuilder sb = new StringBuilder();
-            sb.append("\nPort:\t\t\t").append(mSerialPort.getSystemPortName()).append("\n");
-            sb.append("Name:\t\t\t").append(mSerialPort.getDescriptivePortName()).append("\n");
-            sb.append("Baud Rate:\t\t").append(mSerialPort.getBaudRate()).append("\n");
-            sb.append("Data Bits:\t\t").append(mSerialPort.getNumDataBits()).append("\n");
-            sb.append("Parity Bits:\t").append(mSerialPort.getParity()).append("\n");
-            sb.append("Stop Bits:\t\t").append(mSerialPort.getNumStopBits()).append("\n");
-            sb.append("Flow Control:\t").append(mSerialPort.getFlowControlSettings()).append("\n");
-            sb.append("Is Open:\t\t").append(mSerialPort.isOpen()).append("\n");
-
-            mLog.info(sb.toString());
-        }
-        else
-        {
-            mLog.info("No serial port found");
-        }
-    }
-
-    /**
-     * Processes the audio frame decode queue
-     */
-    public class AudioDecodeProcessor implements Runnable
-    {
-        @Override
-        public void run()
-        {
-            try
-            {
-                DecodeSpeechRequest request = mDecodeSpeechRequests.poll();
-
-                if(request != null)
-                {
-                    try
-                    {
-                        send(request);
-                    }
-                    catch(IOException ioe)
-                    {
-                        mLog.error("Error decoding audio frame", ioe);
-                    }
-
-//                    try
-//                    {
-//                        //Force a 20ms sleep after submitting an audio frame to avoid overflowing the thumbdv
-//                        Thread.sleep(20);
-//                    }
-//                    catch(InterruptedException ie)
-//                    {
-//                        //Do nothing
-//                    }
-                }
-            }
-            catch(Throwable t)
-            {
-                mLog.error("Error", t);
-            }
-        }
-    }
-
-    public class SerialPortReader implements Runnable
-    {
-        private InputStream mInputStream;
-
-        public SerialPortReader(InputStream inputStream)
-        {
-            mInputStream = inputStream;
-        }
-
-        @Override
-        public void run()
-        {
-            try
-            {
-                if(mInputStream != null)
-                {
-                    try
-                    {
-                        while(mInputStream.available() > 0)
-                        {
-                            byte[] buffer = new byte[400];
-
-                            int bytesRead = mInputStream.readNBytes(buffer, 0, 1);
-
-                            if(bytesRead == 1 && buffer[0] == PACKET_START)
-                            {
-                                while(mInputStream.available() < 2)
-                                {
-                                    try
-                                    {
-                                        Thread.sleep(1);
-                                    }
-                                    catch(InterruptedException ie)
-                                    {
-                                    }
-                                }
-
-                                bytesRead = mInputStream.readNBytes(buffer, 1, 2);
-
-                                if(bytesRead == 2)
-                                {
-                                    int length = (0xFF & buffer[1]) << 8;
-                                    length += (0xFF & buffer[2]);
-
-                                    if(0 < length && length < 400)
-                                    {
-                                        length++; //Add a byte for the type byte
-
-                                        while(mInputStream.available() < length)
-                                        {
-                                            try
-                                            {
-                                                Thread.sleep(1);
-                                            }
-                                            catch(InterruptedException ie)
-                                            {
-                                            }
-                                        }
-
-                                        bytesRead = mInputStream.readNBytes(buffer, 3, length);
-
-                                        if(bytesRead == length)
-                                        {
-                                            receive(Arrays.copyOf(buffer, length + 3));
-                                        }
-                                        else
-                                        {
-                                            mLog.debug("Expected [" + length + "] but received [" + bytesRead + "] bytes - " + Arrays.toString(buffer));
-                                        }
-                                    }
-                                    else
-                                    {
-                                        mLog.error("Received packet with unexpected length: " + length);
-                                        //Don't process the buffer ... let the reader read and inspect 1 byte at a time
-                                        //to regain sync on the packet start byte
-                                    }
-                                }
-                                else
-                                {
-                                    mLog.debug("Expected [2] but received [" + bytesRead + "] -- this shouldn't happen");
-                                }
-                            }
-                            else
-                            {
-                                mLog.debug("Unrecognized byte: " + Arrays.toString(buffer));
-                            }
-                        }
-                    }
-                    catch(IOException ioe)
-                    {
-                        mLog.error("Error while reading ThumbDv serial port", ioe);
-                    }
-                }
-            }
-            catch(Throwable t)
-            {
-                mLog.error("Error", t);
-            }
-        }
-    }
-
-    public static void main(String[] args)
-    {
-        mLog.debug("Starting");
-
-        String silence = "BEDDEA821EFD660C08";
-
-        String[] frames = {"0E46122323067C60F8", "0E469433C1067CF1BC", "0E46122B23067C60F8", "0E67162BE08874E2B4",
-                "0E46163BE1067CF1BC", "0E46122B23067C60F8", "0A06163BE00A5C303E", "0E46122B23067C60F8", "0E46163BE1847CE1FC",
-                "0E46122B23067C60F8"};
-
-        List<byte[]> frameData = new ArrayList<>();
-
-        for(String frame : frames)
-        {
-            byte[] bytes = new byte[frame.length() / 2];
-            for(int x = 0; x < frame.length(); x += 2)
-            {
-                String hex = frame.substring(x, x + 2);
-                bytes[x / 2] = (byte) (0xFF & Integer.parseInt(hex, 16));
-            }
-
-            frameData.add(bytes);
-        }
-
-        mLog.debug("Starting thumb dv thread(s)");
-
-        final Listener<float[]> listener = packet -> {
-            mLog.info("Got an audio packet!");
-        };
-
-        try(ThumbDv thumbDv = new ThumbDv(AudioProtocol.P25_PHASE2, listener))
-        {
-            thumbDv.start();
-
-            Thread.sleep(6000);
-
-            for(int x = 0; x < 20; x++)
-            {
-                thumbDv.send(new EncodeSpeechRequest(new short[160]));
-                Thread.sleep(20);
-            }
-//            for(byte[] frame : frameData)
-//            {
-//                thumbDv.decode(frame);
-//            }
-
-            while(true);
-        }
-        catch(IOException ioe)
-        {
-            mLog.error("Error", ioe);
-        }
-        catch(InterruptedException e)
-        {
-            e.printStackTrace();
-        }
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/AmbeMessage.java

@@ -1,44 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message;
-
-/**
- * AMBE-3000R Message
- */
-public abstract class AmbeMessage
-{
-    /**
-     * Converts the byte array to a hexadecimal string array
-     */
-    public static String toHex(byte[] data)
-    {
-        StringBuilder sb = new StringBuilder();
-
-        for(byte b: data)
-        {
-            sb.append(String.format("%02X", b));
-        }
-
-        return sb.toString();
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/AmbeMessageFactory.java

@@ -1,95 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.response.DecodeSpeechResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.EncodeSpeechResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.GetConfigResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.InitializeCodecResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.ProductIdResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.ReadyResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetChannelFormatResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetChannelResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetPacketModeResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetSpeechFormatResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetVocoderParameterResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.SetVocoderResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.UnknownResponse;
-import io.github.dsheirer.audio.convert.thumbdv.message.response.VersionResponse;
-
-public class AmbeMessageFactory
-{
-    private static final byte CONTROL_PACKET = (byte)0x00;
-    private static final byte CHANNEL_PACKET = (byte)0x01;
-    private static final byte SPEECH_PACKET = (byte)0x02;
-    private static final int INDEX_PACKET_TYPE = 3;
-    private static final int INDEX_CONTROL_PACKET_TYPE = 4;
-
-
-    public static AmbeMessage getMessage(byte[] data)
-    {
-        if(data != null && data.length >= 5)
-        {
-            if(data[INDEX_PACKET_TYPE] == CONTROL_PACKET)
-            {
-                PacketField packetField = PacketField.fromValue(data[INDEX_CONTROL_PACKET_TYPE]);
-
-                switch(packetField)
-                {
-                    case PKT_CHANNEL_0:
-                        return new SetChannelResponse(data);
-                    case PKT_CHANNEL_FORMAT:
-                        return new SetChannelFormatResponse(data);
-                    case PKT_CODEC_STOP:
-                        return new SetPacketModeResponse(data);
-                    case PKT_GET_CONFIG:
-                        return new GetConfigResponse(data);
-                    case PKT_INIT:
-                        return new InitializeCodecResponse(data);
-                    case PKT_PRODUCT_ID:
-                        return new ProductIdResponse(data);
-                    case PKT_RATE_PARAMETER:
-                        return new SetVocoderParameterResponse(data);
-                    case PKT_RATE_TABLE:
-                        return new SetVocoderResponse(data);
-                    case PKT_READY:
-                        return new ReadyResponse(data);
-                    case PKT_SPEECH_FORMAT:
-                        return new SetSpeechFormatResponse(data);
-                    case PKT_VERSION_STRING:
-                        return new VersionResponse(data);
-                }
-            }
-            else if(data[INDEX_PACKET_TYPE] == CHANNEL_PACKET)
-            {
-                return new EncodeSpeechResponse(data);
-            }
-            else if(data[INDEX_PACKET_TYPE] == SPEECH_PACKET)
-            {
-                return new DecodeSpeechResponse(data);
-            }
-        }
-
-        return new UnknownResponse(data);
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/InitializeOption.java

@@ -1,47 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message;
-
-/**
- * AMBE-3000 Initialization Options
- */
-public enum InitializeOption
-{
-    ENCODER((byte)0x01),
-    DECODER((byte)0x02),
-    ENCODER_AND_DECODER((byte)0x03),
-    ECHO_CANCELLER((byte)0x04),
-    ENCODER_DECODER_ECHO_CANCELLER((byte)0x07);
-
-    private byte mCode;
-
-    InitializeOption(byte code)
-    {
-        mCode = code;
-    }
-
-    public byte getCode()
-    {
-        return mCode;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/PacketField.java

@@ -1,160 +0,0 @@
-/*
- * *****************************************************************************
- * Copyright (C) 2014-2022 Dennis Sheirer
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- * ****************************************************************************
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message;
-
-/**
- * AMBE-3000R Control Packet Field enumeration
- */
-public enum PacketField
-{
-    PKT_ENCODER_CMODE((byte)0x05),
-    PKT_DECODER_CMODE((byte)0x06),
-    PKT_RATE_TABLE((byte)0x09),
-    PKT_RATE_PARAMETER((byte)0x0A),
-    PKT_INIT((byte)0x0B),
-    PKT_LOW_POWER((byte)0x10),
-    PKT_CHANNEL_FORMAT((byte)0x15),
-    PKT_SPEECH_FORMAT((byte)0x16),
-    PKT_CODEC_START((byte)0x2A),
-    PKT_CODEC_STOP((byte)0x2B),
-    PKT_PRODUCT_ID((byte)0x30),
-    PKT_VERSION_STRING((byte)0x31),
-    PKT_COMPAND((byte)0x32),
-    PKT_RESET((byte)0x33),
-    PKT_RESET_TO_SOFTWARE_CONFIG((byte)0x34),
-    PKT_HALT((byte)0x35),
-    PKT_GET_CONFIG((byte)0x36),
-    PKT_READ_CONFIG((byte)0x37),
-    PKT_CODEC_CFG((byte)0x38),
-    PKT_READY((byte)0x39),
-    PKT_PARITY_MODE((byte)0x3F),
-    PKT_CHANNEL_0((byte)0x40),
-    PKT_WRITE_I2C((byte)0x44),
-    PKT_CLEAR_CODEC_RESET((byte)0x46),
-    PKT_SET_CODEC_RESET((byte)0x47),
-    PKT_DISCARD_CODEC_SAMPLES((byte)0x48),
-    PKT_DELAY_NUMBER_MICRO_SECONDS((byte)0x49),
-    PKT_DELAY_NUMBER_NANO_SECONDS((byte)0x4A),
-    PKT_GAIN((byte)0x4B),
-    PKT_RTS_THRESHOLD((byte)0x4E),
-
-    //Speech packet values
-    SPEECH_DATA((byte)0x00),
-    CHANNEL_DATA_HARD_SYMBOL((byte)0x01),
-    CMODE((byte)0x02),
-    SAMPLE_COUNT((byte)0x03),
-    TONE((byte)0x08),
-    CHANNEL_DATA_SOFT_SYMBOL((byte)0x17),
-    VOCODER((byte)0x40),
-
-    //Packet Types
-    PACKET_TYPE_CONTROL((byte)0x00),
-    PACKET_TYPE_ENCODE_SPEECH((byte)0x01),
-    PACKET_TYPE_DECODE_SPEECH((byte)0x02),
-
-    UNKNOWN((byte)0x00);
-
-    private byte mCode;
-
-    PacketField(byte code)
-    {
-        mCode = code;
-    }
-
-    /**
-     * Packet type byte code value
-     */
-    public byte getCode()
-    {
-        return mCode;
-    }
-
-    /**
-     * Lookup a packet type from the code byte value
-     */
-    public static PacketField fromValue(byte value)
-    {
-        switch(value)
-        {
-            case (byte)0x05:
-                return PKT_ENCODER_CMODE;
-            case (byte)0x06:
-                return PKT_DECODER_CMODE;
-            case (byte)0x09:
-                return PKT_RATE_TABLE;
-            case (byte)0x0A:
-                return PKT_RATE_PARAMETER;
-            case (byte)0x0B:
-                return PKT_INIT;
-            case (byte)0x10:
-                return PKT_LOW_POWER;
-            case (byte)0x15:
-                return PKT_CHANNEL_FORMAT;
-            case (byte)0x16:
-                return PKT_SPEECH_FORMAT;
-            case (byte)0x2A:
-                return PKT_CODEC_START;
-            case (byte)0x2B:
-                return PKT_CODEC_STOP;
-            case (byte)0x30:
-                return PKT_PRODUCT_ID;
-            case (byte)0x31:
-                return PKT_VERSION_STRING;
-            case (byte)0x32:
-                return PKT_COMPAND;
-            case (byte)0x33:
-                return PKT_RESET;
-            case (byte)0x34:
-                return PKT_RESET_TO_SOFTWARE_CONFIG;
-            case (byte)0x35:
-                return PKT_HALT;
-            case (byte)0x36:
-                return PKT_GET_CONFIG;
-            case (byte)0x37:
-                return PKT_READ_CONFIG;
-            case (byte)0x38:
-                return PKT_CODEC_CFG;
-            case (byte)0x39:
-                return PKT_READY;
-            case (byte)0x3F:
-                return PKT_PARITY_MODE;
-            case (byte)0x40:
-                return PKT_CHANNEL_0;
-            case (byte)0x44:
-                return PKT_WRITE_I2C;
-            case (byte)0x46:
-                return PKT_CLEAR_CODEC_RESET;
-            case (byte)0x47:
-                return PKT_SET_CODEC_RESET;
-            case (byte)0x48:
-                return PKT_DISCARD_CODEC_SAMPLES;
-            case (byte)0x49:
-                return PKT_DELAY_NUMBER_MICRO_SECONDS;
-            case (byte)0x4A:
-                return PKT_DELAY_NUMBER_NANO_SECONDS;
-            case (byte)0x4B:
-                return PKT_GAIN;
-            case (byte)0x4E:
-                return PKT_RTS_THRESHOLD;
-            default:
-                return UNKNOWN;
-        }
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/VocoderRate.java

@@ -1,129 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message;
-
-public enum VocoderRate
-{
-    //AMBE-1000 Standard Rates
-    RATE_0((byte)0x00, 2400,0),
-    RATE_1((byte)0x01, 3600,0),
-    RATE_2((byte)0x02, 3600,1200),
-    RATE_3((byte)0x03, 4800,0),
-    RATE_4((byte)0x04, 9600,0),
-    RATE_5((byte)0x05, 2350,50),
-    RATE_6((byte)0x06, 4850,4750),
-    RATE_7((byte)0x07, 4550,250),
-    RATE_8((byte)0x08, 3100,1700),
-    RATE_9((byte)0x09, 4400,2800),
-    RATE_10((byte)0x0A, 4150,2250),
-    RATE_11((byte)0x0B, 3350,250),
-    RATE_12((byte)0x0C, 7750,250),
-    RATE_13((byte)0x0D, 4650,3350),
-    RATE_14((byte)0x0E, 3750,250),
-    RATE_15((byte)0x0F, 4000,0),
-
-    //AMBE-2000 Standard Rates
-    RATE_16((byte)0x10, 3600,0),
-    RATE_17((byte)0x11, 4000,0),
-    RATE_18((byte)0x12, 4800,0),
-    RATE_19((byte)0x13, 6400,0),
-    RATE_20((byte)0x14, 8000,0),
-    RATE_21((byte)0x15, 9600,0),
-    RATE_22((byte)0x16, 2400,1600),
-    RATE_23((byte)0x17, 3600,1200),
-    RATE_24((byte)0x18, 4000,800),
-    RATE_25((byte)0x19, 2400,2400),
-    RATE_26((byte)0x1A, 4000,2400),
-    RATE_27((byte)0x1B, 4400,2800), //Is this compatible with APCO25 Phase 1?
-    RATE_28((byte)0x1C, 4000,4000),
-    RATE_29((byte)0x1D, 2400,7200),
-    RATE_30((byte)0x1E, 3600,6000),
-    RATE_31((byte)0x1F, 2000,0),
-    RATE_32((byte)0x20, 3600,2800),
-
-    //AMBE-3000 Standard Rates (AMBE+2)
-    RATE_33((byte)0x21, 2450,1150), //APCO25 HR (Phase 2), DMR, NXDN, DSTAR
-    RATE_34((byte)0x22, 2450,0),
-    RATE_35((byte)0x23, 2250,1150),
-    RATE_36((byte)0x24, 2250,0),
-    RATE_37((byte)0x25, 2400,0),
-    RATE_38((byte)0x26, 3000,0),
-    RATE_39((byte)0x27, 3600,0),
-    RATE_40((byte)0x28, 4000,0),
-    RATE_41((byte)0x29, 4400,0),
-    RATE_42((byte)0x2A, 4800,0),
-    RATE_43((byte)0x2B, 6400,0),
-    RATE_44((byte)0x2C, 7200,0),
-    RATE_45((byte)0x2D, 8000,0),
-    RATE_46((byte)0x2E, 9600,0),
-    RATE_47((byte)0x2F, 2450,250),
-    RATE_48((byte)0x30, 3350,250),
-    RATE_49((byte)0x31, 3750,250),
-    RATE_50((byte)0x32, 4550,250),
-    RATE_51((byte)0x33, 2450,1950),
-    RATE_52((byte)0x34, 2450,2350),
-    RATE_53((byte)0x35, 2450,3550),
-    RATE_54((byte)0x36, 2450,4750),
-    RATE_55((byte)0x37, 2600,1400),
-    RATE_56((byte)0x38, 3600,1200),
-    RATE_57((byte)0x39, 4000,800),
-    RATE_58((byte)0x3A, 4000,2400),
-    RATE_59((byte)0x3B, 4400,2800), //Is this compatible with APCO25 Phase 1?
-    RATE_60((byte)0x3C, 4000,4000),
-    RATE_61((byte)0x3D, 3600,6000);
-
-    private byte mCode;
-    private int mSpeechRate;
-    private int mFecRate;
-    
-    VocoderRate(byte code, int speechRate, int fecRate)
-    {
-        mCode = code;
-        mSpeechRate = speechRate;
-        mFecRate = fecRate;
-    }
-
-    /**
-     * Byte code value for the vocoder rate
-     */
-    public byte getCode()
-    {
-        return mCode;
-    }
-
-    /**
-     * Speech rate in bits per second (bps)
-     */
-    public int getSpeechRate()
-    {
-        return mSpeechRate;
-    }
-
-    /**
-     * Forward Error Correction rate in bits per second (bps)
-     */
-    public int getFecRate()
-    {
-        return mFecRate;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/AmbeRequest.java

@@ -1,67 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.AmbeMessage;
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * AMBE-3000R Request Packet
- */
-public abstract class AmbeRequest extends AmbeMessage
-{
-    private static final byte PACKET_START_BYTE = (byte)0x61;
-    protected static final int PACKET_TYPE_INDEX = 3;
-    protected static final int PAYLOAD_START_INDEX = 4;
-
-    public abstract PacketField getType();
-    public abstract byte[] getData();
-
-    /**
-     * Creates a byte array of the specified length plus 4 packet header bytes with packet start, length and control
-     * bytes filled in.
-     *
-     * @param length of the message (not including the 4 byte packet header)
-     * @return byte array with packet header pre-filled.
-     */
-    protected byte[] createMessage(int length, PacketField type)
-    {
-        byte[] data = new byte[length + 4];
-
-        data[0] = PACKET_START_BYTE;
-        data[1] = (byte)((length >> 8 & 0xFF));
-        data[2] = (byte)(length & 0xFF);
-
-        if(type == PacketField.PACKET_TYPE_ENCODE_SPEECH || type == PacketField.PACKET_TYPE_DECODE_SPEECH)
-        {
-            data[PACKET_TYPE_INDEX] = type.getCode();
-        }
-        else
-        {
-            data[PACKET_TYPE_INDEX] = PacketField.PACKET_TYPE_CONTROL.getCode();
-            data[PAYLOAD_START_INDEX] = type.getCode();
-        }
-
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/DecodeSpeechRequest.java

@@ -1,108 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-import io.github.dsheirer.audio.convert.thumbdv.message.VocoderRate;
-
-/**
- * Decode speech request, used to request decode of an encoded audio frame.
- */
-public class DecodeSpeechRequest extends AmbeRequest
-{
-    private static final int CHANNEL_DATA_IDENTIFIER_INDEX = 4;
-    private static final byte SAMPLE_COUNT = (byte)(0xFF & 160);  //8 kHz Audio sample count for 20ms frame
-
-    private byte[] mAudioFrame;
-    private VocoderRate mVocoderRate;
-
-    /**
-     * Constructs an audio frame decode request using the specified vocoder rate.
-     * @param audioFrame of encoded audio samples
-     * @param vocoderRate to use when decoding
-     */
-    public DecodeSpeechRequest(byte[] audioFrame, VocoderRate vocoderRate)
-    {
-        mAudioFrame = audioFrame;
-        mVocoderRate = vocoderRate;
-    }
-
-    /**
-     * Constructs an audio frame decode request using the current vocoder rate.
-     * @param audioFrame of encoded audio samples
-     */
-    public DecodeSpeechRequest(byte[] audioFrame)
-    {
-        this(audioFrame, null);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PACKET_TYPE_ENCODE_SPEECH;
-    }
-
-    private boolean hasVocoderRate()
-    {
-        return mVocoderRate != null;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        if(hasVocoderRate())
-        {
-            int length = mAudioFrame.length + 9;
-
-            byte[] data = createMessage(length, getType());
-            int offset = CHANNEL_DATA_IDENTIFIER_INDEX;
-
-            data[offset++] = PacketField.VOCODER.getCode();
-            data[offset++] = mVocoderRate.getCode();
-
-            data[offset++] = PacketField.CHANNEL_DATA_HARD_SYMBOL.getCode();
-            data[offset++] = (byte)(0xFF & (mAudioFrame.length * 8));
-            System.arraycopy(mAudioFrame, 0, data, offset, mAudioFrame.length);
-            offset += mAudioFrame.length;
-            data[offset++] = PacketField.SAMPLE_COUNT.getCode();
-            data[offset++] = (byte)0xA0;
-            data[offset++] = (byte)0x02;
-            data[offset++] = (byte)0x00;
-            data[offset] = (byte)0x00;
-
-            return data;
-        }
-        else
-        {
-            int length = mAudioFrame.length + 2;
-            byte[] data = createMessage(length, getType());
-
-            int offset = CHANNEL_DATA_IDENTIFIER_INDEX;
-            data[offset++] = PacketField.CHANNEL_DATA_HARD_SYMBOL.getCode();
-            data[offset++] = (byte)(0xFF & (mAudioFrame.length * 8));
-            System.arraycopy(mAudioFrame, 0, data, offset, mAudioFrame.length);
-
-            return data;
-        }
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/EncodeSpeechRequest.java

@@ -1,88 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-public class EncodeSpeechRequest extends AmbeRequest
-{
-    private static final int CHANNEL_IDENTIFIER_INDEX = 4;
-    private static final int SPEECH_DATA_IDENTIFIER_INDEX = 5;
-    private static final int SAMPLE_COUNT_INDEX = 6;
-    private static final int SPEECH_DATA_START_INDEX = 7;
-
-    private short[] mSamples;
-
-    public EncodeSpeechRequest(short[] samples)
-    {
-        mSamples = samples;
-    }
-
-    public EncodeSpeechRequest(float[] samples)
-    {
-        mSamples = new short[samples.length];
-
-        for(int x = 0; x < samples.length; x++)
-        {
-            if(samples[x] > 1.0f)
-            {
-                mSamples[x] = Short.MAX_VALUE;
-            }
-            else if(samples[x] < -1.0f)
-            {
-                mSamples[x] = Short.MIN_VALUE;
-            }
-            else
-            {
-                mSamples[x] = (short)(samples[x] * Short.MAX_VALUE);
-            }
-        }
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PACKET_TYPE_DECODE_SPEECH;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        int length = (mSamples.length * 2) + 3;
-        byte[] data = createMessage(length, getType());
-
-        data[CHANNEL_IDENTIFIER_INDEX] = PacketField.PKT_CHANNEL_0.getCode();
-        data[SPEECH_DATA_IDENTIFIER_INDEX] = (byte)0x00;
-        data[SAMPLE_COUNT_INDEX] = (byte)(0xFF & mSamples.length);
-
-        int pointer = SPEECH_DATA_START_INDEX;
-
-        for(short sample: mSamples)
-        {
-            data[pointer++] = (byte)((sample >> 8 & 0xFF));
-            data[pointer++] = (byte)(sample & 0xFF);
-        }
-
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/GetConfigRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Get configuration request packet
- */
-public class GetConfigRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_GET_CONFIG;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/InitializeCodecRequest.java

@@ -1,54 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.InitializeOption;
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Initialize CODEC request packet
- */
-public class InitializeCodecRequest extends AmbeRequest
-{
-    private static final int INITIALIZE_OPTION_INDEX = 5;
-    private InitializeOption mInitializeOption;
-
-    public InitializeCodecRequest(InitializeOption option)
-    {
-        mInitializeOption = option;
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_INIT;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        byte[] data = createMessage(2, getType());
-        data[INITIALIZE_OPTION_INDEX] = mInitializeOption.getCode();
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/ProductIdRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Product ID request packet
- */
-public class ProductIdRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_PRODUCT_ID;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/ResetRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Reset request packet
- */
-public class ResetRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RESET;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetChannelFormatRequest.java

@@ -1,48 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set channel format request packet
- */
-public class SetChannelFormatRequest extends AmbeRequest
-{
-    private static final int FORMAT_INDEX = 5;
-    private static final byte FORMAT = (byte)0x00;
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CHANNEL_FORMAT;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        byte[] data = createMessage(2, getType());
-        data[FORMAT_INDEX] = FORMAT;
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetChannelRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set channel request packet
- */
-public class SetChannelRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CHANNEL_0;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetPacketModeRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Packet mode (versus CODEC mode) request packet
- */
-public class SetPacketModeRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CODEC_STOP;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetSpeechFormatRequest.java

@@ -1,48 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set speech format request packet
- */
-public class SetSpeechFormatRequest extends AmbeRequest
-{
-    private static final int FORMAT_INDEX = 5;
-    private static final byte FORMAT = (byte)0x00;
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_SPEECH_FORMAT;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        byte[] data = createMessage(2, getType());
-        data[FORMAT_INDEX] = FORMAT;
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetVocoderParametersRequest.java

@@ -1,74 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set Vocoder parameters request packet
- */
-public class SetVocoderParametersRequest extends AmbeRequest
-{
-    private int mWord0;
-    private int mWord1;
-    private int mWord2;
-    private int mWord3;
-    private int mWord4;
-    private int mWord5;
-
-    public SetVocoderParametersRequest(int word0, int word1, int word2, int word3, int word4, int word5)
-    {
-        mWord0 = word0;
-        mWord1 = word1;
-        mWord2 = word2;
-        mWord3 = word3;
-        mWord4 = word4;
-        mWord5 = word5;
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RATE_PARAMETER;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        byte[] data = createMessage(14, getType());
-        data[PAYLOAD_START_INDEX + 1] = (byte)(mWord0 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 2] = (byte)(mWord0 & 0xFF);
-        data[PAYLOAD_START_INDEX + 3] = (byte)(mWord1 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 4] = (byte)(mWord1 & 0xFF);
-        data[PAYLOAD_START_INDEX + 5] = (byte)(mWord2 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 6] = (byte)(mWord2 & 0xFF);
-        data[PAYLOAD_START_INDEX + 7] = (byte)(mWord3 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 8] = (byte)(mWord3 & 0xFF);
-        data[PAYLOAD_START_INDEX + 9] = (byte)(mWord4 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 10] = (byte)(mWord4 & 0xFF);
-        data[PAYLOAD_START_INDEX + 11] = (byte)(mWord5 >> 8 & 0xFF);
-        data[PAYLOAD_START_INDEX + 12] = (byte)(mWord5 & 0xFF);
-
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/SetVocoderRequest.java

@@ -1,53 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-import io.github.dsheirer.audio.convert.thumbdv.message.VocoderRate;
-
-/**
- * Set Vocoder Rate request packet
- */
-public class SetVocoderRequest extends AmbeRequest
-{
-    private VocoderRate mVocoderRate;
-
-    public SetVocoderRequest(VocoderRate rate)
-    {
-        mVocoderRate = rate;
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RATE_TABLE;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        byte[] data = createMessage(2, getType());
-        data[PAYLOAD_START_INDEX + 1] = mVocoderRate.getCode();
-        return data;
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/request/VersionRequest.java

@@ -1,43 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.request;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Version string request packet
- */
-public class VersionRequest extends AmbeRequest
-{
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_VERSION_STRING;
-    }
-
-    @Override
-    public byte[] getData()
-    {
-        return createMessage(1, getType());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/AmbeResponse.java

@@ -1,60 +0,0 @@
-/*
- * *****************************************************************************
- * Copyright (C) 2014-2022 Dennis Sheirer
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- * ****************************************************************************
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.AmbeMessage;
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-import java.util.Arrays;
-
-/**
- * AMBE-3000R Response Packet
- */
-public abstract class AmbeResponse extends AmbeMessage
-{
-    protected static final int PAYLOAD_START_INDEX = 5;
-    private byte[] mMessage;
-
-    protected AmbeResponse(byte[] message)
-    {
-        mMessage = message;
-    }
-
-    /**
-     * Control packet type
-     */
-    public abstract PacketField getType();
-
-    /**
-     * Received message bytes
-     */
-    protected byte[] getMessage()
-    {
-        return mMessage;
-    }
-
-    /**
-     * Payload of the packet (does not include the packet header)
-     */
-    protected byte[] getPayload()
-    {
-        return Arrays.copyOfRange(getMessage(), PAYLOAD_START_INDEX, getMessage().length);
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/DecodeSpeechResponse.java

@@ -1,59 +0,0 @@
-/*******************************************************************************
- * sdr-trunk
- * Copyright (C) 2014-2019 Dennis Sheirer
- *
- * This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public
- * License as published by  the Free Software Foundation, either version 3 of the License, or  (at your option) any
- * later version.
- *
- * This program is distributed in the hope that it will be useful,  but WITHOUT ANY WARRANTY; without even the implied
- * warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License  along with this program.
- * If not, see <http://www.gnu.org/licenses/>
- *
- ******************************************************************************/
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-import io.github.dsheirer.sample.ConversionUtils;
-
-import java.util.Arrays;
-
-/**
- * Decode speech response
- */
-public class DecodeSpeechResponse extends AmbeResponse
-{
-    public DecodeSpeechResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PACKET_TYPE_DECODE_SPEECH;
-    }
-
-
-    /**
-     * Payload of the packet (does not include the packet header)
-     */
-    protected byte[] getPayload()
-    {
-        return Arrays.copyOfRange(getMessage(), PAYLOAD_START_INDEX + 1, getMessage().length);
-    }
-
-    public float[] getSamples()
-    {
-        return ConversionUtils.convertFromSigned16BitSamples(getPayload());
-    }
-
-    @Override
-    public String toString()
-    {
-        return "DECODED SPEECH: SAMPLE COUNT:" + getSamples().length + " " + toHex(getPayload());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/EncodeSpeechResponse.java

@@ -1,59 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-import java.util.Arrays;
-
-/**
- * Encode speech response
- */
-public class EncodeSpeechResponse extends AmbeResponse
-{
-    public EncodeSpeechResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PACKET_TYPE_ENCODE_SPEECH;
-    }
-
-
-    /**
-     * Payload of the packet (does not include the packet header)
-     */
-    protected byte[] getPayload()
-    {
-        return Arrays.copyOfRange(getMessage(), PAYLOAD_START_INDEX + 1, getMessage().length);
-    }
-
-    @Override
-    public String toString()
-    {
-        return "ENCODED SPEECH: " + toHex(getPayload()) + " " + Arrays.toString(getMessage());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/GetConfigResponse.java

@@ -1,49 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Get configuration response
- */
-public class GetConfigResponse extends AmbeResponse
-{
-    public GetConfigResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_GET_CONFIG;
-    }
-
-
-    @Override
-    public String toString()
-    {
-        return "CONFIGURATION: " + toHex(getPayload());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/InitializeCodecResponse.java

@@ -1,58 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Initialize CODEC response
- */
-public class InitializeCodecResponse extends AmbeResponse
-{
-    public InitializeCodecResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_INIT;
-    }
-
-    /**
-     * Success / fail
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "INITIALIZE CODEC " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/ProductIdResponse.java

@@ -1,56 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Product ID Response
- */
-public class ProductIdResponse extends AmbeResponse
-{
-    public ProductIdResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_PRODUCT_ID;
-    }
-
-    /**
-     * Product ID string
-     */
-    public String getProductId()
-    {
-        return new String(getPayload()).trim();
-    }
-
-    @Override
-    public String toString()
-    {
-        return "PRODUCT ID:" + getProductId();
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/ReadyResponse.java

@@ -1,50 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-import java.util.Arrays;
-
-/**
- * Ready response
- */
-public class ReadyResponse extends AmbeResponse
-{
-    public ReadyResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_READY;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "READY" + Arrays.toString(getMessage());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/ResetResponse.java

@@ -1,57 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Reset response
- */
-public class ResetResponse extends AmbeResponse
-{
-    public ResetResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RESET;
-    }
-
-    /**
-     * Success indicator
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "RESET " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetChannelFormatResponse.java

@@ -1,58 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set channel format response
- */
-public class SetChannelFormatResponse extends AmbeResponse
-{
-    public SetChannelFormatResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CHANNEL_FORMAT;
-    }
-
-    /**
-     * Success or fail
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "SET CHANNEL FORMAT " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetChannelResponse.java

@@ -1,57 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set Vocoder rate response
- */
-public class SetChannelResponse extends AmbeResponse
-{
-    public SetChannelResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CHANNEL_0;
-    }
-
-    /**
-     * Success indicator
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "SET CHANNEL 0 " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetPacketModeResponse.java

@@ -1,58 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set packet mode response
- */
-public class SetPacketModeResponse extends AmbeResponse
-{
-    public SetPacketModeResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_CODEC_STOP;
-    }
-
-    /**
-     * Success or fail
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "SET PACKET MODE " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetSpeechFormatResponse.java

@@ -1,58 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set speech format response
- */
-public class SetSpeechFormatResponse extends AmbeResponse
-{
-    public SetSpeechFormatResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_SPEECH_FORMAT;
-    }
-
-    /**
-     * Success or fail
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "SET SPEECH FORMAT " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetVocoderParameterResponse.java

@@ -1,65 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set Vocoder parameter response
- */
-public class SetVocoderParameterResponse extends AmbeResponse
-{
-    public SetVocoderParameterResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RATE_PARAMETER;
-    }
-
-    /**
-     * Success indicator
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==3 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        if(isSuccessful())
-        {
-            return "SET VOCODER RATE SUCCESSFUL";
-        }
-        else
-        {
-            return "SET VOCODER RATE **FAILED** - RESPONSE:" + toHex(getPayload());
-        }
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/SetVocoderResponse.java

@@ -1,58 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Set Vocoder rate response
- */
-public class SetVocoderResponse extends AmbeResponse
-{
-    public SetVocoderResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_RATE_TABLE;
-    }
-
-    /**
-     * Success indicator
-     */
-    public boolean isSuccessful()
-    {
-        byte[] payload = getPayload();
-
-        return payload != null && payload.length ==1 && payload[0] == 0;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "SET VOCODER RATE " + (isSuccessful() ? "SUCCESSFUL" : "**FAILED**");
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/UnknownResponse.java

@@ -1,50 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-import java.util.Arrays;
-
-/**
- * Unknown Response Message
- */
-public class UnknownResponse extends AmbeResponse
-{
-    public UnknownResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.UNKNOWN;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "UNKNOWN MESSAGE:" + Arrays.toString(getMessage());
-    }
-}

src/main/java/io/github/dsheirer/audio/convert/thumbdv/message/response/VersionResponse.java

@@ -1,56 +0,0 @@
-/*
- *
- *  * ******************************************************************************
- *  * Copyright (C) 2014-2019 Dennis Sheirer
- *  *
- *  * This program is free software: you can redistribute it and/or modify
- *  * it under the terms of the GNU General Public License as published by
- *  * the Free Software Foundation, either version 3 of the License, or
- *  * (at your option) any later version.
- *  *
- *  * This program is distributed in the hope that it will be useful,
- *  * but WITHOUT ANY WARRANTY; without even the implied warranty of
- *  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- *  * GNU General Public License for more details.
- *  *
- *  * You should have received a copy of the GNU General Public License
- *  * along with this program.  If not, see <http://www.gnu.org/licenses/>
- *  * *****************************************************************************
- *
- *
- */
-
-package io.github.dsheirer.audio.convert.thumbdv.message.response;
-
-import io.github.dsheirer.audio.convert.thumbdv.message.PacketField;
-
-/**
- * Version Response
- */
-public class VersionResponse extends AmbeResponse
-{
-    public VersionResponse(byte[] message)
-    {
-        super(message);
-    }
-
-    @Override
-    public PacketField getType()
-    {
-        return PacketField.PKT_VERSION_STRING;
-    }
-
-    /**
-     * Version string
-     */
-    public String getVersion()
-    {
-        return new String(getPayload()).trim();
-    }
-
-    @Override
-    public String toString()
-    {
-        return "VERSION:" + getVersion();
-    }
-}

src/main/java/io/github/dsheirer/dsp/c4fm/C4FMSymbolProcessor.java

@@ -257,6 +257,20 @@ public abstract class C4FMSymbolProcessor
         return true;
     }
 
+    /**
+     * Maximum bit errors allowed in a detected sync pattern while acquiring (ie not synchronized), measured from the
+     * symbol decisions at the optimized symbol timing.  Sync detections with more bit errors are rejected.  Bit errors
+     * include symbol magnitude (ie +3 vs +1) errors, so this rejects noise where the symbol signs correlate with the
+     * sync pattern but the symbol magnitudes are inconsistent.  Once synchronized, the limit isn't applied since the
+     * sync detection timing is known and rejecting a valid sync detection costs the burst.  Default implementation
+     * imposes no limit.
+     * @return maximum sync pattern bit error count while acquiring.
+     */
+    public int getSyncAcquisitionMaxBitErrors()
+    {
+        return Integer.MAX_VALUE;
+    }
+
     /**
      * Number of consecutive sync periods (capped at 3) where a sync was detected within the max message length.
      */
@@ -945,12 +959,14 @@ public abstract class C4FMSymbolProcessor
         }
 
         /**
-         * Indicates if this correction has a valid NID or the optimization (or detection) score is high quality.
+         * Indicates if the optimization score is high quality and, while acquiring, the sync pattern bit errors don't
+         * exceed the max.
          * @return true if valid.
          */
         public boolean isValid()
         {
-            return mOptimizationScore > getSyncThresholdEqualized();
+            return mOptimizationScore > getSyncThresholdEqualized() &&
+                    (mSynchronized || mCorrectedBitCount <= getSyncAcquisitionMaxBitErrors());
         }
     }
 
@@ -1297,7 +1313,7 @@ public abstract class C4FMSymbolProcessor
 
         for(int x = 0; x < patternSymbols.length; x++)
         {
-            if(bufferPointer < maxPointer)
+            if(bufferPointer >= 0 && bufferPointer < maxPointer)
             {
                 softSymbol = interpolate(mBuffer[bufferPointer], mBuffer[bufferPointer + 1], fractional) * gain + balance;
             }

src/main/java/io/github/dsheirer/edac/Golay24.java

@@ -68,6 +68,29 @@ public class Golay24
      */
     public static int checkAndCorrect(CorrectedBinaryMessage message, int startIndex)
     {
+        //The correction below indexes the word from bit 0 and takes the parity over the whole message, so it is only
+        //correct for a message that is exactly the 24-bit word.  Decode any other word in a 24-bit copy.
+        if(startIndex != 0 || message.size() != 24)
+        {
+            CorrectedBinaryMessage word = new CorrectedBinaryMessage(24);
+            int original = message.getInt(startIndex, startIndex + 23);
+            word.load(0, 24, original);
+            int result = checkAndCorrectWord(word);
+            int corrected = word.getInt(0, 23);
+            message.load(startIndex, 24, corrected);
+            message.incrementCorrectedBitCount(Integer.bitCount(original ^ corrected));
+            return result;
+        }
+
+        return checkAndCorrectWord(message);
+    }
+
+    /**
+     * Error detection and correction of a message that is exactly one 24-bit word.
+     */
+    private static int checkAndCorrectWord(CorrectedBinaryMessage message)
+    {
+        int startIndex = 0;
         boolean parityError = message.cardinality() % 2 != 0;
 
         int syndrome = getSyndrome(message, startIndex);

src/main/java/io/github/dsheirer/gui/SDRTrunk.java

@@ -1,6 +1,6 @@
 /*
  * *****************************************************************************
- * Copyright (C) 2014-2025 Dennis Sheirer
+ * Copyright (C) 2014-2026 Dennis Sheirer
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -60,6 +60,7 @@ import io.github.dsheirer.source.tuner.ui.TunerSpectralDisplayManager;
 import io.github.dsheirer.spectrum.DisableSpectrumWaterfallMenuItem;
 import io.github.dsheirer.spectrum.ShowTunerMenuItem;
 import io.github.dsheirer.spectrum.SpectralDisplayPanel;
+import io.github.dsheirer.util.DuplicateLibraryDetector;
 import io.github.dsheirer.util.ThreadPool;
 import io.github.dsheirer.util.TimeStamp;
 import io.github.dsheirer.vector.calibrate.CalibrationManager;
@@ -81,6 +82,7 @@ import java.nio.file.FileSystems;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import java.util.prefs.Preferences;
 import javafx.application.Platform;
@@ -153,6 +155,17 @@ public class SDRTrunk implements Listener<TunerEvent>
         mApplicationLog = new ApplicationLog(mUserPreferences);
         mApplicationLog.start();
 
+        Map<String,List<String>> duplicateLibraries = DuplicateLibraryDetector.findDuplicates();
+
+        if(!duplicateLibraries.isEmpty())
+        {
+            mLog.warn("More than one version of these libraries is in the library folder [" +
+                    DuplicateLibraryDetector.getFolder(duplicateLibraries) + "].  This happens when a new version of " +
+                    "sdrtrunk is unzipped over an older one, and it can load the older library code.  Delete the " +
+                    "sdrtrunk folder and unzip the release into an empty folder.\n" +
+                    DuplicateLibraryDetector.describe(duplicateLibraries));
+        }
+
         mResourceMonitor = new ResourceMonitor(mUserPreferences);
 
         ThreadPool.logSettings();
@@ -253,6 +266,11 @@ public class SDRTrunk implements Listener<TunerEvent>
                     {
                         updateTitle(tuner.getPreferredName());
                     }
+
+                    if(!duplicateLibraries.isEmpty())
+                    {
+                        showDuplicateLibrariesDialog(duplicateLibraries);
+                    }
                 }
 
                 if(calibrating && !GraphicsEnvironment.isHeadless())
@@ -909,6 +927,28 @@ public class SDRTrunk implements Listener<TunerEvent>
 
     }
 
+    /**
+     * Warns the user that the library folder holds more than one version of some libraries, which happens when a new
+     * release is unzipped over an older one.  The launch scripts put every jar in the library folder on the class
+     * path, so the older library code can load instead of the newer code.
+     * @param duplicates library name to jar paths, from DuplicateLibraryDetector
+     */
+    private void showDuplicateLibrariesDialog(Map<String,List<String>> duplicates)
+    {
+        String message = "<html><body style='width: 450px'>" +
+                "<p>The sdrtrunk library folder has more than one version of these libraries:</p><br>" +
+                "<pre>" + DuplicateLibraryDetector.describe(duplicates) + "</pre>" +
+                "<p>This happens when a new version of sdrtrunk is unzipped over an older one. sdrtrunk can load " +
+                "the older library code, which can cause crashes or errors that the newer version fixed.</p><br>" +
+                "<p>Close sdrtrunk, delete the sdrtrunk folder that contains this library folder and unzip the " +
+                "release into a new, empty folder:</p><br>" +
+                "<p><b>" + DuplicateLibraryDetector.getFolder(duplicates) + "</b></p><br>" +
+                "<p>Your playlist and settings are stored in your user folder and won't be affected.</p>" +
+                "</body></html>";
+
+        JOptionPane.showMessageDialog(mMainGui, message, "Duplicate Library Versions", JOptionPane.WARNING_MESSAGE);
+    }
+
     /**
      * Launch the application.
      */

src/main/java/io/github/dsheirer/log/ApplicationLog.java

@@ -1,6 +1,6 @@
 /*
  * *****************************************************************************
- * Copyright (C) 2014-2024 Dennis Sheirer
+ * Copyright (C) 2014-2026 Dennis Sheirer
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -133,6 +133,7 @@ public class ApplicationLog
             Attributes atts = findManifestAttributes();
             if (atts != null) {
                 mLog.info("SDRTrunk Version  : " + atts.getValue("Implementation-Version"));
+                mLog.info("Git Describe      : " + atts.getValue("Git-Describe"));
                 mLog.info("Gradle Version    : " + atts.getValue("Created-By"));
                 mLog.info("Build Timestamp   : " + atts.getValue("Build-Timestamp"));
                 mLog.info("Build-JDK         : " + atts.getValue("Build-JDK"));

src/main/java/io/github/dsheirer/module/decode/dmr/DMRDecoderState.java

@@ -298,7 +298,10 @@ public class DMRDecoderState extends TimeslotDecoderState
         {
             if(message instanceof VoiceMessage voice)
             {
-                processVoice(voice);
+                if(isValid(voice))
+                {
+                    processVoice(voice);
+                }
             }
             else if(message instanceof DataMessage data)
             {

src/main/java/io/github/dsheirer/module/decode/dmr/DMRSymbolProcessor.java

@@ -66,6 +66,12 @@ public class DMRSymbolProcessor extends C4FMSymbolProcessor
     private static final float SYNC_THRESHOLD_EQUALIZED = 70;
     //Once synchronized, sync detections are only allowed within this many symbols of a burst boundary.
     private static final int SYNC_WINDOW_SYMBOLS = 2;
+    //Maximum bit errors (of 48) in a detected sync pattern while acquiring.  Testing: all false sync detections in
+    //600 seconds of noise occurred while acquiring, with 7+ (mostly 12+) bit errors, and a max of 8 eliminated them
+    //(245 bursts to 0) at a cost of < 0.6% valid data bursts on clean recordings and 0.3 - 5.5% on multipath
+    //recordings with injected noise, where valid link control improved.  A max of 10 leaks noise false syncs and 6
+    //costs more multipath data bursts.  Applying the max once synchronized cost 3 - 20% of valid bursts.
+    private static final int SYNC_ACQUISITION_MAX_BIT_ERRORS = 8;
     private final DMRSyncModeMonitor mSyncModeMonitor = new DMRSyncModeMonitor();
     private final DMRMessageFramer mMessageFramer;
 
@@ -142,6 +148,12 @@ public class DMRSymbolProcessor extends C4FMSymbolProcessor
         return Math.min(offset, BURST_DIBIT_LENGTH - offset) <= SYNC_WINDOW_SYMBOLS;
     }
 
+    @Override
+    public int getSyncAcquisitionMaxBitErrors()
+    {
+        return SYNC_ACQUISITION_MAX_BIT_ERRORS;
+    }
+
     @Override
     public boolean isDynamicBalanceTrackingRequired()
     {

src/main/java/io/github/dsheirer/module/decode/dmr/audio/DMRAudioModule.java

@@ -105,6 +105,13 @@ public class DMRAudioModule extends AmbeAudioModule implements IdentifierUpdateP
     {
         if(hasAudioCodec() && message.getTimeslot() == getTimeslot())
         {
+            //Ignore voice messages where none of the AMBE voice frames pass error detection, so that invalid voice
+            //messages (ie false sync detections) don't produce audio or establish the encryption state.
+            if(message instanceof VoiceMessage voiceMessage && !voiceMessage.isValid())
+            {
+                return;
+            }
+
             //Attempt to set the audio encryption state from certain types of messages
             if(!mEncryptedCallStateEstablished)
             {

src/main/java/io/github/dsheirer/module/decode/dmr/message/voice/AMBEFrameValidator.java

@@ -0,0 +1,207 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+
+package io.github.dsheirer.module.decode.dmr.message.voice;
+
+import io.github.dsheirer.bits.BinaryMessage;
+
+/**
+ * Error detection for the three AMBE+2 (3600 x 2450) voice frames carried in a DMR voice burst.
+ *
+ * Each 72-bit voice frame carries an extended Golay(24,12) protected C0 vector and a Golay(23,12) protected C1 vector
+ * that is scrambled with a pseudo-random sequence seeded by the 12 data bits of C0.  The C2 and C3 vectors are not
+ * protected.  Golay(23,12) is a perfect code where every 23-bit word decodes to a codeword within 3 bit errors, so a
+ * frame is only considered valid when the combined C0 and C1 error count is low, which random (ie noise) bits rarely
+ * achieve.
+ *
+ * Vector bit indices and the C1 scrambling sequence are from the JMBE AMBEFrame decoder.  Burst bit indices of each
+ * voice frame match VoiceMessage.getAMBEFrames(): frames 1 and 3 are contiguous and frame 2 is split around the 48-bit
+ * sync/embedded signalling field in the middle of the burst.
+ */
+public class AMBEFrameValidator
+{
+    /**
+     * Maximum combined C0 and C1 bit errors for a valid voice frame.  Random 47-bit sequences have a combined error
+     * count of 2 or less with a probability of ~1.3e-4.
+     */
+    public static final int MAX_ERRORS = 2;
+
+    private static final int[] VECTOR_C0 = {0, 4, 8, 12, 16, 20, 24, 28, 32, 36, 40, 44, 48, 52, 56, 60, 64, 68, 1, 5,
+            9, 13, 17, 21};
+    private static final int[] VECTOR_C1 = {25, 29, 33, 37, 41, 45, 49, 53, 57, 61, 65, 69, 2, 6, 10, 14, 18, 22, 26,
+            30, 34, 38, 42};
+    private static final int[] FRAME_OFFSETS = {24, 96, 216};
+    private static final int GOLAY_23_GENERATOR = 0xC75;
+    private static final int[][] C0_INDICES = new int[3][VECTOR_C0.length];
+    private static final int[][] C1_INDICES = new int[3][VECTOR_C1.length];
+    //Minimum weight error pattern for each Golay(23,12) syndrome (perfect code: all syndromes have weight <= 3)
+    private static final int[] ERROR_PATTERNS = new int[2048];
+    //C1 descrambling sequence for each 12-bit C0 data (u0) seed value, MSB first
+    private static final int[] SCRAMBLE_SEQUENCES = new int[4096];
+
+    static
+    {
+        for(int frame = 0; frame < 3; frame++)
+        {
+            for(int x = 0; x < VECTOR_C0.length; x++)
+            {
+                C0_INDICES[frame][x] = getBurstIndex(frame, VECTOR_C0[x]);
+            }
+
+            for(int x = 0; x < VECTOR_C1.length; x++)
+            {
+                C1_INDICES[frame][x] = getBurstIndex(frame, VECTOR_C1[x]);
+            }
+        }
+
+        //Golay(23,12) is perfect: the 2048 error patterns of weight 0 - 3 map one-to-one onto the 2048 syndromes.
+        for(int i = 0; i < 23; i++)
+        {
+            ERROR_PATTERNS[getSyndrome(1 << i)] = 1 << i;
+
+            for(int j = i + 1; j < 23; j++)
+            {
+                ERROR_PATTERNS[getSyndrome((1 << i) | (1 << j))] = (1 << i) | (1 << j);
+
+                for(int k = j + 1; k < 23; k++)
+                {
+                    int pattern = (1 << i) | (1 << j) | (1 << k);
+                    ERROR_PATTERNS[getSyndrome(pattern)] = pattern;
+                }
+            }
+        }
+
+        for(int seed = 0; seed < 4096; seed++)
+        {
+            int pr = 16 * seed;
+            int sequence = 0;
+
+            for(int x = 0; x < 23; x++)
+            {
+                pr = (173 * pr + 13849) % 65536;
+                sequence = (sequence << 1) | (pr >= 32768 ? 1 : 0);
+            }
+
+            SCRAMBLE_SEQUENCES[seed] = sequence;
+        }
+    }
+
+    private AMBEFrameValidator()
+    {
+    }
+
+    /**
+     * Burst bit index for the voice frame bit index.
+     * @param frame index 0-2
+     * @param bit index 0-71 within the (interleaved) voice frame
+     * @return bit index within the 288-bit burst
+     */
+    private static int getBurstIndex(int frame, int bit)
+    {
+        //Frame 2 is split around the 48-bit sync/embedded signalling field (burst bits 132 - 179)
+        if(frame == 1 && bit >= 36)
+        {
+            return FRAME_OFFSETS[frame] + bit + 48;
+        }
+
+        return FRAME_OFFSETS[frame] + bit;
+    }
+
+    /**
+     * Golay(23,12) syndrome for the 23-bit word where the MSB (bit 22) is the first codeword bit.
+     */
+    private static int getSyndrome(int word)
+    {
+        for(int bit = 22; bit >= 11; bit--)
+        {
+            if((word & (1 << bit)) != 0)
+            {
+                word ^= GOLAY_23_GENERATOR << (bit - 11);
+            }
+        }
+
+        return word;
+    }
+
+    /**
+     * Extracts the indexed bits from the message as an integer value, with the first index as the MSB.
+     */
+    private static int getValue(BinaryMessage message, int[] indices)
+    {
+        int value = 0;
+
+        for(int index : indices)
+        {
+            value = (value << 1) | (message.get(index) ? 1 : 0);
+        }
+
+        return value;
+    }
+
+    /**
+     * Combined C0 and C1 bit error count for the voice frame, where C0 is decoded first so that the corrected C0 data
+     * bits can seed the C1 descrambling sequence.  C0 errors include the extended Golay parity bit, so an even weight
+     * C0 error pattern (ie 4 errors) that Golay(23,12) mis-corrects is counted as 4 errors.
+     * @param message containing the 288-bit voice burst
+     * @param frame index 0-2
+     * @return combined C0 and C1 bit error count.
+     */
+    public static int getErrorCount(BinaryMessage message, int frame)
+    {
+        int c0 = getValue(message, C0_INDICES[frame]);
+        int golay = c0 >>> 1;
+        int pattern = ERROR_PATTERNS[getSyndrome(golay)];
+        int corrected = golay ^ pattern;
+        int errors = Integer.bitCount(pattern);
+
+        //Extended Golay(24,12) parity bit provides even parity across the 24-bit codeword
+        if(((Integer.bitCount(corrected) + (c0 & 1)) & 1) != 0)
+        {
+            errors++;
+        }
+
+        //Short circuit when C0 alone exceeds the max error count.
+        if(errors > MAX_ERRORS)
+        {
+            return errors;
+        }
+
+        int c1 = getValue(message, C1_INDICES[frame]) ^ SCRAMBLE_SEQUENCES[corrected >>> 11];
+        return errors + Integer.bitCount(ERROR_PATTERNS[getSyndrome(c1)]);
+    }
+
+    /**
+     * Indicates if at least one of the three voice frames in the burst is valid, checking each frame in turn until a
+     * valid frame is found.
+     * @param message containing the 288-bit voice burst
+     * @return true if at least one voice frame has a combined C0 and C1 error count within the max error count.
+     */
+    public static boolean isValid(BinaryMessage message)
+    {
+        for(int frame = 0; frame < 3; frame++)
+        {
+            if(getErrorCount(message, frame) <= MAX_ERRORS)
+            {
+                return true;
+            }
+        }
+
+        return false;
+    }
+}

src/main/java/io/github/dsheirer/module/decode/dmr/message/voice/VoiceMessage.java

@@ -40,9 +40,10 @@ public abstract class VoiceMessage extends DMRBurst
     public static int[] FRAME_1_IV_FRAGMENT = new int[]{95, 91, 87, 83};
     public static int[] FRAME_2_IV_FRAGMENT = new int[]{215, 211, 207, 203};
     public static int[] FRAME_3_IV_FRAGMENT = new int[]{287, 283, 279, 275};
+    private Boolean mValid;
 
     /**
-     * DMR message frame.  This message is comprised of a 24-bit prefix and a 264-bit message frame.  Outbound base
+     * DMR message frame.  This message comprises a 24-bit prefix and a 264-bit message frame.  Outbound base
      * station frames transmit a Common Announcement Channel (CACH) in the 24-bit prefix, whereas Mobile inbound frames
      * do not use the 24-bit prefix.
      *
@@ -73,8 +74,8 @@ public abstract class VoiceMessage extends DMRBurst
         {
             frame_2[i] = getMessage().getByte(96 + i * 8);
         }
-        // 4 bits and 4 bits
-        frame_2[4] = (byte)((getMessage().getByte(128) & 0xF0) | (getMessage().getByte(180) >> 4));
+        // 4 bits and 4 bits.  Note: mask the shifted (signed) byte to prevent sign extension into the upper 4 bits.
+        frame_2[4] = (byte)((getMessage().getByte(128) & 0xF0) | ((getMessage().getByte(180) >> 4) & 0x0F));
         // copy last 4 byte
         for(int i = 0; i < 4; i++)
         {
@@ -109,10 +110,20 @@ public abstract class VoiceMessage extends DMRBurst
         return fragments;
     }
 
+    /**
+     * Indicates if the voice burst is valid, meaning that at least one of the three AMBE voice frames passes error
+     * detection (see AMBEFrameValidator).  Frames are checked in turn until a valid frame is found and the result is
+     * cached.
+     */
     @Override
     public boolean isValid()
     {
-        return true;
+        if(mValid == null)
+        {
+            mValid = AMBEFrameValidator.isValid(getMessage());
+        }
+
+        return mValid;
     }
 
     @Override

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/LRRPPacket.java

@@ -123,25 +123,23 @@ public class LRRPPacket extends Packet
             }
             else
             {
-                String message = getMessage().getSubMessage(getOffset(), getOffset() + ((characterCount + 2) * 8)).toHexString();
-                int x = 0;
-
                 RequestedTokens requestedTokens = new RequestedTokens();
 
                 while(characterCount > 0 && offset < getMessage().size())
                 {
                     String tokenId = getTokenIdentifier(offset);
-                    TokenType tokenType = TokenType.fromValue(tokenId);
+                    TokenType tokenType = TokenType.fromRequestValue(tokenId);
 
                     if(tokenType.isRequestParameterToken())
                     {
-                        Token token = TokenFactory.createToken(tokenId, getMessage(), offset, characterCount);
+                        Token token = TokenFactory.createToken(tokenType, getMessage(), offset, characterCount);
                         mTokens.add(token);
                         characterCount -= token.getByteLength();
                         offset += (8 * token.getByteLength());
                     }
                     else
                     {
+                        //Single-byte flag naming a field that the radio should include in its location report
                         if(tokenType != TokenType.UNKNOWN)
                         {
                             requestedTokens.add(tokenType);

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/Identity.java

@@ -26,7 +26,7 @@ import io.github.dsheirer.bits.CorrectedBinaryMessage;
  * LRRP Identity Token
  *
  * Start Token: 0x22
- * Total Length: 6 bytes
+ * Total Length: 2 bytes plus a 1-4 byte request identifier
  */
 public class Identity extends Token
 {
@@ -34,9 +34,9 @@ public class Identity extends Token
     private static final int[] BYTE_VALUE = new int[]{0, 1, 2, 3, 4, 5, 6, 7};
 
     /**
-     * Constructs an instance of a heading token.
+     * Constructs an instance of an identity token.
      *
-     * @param message containing the heading
+     * @param message containing the identity
      * @param offset to the start of the token
      */
     public Identity(CorrectedBinaryMessage message, int offset)
@@ -50,47 +50,47 @@ public class Identity extends Token
         return TokenType.IDENTITY;
     }
 
-    private BinaryMessage getTokenContents()
+    /**
+     * Request identifier bytes, as transmitted.  The read is clamped to the end of the message so that a corrupted
+     * length field cannot produce bytes that were never received.
+     */
+    private BinaryMessage getIdentifierBytes()
     {
-        return getMessage().getSubMessage(getOffset(), getOffset() + 48);
+        int start = getOffset() + IDENTIFIER_START;
+        int available = Math.max(0, getMessage().size() - start);
+        int length = Math.min(getVariableLengthPayloadSize() * 8, available);
+        return getMessage().getSubMessage(start, start + length);
     }
 
     /**
-     * Extracts the payload contents.
+     * Request identifier assembled big-endian from the 1-4 payload bytes.  Moto.Net (LRRPPacket.cs) and node-dmr-lib
+     * (LRRP.js) both read the identifier this way.
      *
-     * Note: assumes that the values are 1-4 bytes in big-endian format?  Not sure if this is correct because the
-     * values that I observed only had value in the LSB and the 3 MSBs were all zeros.
+     * @return identifier, or zero when the payload length is not 1-4 bytes.
      */
     public int getID()
     {
         int length = getVariableLengthPayloadSize();
-        int payloadOffset = 16;
+
+        if(length < 1 || length > 4)
+        {
+            return 0;
+        }
+
         int value = 0;
 
-        while(0 < length && length <= 4)
+        for(int x = 0; x < length; x++)
         {
-            int byteValue = getMessage().getInt(BYTE_VALUE, getOffset() + payloadOffset);
-
-            byteValue = Integer.rotateLeft(byteValue, payloadOffset - 16);
-            value += byteValue;
-            payloadOffset += 8;
-            length--;
+            value = (value << 8) | getMessage().getInt(BYTE_VALUE, getOffset() + IDENTIFIER_START + (x * 8));
         }
 
         return value;
     }
 
-
     @Override
     public String toString()
     {
-        int id = getID();
-
-        if(id != 0)
-        {
-            return "ID:" + id;
-        }
-
-        return "ID:" + getTokenContents().toHexString();
+        //Hexadecimal, as transmitted (e.g. ID:FFFFEE)
+        return "ID:" + getIdentifierBytes().toHexString();
     }
 }

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/RequestParameter.java

@@ -0,0 +1,67 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+
+/**
+ * LRRP request parameter of unknown meaning that carries a 7-bit variable length integer value.
+ *
+ * Start Tokens: 0x42 and 0x44
+ * Total Length: 1 byte identifier plus a variable length integer value (0-5 bytes)
+ *
+ * Observed in Motorola P25 triggered location start requests as 0x44 0x64 (100) and 0x42 0x9C 0x10 (3600), placed
+ * among the requested-field flags.  Moto.Net emits a bare 0x42 as a "trigger on GPIO" flag, so the value is treated
+ * as optional and the token is rendered without a value when none follows.
+ */
+public class RequestParameter extends VarIntToken
+{
+    private TokenType mTokenType;
+
+    /**
+     * Constructs an instance of a request parameter token.
+     *
+     * @param tokenType of the parameter (REQUEST_PARAMETER_42 or REQUEST_PARAMETER_44)
+     * @param message containing the token
+     * @param offset to the start of the token
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
+     */
+    public RequestParameter(TokenType tokenType, CorrectedBinaryMessage message, int offset, int remainingCharacterCount)
+    {
+        super(message, offset, remainingCharacterCount);
+        mTokenType = tokenType;
+    }
+
+    @Override
+    public TokenType getTokenType()
+    {
+        return mTokenType;
+    }
+
+    @Override
+    public String toString()
+    {
+        if(hasValue())
+        {
+            return getTokenType() + ":" + getValue();
+        }
+
+        return getTokenType().toString();
+    }
+}

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/RequestedTokens.java

@@ -63,12 +63,28 @@ public class RequestedTokens extends Token
         Collections.sort(mUnrecognizedRequestedTokens);
     }
 
+    /**
+     * Recognized requested token types, in the order that they appeared in the packet.
+     */
+    public List<TokenType> getRequestedTokens()
+    {
+        return mRequestedTokens;
+    }
+
+    /**
+     * Unrecognized requested token identifiers (hexadecimal), sorted.
+     */
+    public List<String> getUnrecognizedRequestedTokens()
+    {
+        return mUnrecognizedRequestedTokens;
+    }
+
     /**
      * Indicates if this object has requested tokens.
      */
     public boolean hasRequestedTokens()
     {
-        return !mRequestedTokens.isEmpty();
+        return !mRequestedTokens.isEmpty() || !mUnrecognizedRequestedTokens.isEmpty();
     }
 
     @Override

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/Timestamp.java

@@ -28,7 +28,7 @@ import java.util.TimeZone;
 /**
  * LRRP Timestamp Token
  *
- * Start Token: 0x34
+ * Start Token: 0x34 (response packets; in a request packet 0x34 is the Periodic Trigger token)
  * Total Length: 6 bytes
  */
 public class Timestamp extends Token

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/Token.java

@@ -88,6 +88,11 @@ public abstract class Token
         {
             return getVariableLengthPayloadSize() + 2; //Variable Length Payload + Id + Length Field
         }
+        else if(getTokenType().isVarInt())
+        {
+            //Id + 7-bit variable length integer.  VarIntToken overrides this to bound the read by the payload.
+            return VarInt.length(getMessage(), getOffset() + 8, VarInt.MAX_BYTES) + 1;
+        }
         else
         {
             return getTokenType().getLength() + 1; //Fixed Length Payload + Id

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TokenFactory.java

@@ -26,10 +26,32 @@ import io.github.dsheirer.bits.CorrectedBinaryMessage;
  */
 public class TokenFactory
 {
+    /**
+     * Creates a token using the response packet meaning of the token identifier.
+     *
+     * @param id hexadecimal token identifier
+     * @param message containing the token
+     * @param offset to the start of the token identifier
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
+     * @return token
+     */
     public static Token createToken(String id, CorrectedBinaryMessage message, int offset, int remainingCharacterCount)
     {
-        TokenType tokenType = TokenType.fromValue(id);
+        return createToken(TokenType.fromValue(id), message, offset, remainingCharacterCount);
+    }
 
+    /**
+     * Creates a token of the specified type.
+     *
+     * @param tokenType resolved by the caller, using TokenType.fromRequestValue() for request packets
+     * @param message containing the token
+     * @param offset to the start of the token identifier
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
+     * @return token
+     */
+    public static Token createToken(TokenType tokenType, CorrectedBinaryMessage message, int offset,
+                                    int remainingCharacterCount)
+    {
         switch(tokenType)
         {
             case HEADING:
@@ -52,14 +74,17 @@ public class TokenFactory
                 return new Success(message, offset);
             case TIMESTAMP:
                 return new Timestamp(message, offset);
+            case TRIGGER_CONDITION:
+                return new TriggerCondition(message, offset);
             case TRIGGER_DISTANCE:
-                return new TriggerDistance(message, offset);
-            case TRIGGER_GPIO:
-                return new TriggerGpio(message, offset);
-            case TRIGGER_ON_MOVE:
-                return new TriggerOnMove(message, offset);
+                return new TriggerDistance(message, offset, remainingCharacterCount);
+            case TRIGGER_INTERVAL:
+                return new TriggerInterval(message, offset, remainingCharacterCount);
             case TRIGGER_PERIODIC:
                 return new TriggerPeriodic(message, offset);
+            case REQUEST_PARAMETER_42:
+            case REQUEST_PARAMETER_44:
+                return new RequestParameter(tokenType, message, offset, remainingCharacterCount);
             case VERSION:
                 return new Version(message, offset);
             case UNKNOWN_23:

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TokenType.java

@@ -26,21 +26,37 @@ import java.util.Map;
 /**
  * LRRP Token Types
  *
- * Variable length tokens consist of an identifier, a length indicator, and then a sequence of bytes equal in length
- * to the length indicator.
+ * Fixed length tokens consist of an identifier followed by a fixed number of value bytes.  Variable length tokens
+ * consist of an identifier, a length indicator, and then a sequence of bytes equal in length to the length indicator.
+ * Varint tokens consist of an identifier followed by a 7-bit variable length integer (see VarInt).
+ *
+ * A few identifiers have a different meaning in a request than in a response (0x34 is the periodic trigger flag in a
+ * request and the timestamp in a response).  Use fromRequestValue() for request packets and fromValue() otherwise.
+ *
+ * Note: the declaration order (ordinal) controls the order that tokens are listed when a packet is rendered as text.
  */
 public enum TokenType
 {
+    //Tokens common to request and response packets
     IDENTITY("22", -1, "IDENTITY"),
     UNKNOWN_23("23", 1, "UNKNOWN 23"),
-    TRIGGER_PERIODIC("31", 1, "TRIGGER PERIODIC"),
+
+    //Request parameter tokens.  Integer values are 7-bit variable length integers (varints).
+    TRIGGER_PERIODIC("34", 0, "PERIODIC", true), //Request meaning of 0x34.  See TIMESTAMP for the response meaning.
+    TRIGGER_INTERVAL("31", -2, "TRIGGER INTERVAL"),
+    TRIGGER_CONDITION("4A", 1, "TRIGGER CONDITION"),
+    TRIGGER_DISTANCE("78", -2, "TRIGGER DISTANCE"),
+    REQUEST_PARAMETER_42("42", -2, "PARAM-42"), //Meaning unknown.  Observed value: 3600
+    REQUEST_PARAMETER_44("44", -2, "PARAM-44"), //Meaning unknown.  Observed value: 100
+    REQUEST_61("61", 1, "REQUEST-61"),
+    REQUEST_73("73", 1, "REQUEST-73"),
+
+    //Response tokens and single-byte requested field flags
     TIMESTAMP("34", 5, "TIMESTAMP"),
     VERSION("36", 1, "VERSION"),
     RESPONSE("37", -1, "RESPONSE"),
     SUCCESS( "38", 0, "SUCCESS"),
     REQUEST_3A("3A", 0,"REQUEST-3A"),
-    TRIGGER_GPIO("42", 0, "TRIGGER GPIO"),
-    TRIGGER_DISTANCE("4A", 1, "TRIGGER DISTANCE"), //Guess - not sure
     ALTITUDE_ACCURACY("50", 0,"ALTITUDE ACCURACY"),
     CIRCLE_2D("51", 10, "CIRCLE 2D"),
     TIME("52", 0,"TIME"),
@@ -48,37 +64,55 @@ public enum TokenType
     CIRCLE_3D("55", 15, "CIRCLE 3D"),
     HEADING("56", 1, "HEADING"),
     HORIZONTAL_DIRECTION("57", 0,"HORIZONTAL DIRECTION"),
-    REQUEST_61("61", 1, "REQUEST-61"),
-    REQUEST_62("62", 0,"REQUEST-62"),
+    HORIZONTAL_SPEED("62", 0,"HORIZONTAL SPEED"),
     REQUEST_64("64", 0,"REQUEST-64"),
     POINT_2D("66", 8, "POINT 2D"),
     POINT_3D("69", 11, "POINT 3D"),
     SPEED("6C", 2, "SPEED"),
-    REQUEST_73("73", 1, "REQUEST-73"),
-    TRIGGER_ON_MOVE("78", 1, "TRIGGER ON MOVE"),
     REQUESTED_TOKENS("000", 0, "REQUESTED TOKENS"),
     UNKNOWN("0",0, "UNKNOWN");
 
+    private static final int VARIABLE_LENGTH = -1;
+    private static final int VARINT_LENGTH = -2;
+
     private String mValue;
     private int mLength;
     private String mLabel;
+    private boolean mRequestOnly;
 
     /**
      * Tokens that have parameters in request packet messages
      */
-    private static EnumSet<TokenType> REQUEST_PARAMETER_TOKENS = EnumSet.of(IDENTITY, TRIGGER_DISTANCE, TRIGGER_GPIO,
-            TRIGGER_ON_MOVE, TRIGGER_PERIODIC, REQUEST_61, REQUEST_73);
+    private static EnumSet<TokenType> REQUEST_PARAMETER_TOKENS = EnumSet.of(IDENTITY, TRIGGER_PERIODIC,
+            TRIGGER_INTERVAL, TRIGGER_CONDITION, TRIGGER_DISTANCE, REQUEST_PARAMETER_42, REQUEST_PARAMETER_44,
+            REQUEST_61, REQUEST_73);
 
     /**
      * Constructs an instance
      * @param value of the token
-     * @param length of the token, exclusive of the identifier, where -1 indicates a variable length token.
+     * @param length of the token, exclusive of the identifier, where -1 indicates a variable length token and -2
+     * indicates a 7-bit variable length integer (varint) value.
+     * @param label for pretty printing
      */
     TokenType(String value, int length, String label)
+    {
+        this(value, length, label, false);
+    }
+
+    /**
+     * Constructs an instance
+     * @param value of the token
+     * @param length of the token, exclusive of the identifier, where -1 indicates a variable length token and -2
+     * indicates a 7-bit variable length integer (varint) value.
+     * @param label for pretty printing
+     * @param requestOnly true when this meaning of the value applies to request packets only
+     */
+    TokenType(String value, int length, String label, boolean requestOnly)
     {
         mValue = value;
         mLength = length;
         mLabel = label;
+        mRequestOnly = requestOnly;
     }
 
     /**
@@ -94,7 +128,23 @@ public enum TokenType
      */
     public boolean isVariableLength()
     {
-        return mLength == -1;
+        return mLength == VARIABLE_LENGTH;
+    }
+
+    /**
+     * Indicates if this token's value is a 7-bit variable length integer (varint).
+     */
+    public boolean isVarInt()
+    {
+        return mLength == VARINT_LENGTH;
+    }
+
+    /**
+     * Indicates if this meaning of the token value applies to request packets only.
+     */
+    public boolean isRequestOnly()
+    {
+        return mRequestOnly;
     }
 
     /**
@@ -116,17 +166,26 @@ public enum TokenType
 
 
     private static final Map<String,TokenType> LOOKUP_MAP = new HashMap<>();
+    private static final Map<String,TokenType> REQUEST_LOOKUP_MAP = new HashMap<>();
 
     static
     {
         for(TokenType tokenType: TokenType.values())
         {
-            LOOKUP_MAP.put(tokenType.getValue(), tokenType);
+            if(tokenType.isRequestOnly())
+            {
+                REQUEST_LOOKUP_MAP.put(tokenType.getValue(), tokenType);
+            }
+            else
+            {
+                LOOKUP_MAP.put(tokenType.getValue(), tokenType);
+                REQUEST_LOOKUP_MAP.putIfAbsent(tokenType.getValue(), tokenType);
+            }
         }
     }
 
     /**
-     * Lookup a token from a 2-character string value
+     * Lookup a token from a 2-character string value, using the response packet meaning of the value.
      * @param value that represents the token
      * @return matching token or UNKNOWN.
      */
@@ -140,6 +199,21 @@ public enum TokenType
         return UNKNOWN;
     }
 
+    /**
+     * Lookup a token from a 2-character string value, using the request packet meaning of the value.
+     * @param value that represents the token
+     * @return matching token or UNKNOWN.
+     */
+    public static TokenType fromRequestValue(String value)
+    {
+        if(value != null && REQUEST_LOOKUP_MAP.containsKey(value))
+        {
+            return REQUEST_LOOKUP_MAP.get(value);
+        }
+
+        return UNKNOWN;
+    }
+
     @Override
     public String toString()
     {

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TriggerCondition.java

@@ -0,0 +1,135 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+
+/**
+ * LRRP Trigger Condition Token
+ *
+ * Start Token: 0x4A
+ * Total Length: 2 bytes
+ *
+ * Event that causes the radio to send a triggered location report.  Condition values are from node-dmr-lib
+ * (src/DMRConst.js) and match captured requests: 0x4A 0x02 emergency, 0x4A 0x42 pin status change (telemetry),
+ * 0x4A 0x50 PTT and 0x4A 0x51 PTT emergency.
+ */
+public class TriggerCondition extends Token
+{
+    private static final int[] CONDITION = new int[]{8, 9, 10, 11, 12, 13, 14, 15};
+
+    /**
+     * Trigger condition values
+     */
+    public enum Condition
+    {
+        EMERGENCY(0x02, "EMERGENCY"),
+        PIN_STATUS_CHANGE(0x42, "PIN STATUS CHANGE"),
+        PTT(0x50, "PTT"),
+        PTT_EMERGENCY(0x51, "PTT EMERGENCY"),
+        UNKNOWN(-1, "UNKNOWN");
+
+        private int mValue;
+        private String mLabel;
+
+        Condition(int value, String label)
+        {
+            mValue = value;
+            mLabel = label;
+        }
+
+        /**
+         * Numeric value of the condition
+         */
+        public int getValue()
+        {
+            return mValue;
+        }
+
+        /**
+         * Lookup a condition from a value
+         * @param value to lookup
+         * @return matching condition or UNKNOWN
+         */
+        public static Condition fromValue(int value)
+        {
+            for(Condition condition: Condition.values())
+            {
+                if(condition.getValue() == value)
+                {
+                    return condition;
+                }
+            }
+
+            return UNKNOWN;
+        }
+
+        @Override
+        public String toString()
+        {
+            return mLabel;
+        }
+    }
+
+    /**
+     * Constructs an instance of a trigger condition token.
+     *
+     * @param message containing the token
+     * @param offset to the start of the token
+     */
+    public TriggerCondition(CorrectedBinaryMessage message, int offset)
+    {
+        super(message, offset);
+    }
+
+    @Override
+    public TokenType getTokenType()
+    {
+        return TokenType.TRIGGER_CONDITION;
+    }
+
+    /**
+     * Raw condition value
+     */
+    public int getConditionValue()
+    {
+        return getMessage().getInt(CONDITION, getOffset());
+    }
+
+    /**
+     * Trigger condition
+     */
+    public Condition getCondition()
+    {
+        return Condition.fromValue(getConditionValue());
+    }
+
+    @Override
+    public String toString()
+    {
+        Condition condition = getCondition();
+
+        if(condition == Condition.UNKNOWN)
+        {
+            return "TRIGGER CONDITION:UNKNOWN[0x" + String.format("%02X", getConditionValue()) + "]";
+        }
+
+        return "TRIGGER CONDITION:" + condition;
+    }
+}

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TriggerDistance.java

@@ -24,21 +24,23 @@ import io.github.dsheirer.bits.CorrectedBinaryMessage;
 /**
  * LRRP Trigger Distance Token
  *
- * Total Length: 2 bytes
+ * Start Token: 0x78
+ * Total Length: 1 byte identifier plus a 7-bit variable length integer value (1-5 bytes)
+ *
+ * Distance in meters that the radio must move before it sends a triggered location report, e.g. 0x78 0x83 0x74 = 500.
  */
-public class TriggerDistance extends Token
+public class TriggerDistance extends VarIntToken
 {
-    private static final int[] DISTANCE = new int[]{8, 9, 10, 11, 12, 13, 14, 15};
-
     /**
-     * Constructs an instance of a heading token.
+     * Constructs an instance of a trigger distance token.
      *
-     * @param message containing the heading
+     * @param message containing the token
      * @param offset to the start of the token
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
      */
-    public TriggerDistance(CorrectedBinaryMessage message, int offset)
+    public TriggerDistance(CorrectedBinaryMessage message, int offset, int remainingCharacterCount)
     {
-        super(message, offset);
+        super(message, offset, remainingCharacterCount);
     }
 
     @Override
@@ -52,12 +54,12 @@ public class TriggerDistance extends Token
      */
     public int getDistance()
     {
-        return getMessage().getInt(DISTANCE, getOffset());
+        return getValue();
     }
 
     @Override
     public String toString()
     {
-        return "TRIGGER DISTANCE:" + getDistance();
+        return "TRIGGER DISTANCE:" + getDistance() + " METERS";
     }
 }

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TriggerInterval.java

@@ -1,6 +1,6 @@
 /*
  * *****************************************************************************
- * Copyright (C) 2014-2023 Dennis Sheirer
+ * Copyright (C) 2014-2026 Dennis Sheirer
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -16,38 +16,49 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>
  * ****************************************************************************
  */
-
 package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
 
 import io.github.dsheirer.bits.CorrectedBinaryMessage;
 
 /**
- * LRRP Trigger on GPIO Token
+ * LRRP Trigger Interval Token
  *
- * Total Length: 1 byte
+ * Start Token: 0x31
+ * Total Length: 1 byte identifier plus a 7-bit variable length integer value (1-5 bytes)
+ *
+ * Reporting interval in seconds for a periodic triggered location request, e.g. 0x31 0x84 0x58 = 600 seconds.
  */
-public class TriggerGpio extends Token
+public class TriggerInterval extends VarIntToken
 {
     /**
-     * Constructs an instance of a heading token.
+     * Constructs an instance of a trigger interval token.
      *
-     * @param message containing the heading
+     * @param message containing the token
      * @param offset to the start of the token
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
      */
-    public TriggerGpio(CorrectedBinaryMessage message, int offset)
+    public TriggerInterval(CorrectedBinaryMessage message, int offset, int remainingCharacterCount)
     {
-        super(message, offset);
+        super(message, offset, remainingCharacterCount);
     }
 
     @Override
     public TokenType getTokenType()
     {
-        return TokenType.TRIGGER_GPIO;
+        return TokenType.TRIGGER_INTERVAL;
+    }
+
+    /**
+     * Interval in seconds
+     */
+    public int getSeconds()
+    {
+        return getValue();
     }
 
     @Override
     public String toString()
     {
-        return "TRIGGER ON GPIO";
+        return "INTERVAL:" + getSeconds() + " SECS";
     }
 }

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TriggerOnMove.java

@@ -1,53 +0,0 @@
-/*
- * *****************************************************************************
- * Copyright (C) 2014-2023 Dennis Sheirer
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation, either version 3 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program.  If not, see <http://www.gnu.org/licenses/>
- * ****************************************************************************
- */
-
-package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
-
-import io.github.dsheirer.bits.CorrectedBinaryMessage;
-
-/**
- * LRRP Trigger on Move Token
- *
- * Total Length: 1 byte
- */
-public class TriggerOnMove extends Token
-{
-    /**
-     * Constructs an instance of a heading token.
-     *
-     * @param message containing the heading
-     * @param offset to the start of the token
-     */
-    public TriggerOnMove(CorrectedBinaryMessage message, int offset)
-    {
-        super(message, offset);
-    }
-
-    @Override
-    public TokenType getTokenType()
-    {
-        return TokenType.TRIGGER_ON_MOVE;
-    }
-
-    @Override
-    public String toString()
-    {
-        return "TRIGGER ON MOVE";
-    }
-}

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/TriggerPeriodic.java

@@ -22,18 +22,20 @@ package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
 import io.github.dsheirer.bits.CorrectedBinaryMessage;
 
 /**
- * LRRP Trigger Periodic Token
+ * LRRP Periodic Trigger Token (request packets)
  *
- * Total Length: 2 bytes
+ * Start Token: 0x34 (in a response packet 0x34 is the Timestamp token)
+ * Total Length: 1 byte
+ *
+ * Flags a triggered location request as periodic.  The reporting interval, when present, follows in a separate
+ * Trigger Interval (0x31) token, and a Trigger Condition (0x4A) or Trigger Distance (0x78) token can follow instead.
  */
 public class TriggerPeriodic extends Token
 {
-    private static final int[] SECONDS = new int[]{8, 9, 10, 11, 12, 13, 14, 15};
-
     /**
-     * Constructs an instance of a heading token.
+     * Constructs an instance of a periodic trigger token.
      *
-     * @param message containing the heading
+     * @param message containing the token
      * @param offset to the start of the token
      */
     public TriggerPeriodic(CorrectedBinaryMessage message, int offset)
@@ -44,20 +46,12 @@ public class TriggerPeriodic extends Token
     @Override
     public TokenType getTokenType()
     {
-        return TokenType.TRIGGER_DISTANCE;
-    }
-
-    /**
-     * Seconds for trigger
-     */
-    public int getSeconds()
-    {
-        return getMessage().getInt(SECONDS, getOffset());
+        return TokenType.TRIGGER_PERIODIC;
     }
 
     @Override
     public String toString()
     {
-        return "TRIGGER EVERY:" + getSeconds() + " SECS";
+        return "PERIODIC";
     }
 }

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/VarInt.java

@@ -0,0 +1,105 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
+
+import io.github.dsheirer.bits.BinaryMessage;
+
+/**
+ * LRRP variable length integer (varint) reader.
+ *
+ * LRRP encodes integer token values as one or more bytes where each byte carries seven value bits, most significant
+ * group first, and the high bit of a byte indicates that another byte follows.  For example 0x84 0x58 decodes to
+ * (0x04 << 7) | 0x58 = 600, 0x9C 0x10 decodes to (0x1C << 7) | 0x10 = 3600 and a value smaller than 128 occupies a
+ * single byte (0x64 = 100).
+ *
+ * References:
+ *  - Moto.Net, LRRPPacket.cs: "looks like this stuff is using VLQ ... for most of the fields"
+ *  - node-dmr-lib, src/Protocols/LRRP.js: parseLRRPInt() and toLRRPInt()
+ */
+public final class VarInt
+{
+    /**
+     * Maximum number of bytes consumed for a single value.  Five 7-bit groups hold 35 bits, which covers any 32-bit
+     * value, and the cap keeps a corrupted run of continuation bits from consuming the rest of a packet.
+     */
+    public static final int MAX_BYTES = 5;
+
+    private static final int[] BYTE_VALUE = {0, 1, 2, 3, 4, 5, 6, 7};
+    private static final int CONTINUATION_MASK = 0x80;
+    private static final int VALUE_MASK = 0x7F;
+
+    private VarInt()
+    {
+        //Static utility class
+    }
+
+    /**
+     * Number of bytes occupied by the varint that starts at the bit offset.
+     *
+     * @param message containing the value
+     * @param offset bit offset to the first byte of the value
+     * @param limit maximum number of bytes available for the value (ie bytes remaining in the packet payload)
+     * @return byte count from 0 to the lesser of limit and MAX_BYTES.  Zero indicates that no value is present.
+     */
+    public static int length(BinaryMessage message, int offset, int limit)
+    {
+        int maximum = Math.min(limit, MAX_BYTES);
+        int count = 0;
+
+        while(count < maximum)
+        {
+            int b = message.getInt(BYTE_VALUE, offset + (count * 8));
+            count++;
+
+            if((b & CONTINUATION_MASK) == 0)
+            {
+                break;
+            }
+        }
+
+        return count;
+    }
+
+    /**
+     * Decodes the varint that starts at the bit offset.
+     *
+     * @param message containing the value
+     * @param offset bit offset to the first byte of the value
+     * @param limit maximum number of bytes available for the value (ie bytes remaining in the packet payload)
+     * @return decoded value, or zero when no bytes are available.
+     */
+    public static int value(BinaryMessage message, int offset, int limit)
+    {
+        int maximum = Math.min(limit, MAX_BYTES);
+        int value = 0;
+
+        for(int count = 0; count < maximum; count++)
+        {
+            int b = message.getInt(BYTE_VALUE, offset + (count * 8));
+            value = (value << 7) | (b & VALUE_MASK);
+
+            if((b & CONTINUATION_MASK) == 0)
+            {
+                break;
+            }
+        }
+
+        return value;
+    }
+}

src/main/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/VarIntToken.java

@@ -0,0 +1,88 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+
+/**
+ * Base class for LRRP tokens whose value is a 7-bit variable length integer (see VarInt).
+ *
+ * The value starts in the byte that follows the token identifier and occupies one or more bytes.  The read is
+ * bounded by the number of payload bytes that remain, so a token at the end of the payload cannot consume bytes
+ * that belong to the next packet.
+ */
+public abstract class VarIntToken extends Token
+{
+    private static final int VALUE_START = 8;
+    private int mRemainingCharacterCount;
+
+    /**
+     * Constructs an instance
+     *
+     * @param message containing the token and value
+     * @param offset to the start of the token identifier
+     * @param remainingCharacterCount number of payload bytes remaining, counting from the token identifier
+     */
+    public VarIntToken(CorrectedBinaryMessage message, int offset, int remainingCharacterCount)
+    {
+        super(message, offset);
+        mRemainingCharacterCount = remainingCharacterCount;
+    }
+
+    /**
+     * Maximum number of value bytes that can follow the token identifier.
+     */
+    private int getValueLimit()
+    {
+        return Math.max(0, mRemainingCharacterCount - 1);
+    }
+
+    /**
+     * Number of bytes occupied by the value, exclusive of the token identifier.
+     */
+    public int getValueLength()
+    {
+        return VarInt.length(getMessage(), getOffset() + VALUE_START, getValueLimit());
+    }
+
+    /**
+     * Indicates if a value follows the token identifier.
+     */
+    public boolean hasValue()
+    {
+        return getValueLength() > 0;
+    }
+
+    /**
+     * Decoded integer value, or zero when the token has no value.
+     */
+    public int getValue()
+    {
+        return VarInt.value(getMessage(), getOffset() + VALUE_START, getValueLimit());
+    }
+
+    /**
+     * Total token length: identifier plus the variable length value.
+     */
+    @Override
+    public int getByteLength()
+    {
+        return 1 + getValueLength();
+    }
+}

src/main/java/io/github/dsheirer/module/decode/p25/phase1/P25P1DecoderState.java

@@ -192,6 +192,14 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
     private final P25TrafficChannelManager mTrafficChannelManager;
     private ServiceOptions mCurrentServiceOptions;
 
+    /**
+     * Encryption state of the current call as signalled by the algorithm ID in the HDU header or LDU2 encryption sync
+     * parameters (null when not yet known for this call).  Some radios set the encryption flag in the service options of
+     * the LDU1 voice channel user link control while transmitting clear voice (HDU and LDU2 report ALGID 0x80), so the
+     * algorithm ID takes precedence over the link control service options when it is known.
+     */
+    private Boolean mCallEncryptedByAlgorithm = null;
+
     /**
      * Constructs an APCO-25 decoder state with an optional traffic channel manager.
      * @param channel with configuration details
@@ -419,6 +427,12 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
         if(lcw instanceof IServiceOptionsProvider sop)
         {
             serviceOptions = sop.getServiceOptions();
+
+            //Trust the HDU/LDU2 algorithm ID over the link control service options encryption flag when known.
+            if(serviceOptions != null && serviceOptions.isEncrypted() && Boolean.FALSE.equals(mCallEncryptedByAlgorithm))
+            {
+                serviceOptions = VoiceServiceOptions.createUnencrypted(serviceOptions);
+            }
         }
         else if(lcw.isEncrypted())
         {
@@ -838,6 +852,7 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
 
                 Identifier<?> radio = getIdentifierCollection().getFromIdentifier();
 
+                mCallEncryptedByAlgorithm = headerData.isEncryptedAudio();
                 mTrafficChannelManager.processP1TrafficCallStart(getCurrentFrequency(), talkgroup, radio,
                         headerData.getEncryptionKey(), mCurrentServiceOptions, getCurrentChannel(), message.getTimestamp());
 
@@ -880,6 +895,7 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
             if(esp != null && esp.isValid())
             {
                 getIdentifierCollection().update(esp.getIdentifiers());
+                mCallEncryptedByAlgorithm = esp.isEncryptedAudio();
 
                 if(esp.isEncryptedAudio())
                 {
@@ -903,6 +919,7 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
      */
     private void processTDU(P25P1Message message)
     {
+        mCallEncryptedByAlgorithm = null;
         mTrafficChannelManager.processP1TrafficCallEnd(getCurrentFrequency(), message.getTimestamp(), "TDU:" + message);
         broadcast(new DecoderStateEvent(this, Event.DECODE, State.ACTIVE));
     }
@@ -921,6 +938,7 @@ public class P25P1DecoderState extends DecoderState implements IChannelEventList
 
             if(lcw != null && lcw.isValid())
             {
+                mCallEncryptedByAlgorithm = null;
                 mTrafficChannelManager.processP1TrafficCallEnd(getCurrentFrequency(), message.getTimestamp(), "TDULC:" + message);
                 broadcast(new DecoderStateEvent(this, Event.DECODE, State.ACTIVE));
                 processLC(lcw, message.getTimestamp(), true);

src/main/java/io/github/dsheirer/module/decode/p25/phase1/message/hdu/HDUMessage.java

@@ -34,7 +34,7 @@ public class HDUMessage extends P25P1Message
     private final static Logger mLog = LoggerFactory.getLogger(HDUMessage.class);
 
     private static final int[] GOLAY_WORD_STARTS = {0, 18, 36, 54, 72, 90, 108, 126, 144, 162, 180, 198, 216, 234, 252,
-        270, 288, 306, 324, 342, 360, 278, 396, 414, 432, 450, 468, 486, 504, 522, 540, 558, 576, 594, 612, 630};
+        270, 288, 306, 324, 342, 360, 378, 396, 414, 432, 450, 468, 486, 504, 522, 540, 558, 576, 594, 612, 630};
 
     private static final int[] CW_HEX_0 = {0, 1, 2, 3, 4, 5};
     private static final int[] CW_HEX_1 = {18, 19, 20, 21, 22, 23};

src/main/java/io/github/dsheirer/module/decode/p25/phase1/message/pdu/PDUHeaderFactory.java

@@ -24,6 +24,7 @@ import io.github.dsheirer.module.decode.p25.phase1.message.pdu.ambtc.AMBTCHeader
 import io.github.dsheirer.module.decode.p25.phase1.message.pdu.packet.PacketHeader;
 import io.github.dsheirer.module.decode.p25.phase1.message.pdu.response.ResponseHeader;
 import io.github.dsheirer.module.decode.p25.reference.PDUFormat;
+import io.github.dsheirer.module.decode.p25.reference.ServiceAccessPoint;
 
 public class PDUHeaderFactory
 {
@@ -41,8 +42,41 @@ public class PDUHeaderFactory
             case RESPONSE_PACKET_HEADER_FORMAT:
                 return new ResponseHeader(correctedBinaryMessage, passesCRC);
             case UNCONFIRMED_MULTI_BLOCK_TRUNKING_CONTROL:
+                //Format 0x15 is the generic unconfirmed data header.  Unconfirmed multi-block trunking control is
+                //only the trunking control SAP (61/63) use of it.  With a packet data SAP the header has the same
+                //field layout as the confirmed packet data header and the data blocks carry an (IP) packet.
+                if(isPacketData(getServiceAccessPoint(correctedBinaryMessage)))
+                {
+                    return new PacketHeader(correctedBinaryMessage, passesCRC);
+                }
+
+                return new PDUHeader(correctedBinaryMessage, passesCRC);
             default:
                 return new PDUHeader(correctedBinaryMessage, passesCRC);
         }
     }
+
+    /**
+     * Service Access Point (SAP) from a packet data or unconfirmed data header message.
+     */
+    public static ServiceAccessPoint getServiceAccessPoint(CorrectedBinaryMessage correctedBinaryMessage)
+    {
+        return ServiceAccessPoint.fromValue(correctedBinaryMessage.getInt(PacketHeader.SAP_ID));
+    }
+
+    /**
+     * Indicates if the SAP identifies packet data that is processed by the PDUMessageFactory as a packet message.
+     */
+    public static boolean isPacketData(ServiceAccessPoint sap)
+    {
+        switch(sap)
+        {
+            case UNENCRYPTED_USER_DATA:
+            case PACKET_DATA:
+            case SNDCP_PACKET_DATA_CONTROL:
+                return true;
+            default:
+                return false;
+        }
+    }
 }

src/main/java/io/github/dsheirer/module/decode/p25/phase1/message/pdu/PDUMessageFactory.java

@@ -173,6 +173,13 @@ public class PDUMessageFactory
             case RESPONSE_PACKET_HEADER_FORMAT:
                 return new ResponseMessage(pduSequence, nac, timestamp);
             case UNCONFIRMED_MULTI_BLOCK_TRUNKING_CONTROL:
+                //The header factory creates a packet header when the unconfirmed data header carries a packet data
+                //SAP, so that unconfirmed IP packets are processed the same as confirmed (PACKET_DATA) packets.
+                if(pduSequence.getHeader() instanceof PacketHeader)
+                {
+                    return createPacketData(pduSequence, nac, timestamp);
+                }
+
                 return createUMBTC(pduSequence, nac, timestamp);
             default:
                 return new PDUSequenceMessage(pduSequence, nac, timestamp);
@@ -229,7 +236,7 @@ public class PDUMessageFactory
     }
 
     /**
-     * Creates a packet data message
+     * Creates a packet data message from a confirmed or unconfirmed packet data sequence.
      *
      * @param pduSequence containing a packet data header and zero or more data blocks
      * @param nac network access code

src/main/java/io/github/dsheirer/module/decode/p25/reference/VoiceServiceOptions.java

@@ -80,4 +80,13 @@ public class VoiceServiceOptions extends ServiceOptions
     {
         return new VoiceServiceOptions(4);
     }
+
+    /**
+     * Creates a copy of the supplied service options with the encryption flag cleared and all other options unchanged.
+     * @param serviceOptions to copy
+     */
+    public static VoiceServiceOptions createUnencrypted(ServiceOptions serviceOptions)
+    {
+        return new VoiceServiceOptions(serviceOptions.mServiceOptions & ~ENCRYPTION_FLAG);
+    }
 }

src/main/java/io/github/dsheirer/monitor/DiagnosticMonitor.java

@@ -1,6 +1,6 @@
 /*
  * *****************************************************************************
- * Copyright (C) 2014-2024 Dennis Sheirer
+ * Copyright (C) 2014-2026 Dennis Sheirer
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -247,6 +247,7 @@ public class DiagnosticMonitor
         Attributes atts = findManifestAttributes();
         if (atts != null) {
             sb.append("\nVersion  : " + atts.getValue("Implementation-Version"));
+            sb.append("\nGit Describe      : " + atts.getValue("Git-Describe"));
             sb.append("\nGradle Version    : " + atts.getValue("Created-By"));
             sb.append("\nBuild Timestamp   : " + atts.getValue("Build-Timestamp"));
             sb.append("\nBuild-JDK         : " + atts.getValue("Build-JDK"));

src/main/java/io/github/dsheirer/properties/SystemProperties.java

@@ -1,6 +1,6 @@
 /*
  * *****************************************************************************
- * Copyright (C) 2014-2024 Dennis Sheirer
+ * Copyright (C) 2014-2026 Dennis Sheirer
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -48,6 +48,7 @@ public class SystemProperties
     private static String PROPERTIES_FILENAME = "SDRTrunk.properties";
     private static String MANIFEST_VERSION = "Implementation-Version";
     private static String BUILD_TIMESTAMP = "Build-Timestamp";
+    private static String GIT_DESCRIBE = "Git-Describe";
 
     private static SystemProperties INSTANCE;
     private static Properties mProperties;
@@ -217,12 +218,18 @@ public class SystemProperties
             {
                 String version = manifest.getMainAttributes().getValue(MANIFEST_VERSION);
                 String timestamp = manifest.getMainAttributes().getValue(BUILD_TIMESTAMP);
+                String gitDescribe = manifest.getMainAttributes().getValue(GIT_DESCRIBE);
 
                 if(version != null)
                 {
                     if(version.contains("nightly") && timestamp != null)
                     {
                         sb.append( " nightly - ").append(timestamp);
+
+                        if(gitDescribe != null && !gitDescribe.equals("unknown"))
+                        {
+                            sb.append(" (").append(gitDescribe).append(")");
+                        }
                     }
                     else
                     {

src/main/java/io/github/dsheirer/util/DuplicateLibraryDetector.java

@@ -0,0 +1,140 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.util;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.TreeMap;
+import java.util.TreeSet;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+/**
+ * Detects more than one version of the same library jar on the class path.
+ *
+ * The release launch scripts use a 'lib/*' wildcard class path, so when a user unzips a new release over an older one,
+ * the stale jars from the older release stay on the class path next to the new ones.  The JVM loads classes (and the
+ * tuner libraries extract their native libraries) from whichever jar sorts first, which can silently run an older
+ * library version, including native code with bugs that the newer version fixed.
+ */
+public class DuplicateLibraryDetector
+{
+    /**
+     * Splits a jar file name into the library name and version.  The version starts at the first dash that is
+     * followed by a digit, a 'v' and a digit, or 'nightly' (e.g. guava-33.8.0-jre, api-v2.1.1, sdr-trunk-nightly).
+     */
+    private static final Pattern JAR_NAME = Pattern.compile("^(.+?)-(v?\\d.*|nightly)\\.jar$");
+
+    private DuplicateLibraryDetector()
+    {
+    }
+
+    /**
+     * Finds the libraries that have more than one version on this JVM's class path.
+     * @return map of library name to the sorted jar paths for that library, empty when there are no duplicates.
+     */
+    public static Map<String,List<String>> findDuplicates()
+    {
+        String classPath = System.getProperty("java.class.path", "");
+        return findDuplicates(List.of(classPath.split(Pattern.quote(File.pathSeparator))));
+    }
+
+    /**
+     * Finds the libraries that have more than one version in the class path entries.  Entries that are not jar files
+     * or that don't have a version in the file name are ignored.
+     * @param classPathEntries to check
+     * @return map of library name to the sorted jar paths for that library, empty when there are no duplicates.
+     */
+    public static Map<String,List<String>> findDuplicates(List<String> classPathEntries)
+    {
+        Map<String,TreeSet<String>> versions = new TreeMap<>();
+        Map<String,TreeSet<String>> paths = new TreeMap<>();
+
+        for(String entry: classPathEntries)
+        {
+            if(entry == null || entry.isBlank())
+            {
+                continue;
+            }
+
+            Path fileName = Path.of(entry).getFileName();
+
+            if(fileName == null)
+            {
+                continue;
+            }
+
+            Matcher matcher = JAR_NAME.matcher(fileName.toString());
+
+            if(matcher.matches())
+            {
+                versions.computeIfAbsent(matcher.group(1), k -> new TreeSet<>()).add(matcher.group(2));
+                paths.computeIfAbsent(matcher.group(1), k -> new TreeSet<>()).add(entry);
+            }
+        }
+
+        Map<String,List<String>> duplicates = new TreeMap<>();
+
+        for(Map.Entry<String,TreeSet<String>> entry: versions.entrySet())
+        {
+            if(entry.getValue().size() > 1)
+            {
+                duplicates.put(entry.getKey(), new ArrayList<>(paths.get(entry.getKey())));
+            }
+        }
+
+        return duplicates;
+    }
+
+    /**
+     * Creates a description of the duplicate libraries for a log entry or a dialog.
+     * @param duplicates from findDuplicates()
+     * @return description, one line per library, listing the jar file names for each library.
+     */
+    public static String describe(Map<String,List<String>> duplicates)
+    {
+        StringBuilder sb = new StringBuilder();
+
+        for(Map.Entry<String,List<String>> entry: duplicates.entrySet())
+        {
+            List<String> names = entry.getValue().stream().map(p -> Path.of(p).getFileName().toString()).toList();
+            sb.append("  ").append(entry.getKey()).append(": ").append(String.join(", ", names)).append("\n");
+        }
+
+        return sb.toString();
+    }
+
+    /**
+     * Folder that holds the duplicate jars, for telling the user which folder to replace.
+     * @param duplicates from findDuplicates()
+     * @return folder of the first duplicate jar, or null if there are no duplicates or the path has no parent.
+     */
+    public static Path getFolder(Map<String,List<String>> duplicates)
+    {
+        if(duplicates.isEmpty())
+        {
+            return null;
+        }
+
+        return Path.of(duplicates.values().iterator().next().getFirst()).toAbsolutePath().normalize().getParent();
+    }
+}

src/test/java/io/github/dsheirer/dsp/c4fm/C4FMSymbolProcessorScoreTest.java

@@ -0,0 +1,50 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+
+package io.github.dsheirer.dsp.c4fm;
+
+import io.github.dsheirer.module.decode.p25.phase1.P25P1SymbolProcessorC4FM;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+
+/**
+ * JUnit tests for the sync correlation score in the C4FM symbol processor.
+ */
+public class C4FMSymbolProcessorScoreTest
+{
+    /**
+     * A lagging sync detect on the first symbol after a buffer reload, followed by a coarse timing search that steps
+     * all the way left, scores a candidate whose first sync symbol starts just before the start of the buffer.
+     */
+    @Test
+    public void scoreBeforeBufferStart()
+    {
+        float samplesPerSymbol = 25000f / 4800f;
+        P25P1SymbolProcessorC4FM processor = new P25P1SymbolProcessorC4FM(null, null);
+        processor.setSamplesPerSymbol(samplesPerSymbol);
+        //Sync workspace, sized as in setSamplesPerSymbol(), plus a 1024 sample buffer
+        int syncWorkspaceLength = (int)Math.ceil((processor.mSyncDetector.getDibitLength() + 1) * samplesPerSymbol);
+        processor.mBuffer = new float[syncWorkspaceLength + 1024];
+
+        //Offset to the final sync symbol that puts the first sync symbol at buffer index -0.3
+        double offset = (processor.mSyncDetector.getDibitLength() - 1) * samplesPerSymbol - 0.3;
+        assertDoesNotThrow(() -> processor.score(offset, samplesPerSymbol));
+    }
+}

src/test/java/io/github/dsheirer/edac/Golay24OffsetTest.java

@@ -0,0 +1,85 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+
+package io.github.dsheirer.edac;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+import java.util.Random;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * Tests Golay(24,12) correction of the data bits of words that are not at the start of a 24-bit message.
+ */
+public class Golay24OffsetTest
+{
+    private static int encode(int data)
+    {
+        int checksum = 0;
+
+        for(int bit = 0; bit < 12; bit++)
+        {
+            if((data & (1 << (11 - bit))) != 0)
+            {
+                checksum ^= Golay24.CHECKSUMS[bit];
+            }
+        }
+
+        int word23 = (data << 11) | checksum;
+        return (word23 << 1) | (Integer.bitCount(word23) & 1);
+    }
+
+    @Test
+    public void correctsUpToThreeErrorsInEveryWordOfALongerMessage()
+    {
+        Random random = new Random(1);
+
+        for(int trial = 0; trial < 2000; trial++)
+        {
+            int[] words = new int[3];
+            CorrectedBinaryMessage message = new CorrectedBinaryMessage(72);
+
+            for(int w = 0; w < 3; w++)
+            {
+                words[w] = encode(random.nextInt(4096));
+                int received = words[w];
+
+                for(int e = random.nextInt(4); e > 0; e--)
+                {
+                    received ^= 1 << random.nextInt(24);
+                }
+
+                message.load(w * 24, 24, received);
+            }
+
+            for(int w = 0; w < 3; w++)
+            {
+                Golay24.checkAndCorrect(message, w * 24);
+            }
+
+            for(int w = 0; w < 3; w++)
+            {
+                //The 12 data bits.  (The core correction can leave the overall parity bit wrong when it corrects other
+                //bits, which no caller reads.)
+                assertEquals(words[w] >> 12, message.getInt(w * 24, w * 24 + 11), "trial " + trial + " word " + w);
+            }
+        }
+    }
+}

src/test/java/io/github/dsheirer/module/decode/dmr/message/voice/AMBEFrameValidatorTest.java

@@ -0,0 +1,178 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+
+package io.github.dsheirer.module.decode.dmr.message.voice;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+import io.github.dsheirer.module.decode.dmr.sync.DMRSyncPattern;
+import java.util.List;
+import java.util.Random;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Tests for AMBE voice frame error detection.
+ */
+public class AMBEFrameValidatorTest
+{
+    //Base station voice frame A burst from a recording where JMBE decodes all three voice frames with zero errors.
+    private static final String VOICE_BURST = "5A3AC4B9E881526173002A6BB9E881526755FD7DF75F7173002A6BB9E881526173002A6B";
+    //Burst bit indices of the first C0 bits (voice frame bits 0, 4, 8) and first C1 bit (voice frame bit 25) of
+    //frame 1, which starts at burst bit 24.
+    private static final int FRAME_1_C0_BIT_0 = 24;
+    private static final int FRAME_1_C0_BIT_1 = 28;
+    private static final int FRAME_1_C0_BIT_2 = 32;
+    private static final int FRAME_1_C1_BIT_0 = 49;
+
+    private static CorrectedBinaryMessage getBurst()
+    {
+        return CorrectedBinaryMessage.loadHex(VOICE_BURST);
+    }
+
+    @Test
+    void errorFreeBurst()
+    {
+        CorrectedBinaryMessage burst = getBurst();
+
+        for(int frame = 0; frame < 3; frame++)
+        {
+            assertEquals(0, AMBEFrameValidator.getErrorCount(burst, frame), "Frame " + frame);
+        }
+
+        assertTrue(AMBEFrameValidator.isValid(burst));
+    }
+
+    @Test
+    void errorsAreCounted()
+    {
+        CorrectedBinaryMessage burst = getBurst();
+        burst.flip(FRAME_1_C0_BIT_0);
+        assertEquals(1, AMBEFrameValidator.getErrorCount(burst, 0));
+        burst.flip(FRAME_1_C1_BIT_0);
+        assertEquals(2, AMBEFrameValidator.getErrorCount(burst, 0));
+        burst.flip(FRAME_1_C0_BIT_1);
+        assertEquals(3, AMBEFrameValidator.getErrorCount(burst, 0));
+    }
+
+    @Test
+    void fourC0ErrorsAreDetected()
+    {
+        CorrectedBinaryMessage burst = getBurst();
+        burst.flip(FRAME_1_C0_BIT_0);
+        burst.flip(FRAME_1_C0_BIT_1);
+        burst.flip(FRAME_1_C0_BIT_2);
+        burst.flip(FRAME_1_C0_BIT_2 + 4);
+        assertTrue(AMBEFrameValidator.getErrorCount(burst, 0) > AMBEFrameValidator.MAX_ERRORS);
+    }
+
+    @Test
+    void validWhenAnyFrameIsValid()
+    {
+        CorrectedBinaryMessage burst = getBurst();
+
+        //Corrupt the C0 vector of each frame in turn (4 bit errors), verifying a single valid frame is sufficient.
+        int[] frameOffsets = {24, 96, 216};
+
+        for(int frame = 0; frame < 3; frame++)
+        {
+            for(int bit = 0; bit < 16; bit += 4)
+            {
+                burst.flip(frameOffsets[frame] + bit);
+            }
+
+            assertTrue(AMBEFrameValidator.getErrorCount(burst, frame) > AMBEFrameValidator.MAX_ERRORS);
+            assertEquals(frame < 2, AMBEFrameValidator.isValid(burst), "Corrupted frames: " + (frame + 1));
+        }
+    }
+
+    @Test
+    void randomBurstsAreRarelyValid()
+    {
+        Random random = new Random(1234);
+        int valid = 0;
+        int trials = 20000;
+
+        for(int trial = 0; trial < trials; trial++)
+        {
+            CorrectedBinaryMessage burst = new CorrectedBinaryMessage(288);
+
+            for(int bit = 0; bit < 288; bit++)
+            {
+                if(random.nextBoolean())
+                {
+                    burst.set(bit);
+                }
+            }
+
+            if(AMBEFrameValidator.isValid(burst))
+            {
+                valid++;
+            }
+        }
+
+        //Expected false valid rate is ~3 x 1.3e-4 (ie ~8 of 20,000)
+        assertTrue(valid < 30, "Random bursts detected as valid: " + valid);
+    }
+
+    @Test
+    void voiceMessageValidity()
+    {
+        assertTrue(new VoiceAMessage(DMRSyncPattern.BASE_STATION_VOICE, getBurst(), null, 0, 1).isValid());
+
+        CorrectedBinaryMessage corrupted = getBurst();
+        int[] frameOffsets = {24, 96, 216};
+
+        for(int offset : frameOffsets)
+        {
+            for(int bit = 0; bit < 16; bit += 4)
+            {
+                corrupted.flip(offset + bit);
+            }
+        }
+
+        assertFalse(new VoiceAMessage(DMRSyncPattern.BASE_STATION_VOICE, corrupted, null, 0, 1).isValid());
+    }
+
+    /**
+     * Verifies the AMBE frames match the burst bits, specifically for frame 2 where bits 32-35 are sourced from burst
+     * bits 128-131 and bits 36-39 from burst bits 180-183, with burst bit 180 set (ie a negative signed byte).
+     */
+    @Test
+    void ambeFramesMatchBurstBits()
+    {
+        CorrectedBinaryMessage burst = getBurst();
+        burst.set(180);
+        burst.clear(128, 132);
+        List<byte[]> frames = new VoiceAMessage(DMRSyncPattern.BASE_STATION_VOICE, burst, null, 0, 1).getAMBEFrames();
+        int[] frameOffsets = {24, 96, 216};
+
+        for(int frame = 0; frame < 3; frame++)
+        {
+            for(int bit = 0; bit < 72; bit++)
+            {
+                int burstIndex = frameOffsets[frame] + bit + ((frame == 1 && bit >= 36) ? 48 : 0);
+                boolean frameBit = (frames.get(frame)[bit / 8] & (0x80 >> (bit % 8))) != 0;
+                assertEquals(burst.get(burstIndex), frameBit, "Frame " + frame + " bit " + bit);
+            }
+        }
+    }
+}

src/test/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/LRRPPacketTest.java

@@ -0,0 +1,216 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.Identity;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.RequestParameter;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.RequestedTokens;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.Token;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.TokenType;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.TriggerCondition;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.TriggerInterval;
+import io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token.TriggerPeriodic;
+import java.util.List;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+import static org.junit.jupiter.api.Assertions.fail;
+
+/**
+ * JUnit tests for LRRP request packet token parsing.
+ *
+ * The sample packets are Motorola triggered location start requests captured from a P25 system (UDP port 4001).
+ * Both carry the same requested fields (time, horizontal speed, horizontal direction) and the same two parameters of
+ * unknown meaning (0x44 = 100, 0x42 = 3600); one is a periodic trigger every 600 seconds and the other is an
+ * emergency trigger.
+ */
+public class LRRPPacketTest
+{
+    //Periodic profile: ID FFFFEE, periodic trigger with a 600 second interval (0x31 0x84 0x58)
+    private static final String PERIODIC_REQUEST = "09112203FFFFEE524464429C10625734318458";
+    //Condition profile: ID FFFF02, trigger condition emergency (0x4A 0x02)
+    private static final String EMERGENCY_REQUEST = "09102203FFFF02524464429C106257344A02";
+    //PERIODIC_REQUEST as received with the packet type byte corrupted to 0xA3 (unknown type)
+    private static final String UNKNOWN_TYPE_REQUEST = "A3112203FFFFEE524464429C10625734318458";
+    //EMERGENCY_REQUEST with the packet type byte corrupted to 0x07 (immediate location response)
+    private static final String DAMAGED_TYPE_REQUEST = "07102203FFFF02524464429C106257344A02";
+
+    private static final List<TokenType> REQUESTED_FIELDS = List.of(TokenType.TIME, TokenType.HORIZONTAL_SPEED,
+            TokenType.HORIZONTAL_DIRECTION);
+
+    private static LRRPPacket parse(String hex)
+    {
+        return new LRRPPacket(CorrectedBinaryMessage.loadHex(hex), 0);
+    }
+
+    private static <T extends Token> T getToken(LRRPPacket packet, Class<T> clazz, TokenType tokenType)
+    {
+        for(Token token: packet.getTokens())
+        {
+            if(token.getTokenType() == tokenType && clazz.isInstance(token))
+            {
+                return clazz.cast(token);
+            }
+        }
+
+        fail("Packet does not contain token " + tokenType + ": " + packet);
+        return null;
+    }
+
+    private static boolean hasToken(LRRPPacket packet, TokenType tokenType)
+    {
+        for(Token token: packet.getTokens())
+        {
+            if(token.getTokenType() == tokenType)
+            {
+                return true;
+            }
+        }
+
+        return false;
+    }
+
+    /**
+     * Number of payload bytes accounted for by the parsed tokens: parameter tokens contribute their byte length and
+     * each requested field flag contributes one byte.
+     */
+    private static int getConsumedBytes(LRRPPacket packet)
+    {
+        int consumed = 0;
+
+        for(Token token: packet.getTokens())
+        {
+            if(token instanceof RequestedTokens requested)
+            {
+                consumed += requested.getRequestedTokens().size() + requested.getUnrecognizedRequestedTokens().size();
+            }
+            else
+            {
+                consumed += token.getByteLength();
+            }
+        }
+
+        return consumed;
+    }
+
+    /**
+     * Asserts the fields that both sample requests share.
+     */
+    private static void assertCommonRequestTokens(LRRPPacket packet, int expectedId)
+    {
+        Identity identity = getToken(packet, Identity.class, TokenType.IDENTITY);
+        assertEquals(expectedId, identity.getID());
+        assertEquals(5, identity.getByteLength());
+
+        assertNotNull(getToken(packet, TriggerPeriodic.class, TokenType.TRIGGER_PERIODIC));
+
+        RequestParameter parameter42 = getToken(packet, RequestParameter.class, TokenType.REQUEST_PARAMETER_42);
+        assertEquals(3600, parameter42.getValue()); //0x42 0x9C 0x10
+        assertEquals(3, parameter42.getByteLength());
+
+        RequestParameter parameter44 = getToken(packet, RequestParameter.class, TokenType.REQUEST_PARAMETER_44);
+        assertEquals(100, parameter44.getValue()); //0x44 0x64
+        assertEquals(2, parameter44.getByteLength());
+
+        RequestedTokens requested = getToken(packet, RequestedTokens.class, TokenType.REQUESTED_TOKENS);
+        assertEquals(REQUESTED_FIELDS, requested.getRequestedTokens());
+        assertTrue(requested.getUnrecognizedRequestedTokens().isEmpty(), "No stray tokens: " + packet);
+
+        //Every payload byte is accounted for exactly once
+        assertEquals(packet.getHeader().getPayloadLength(), getConsumedBytes(packet));
+    }
+
+    @Test
+    public void periodicTriggeredLocationStartRequest()
+    {
+        LRRPPacket packet = parse(PERIODIC_REQUEST);
+
+        assertEquals(LRRPPacketType.TRIGGERED_LOCATION_START_REQUEST, packet.getHeader().getLRRPPacketType());
+        assertEquals(17, packet.getHeader().getPayloadLength());
+        assertCommonRequestTokens(packet, 0xFFFFEE);
+
+        TriggerInterval interval = getToken(packet, TriggerInterval.class, TokenType.TRIGGER_INTERVAL);
+        assertEquals(600, interval.getSeconds()); //0x31 0x84 0x58
+        assertEquals(3, interval.getByteLength());
+        assertFalse(hasToken(packet, TokenType.TRIGGER_CONDITION));
+
+        assertEquals("LRRP TRIGGERED LOCATION START REQUEST ID:FFFFEE PERIODIC INTERVAL:600 SECS PARAM-42:3600 " +
+                "PARAM-44:100 REQUESTED TOKENS [TIME,HORIZONTAL SPEED,HORIZONTAL DIRECTION]", packet.toString());
+    }
+
+    @Test
+    public void emergencyTriggeredLocationStartRequest()
+    {
+        LRRPPacket packet = parse(EMERGENCY_REQUEST);
+
+        assertEquals(LRRPPacketType.TRIGGERED_LOCATION_START_REQUEST, packet.getHeader().getLRRPPacketType());
+        assertEquals(16, packet.getHeader().getPayloadLength());
+        assertCommonRequestTokens(packet, 0xFFFF02);
+
+        TriggerCondition condition = getToken(packet, TriggerCondition.class, TokenType.TRIGGER_CONDITION);
+        assertEquals(TriggerCondition.Condition.EMERGENCY, condition.getCondition()); //0x4A 0x02
+        assertEquals(2, condition.getByteLength());
+        assertFalse(hasToken(packet, TokenType.TRIGGER_INTERVAL));
+
+        assertEquals("LRRP TRIGGERED LOCATION START REQUEST ID:FFFF02 PERIODIC TRIGGER CONDITION:EMERGENCY " +
+                "PARAM-42:3600 PARAM-44:100 REQUESTED TOKENS [TIME,HORIZONTAL SPEED,HORIZONTAL DIRECTION]",
+                packet.toString());
+    }
+
+    /**
+     * A corrupted type byte that is not a known packet type takes the request parsing path, so the intact body still
+     * decodes completely.
+     */
+    @Test
+    public void unknownTypeRequestBodyStillDecodes()
+    {
+        LRRPPacket packet = parse(UNKNOWN_TYPE_REQUEST);
+
+        assertEquals(LRRPPacketType.UNKNOWN, packet.getHeader().getLRRPPacketType());
+        assertEquals(0xA3, packet.getHeader().getLrrpPacketTypeValue());
+        assertCommonRequestTokens(packet, 0xFFFFEE);
+        assertEquals(600, getToken(packet, TriggerInterval.class, TokenType.TRIGGER_INTERVAL).getSeconds());
+
+        assertEquals("LRRP TYPE:UNKNOWN [163] ID:FFFFEE PERIODIC INTERVAL:600 SECS PARAM-42:3600 PARAM-44:100 " +
+                "REQUESTED TOKENS [TIME,HORIZONTAL SPEED,HORIZONTAL DIRECTION]", packet.toString());
+    }
+
+    /**
+     * A type byte corrupted to a valid response type (0x07) sends the body down the response parsing path, where
+     * 0x34 is a timestamp rather than the periodic trigger flag.  The parse must still terminate within the payload
+     * and the identity and variable length integer parameters must still decode.
+     */
+    @Test
+    public void damagedTypeRequestParsesAsResponseWithoutError()
+    {
+        LRRPPacket packet = parse(DAMAGED_TYPE_REQUEST);
+
+        assertEquals(LRRPPacketType.IMMEDIATE_LOCATION_RESPONSE, packet.getHeader().getLRRPPacketType());
+        assertDoesNotThrow(packet::toString);
+
+        assertEquals(0xFFFF02, getToken(packet, Identity.class, TokenType.IDENTITY).getID());
+        assertEquals(3600, getToken(packet, RequestParameter.class, TokenType.REQUEST_PARAMETER_42).getValue());
+        assertEquals(100, getToken(packet, RequestParameter.class, TokenType.REQUEST_PARAMETER_44).getValue());
+    }
+}

src/test/java/io/github/dsheirer/module/decode/ip/mototrbo/lrrp/token/VarIntTest.java

@@ -0,0 +1,88 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.module.decode.ip.mototrbo.lrrp.token;
+
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+
+/**
+ * JUnit tests for the LRRP 7-bit variable length integer reader.
+ */
+public class VarIntTest
+{
+    private static CorrectedBinaryMessage hex(String hex)
+    {
+        return CorrectedBinaryMessage.loadHex(hex);
+    }
+
+    @Test
+    public void singleByteValue()
+    {
+        CorrectedBinaryMessage message = hex("64");
+        assertEquals(1, VarInt.length(message, 0, 10));
+        assertEquals(100, VarInt.value(message, 0, 10));
+    }
+
+    @Test
+    public void twoByteValues()
+    {
+        //Values captured from Motorola triggered location start requests (interval 600 s, unknown parameter 3600)
+        assertEquals(2, VarInt.length(hex("8458"), 0, 10));
+        assertEquals(600, VarInt.value(hex("8458"), 0, 10));
+        assertEquals(2, VarInt.length(hex("9C10"), 0, 10));
+        assertEquals(3600, VarInt.value(hex("9C10"), 0, 10));
+
+        //Values from the TRBONet captures quoted in node-dmr-lib LRRP.js: interval 250 s and distance 500 m
+        assertEquals(250, VarInt.value(hex("817A"), 0, 10));
+        assertEquals(500, VarInt.value(hex("8374"), 0, 10));
+    }
+
+    @Test
+    public void valueAtOffset()
+    {
+        //Token identifier 0x31 followed by the value - read starting at bit 8
+        CorrectedBinaryMessage message = hex("318458");
+        assertEquals(2, VarInt.length(message, 8, 2));
+        assertEquals(600, VarInt.value(message, 8, 2));
+    }
+
+    @Test
+    public void limitBoundsTheRead()
+    {
+        CorrectedBinaryMessage message = hex("8458");
+
+        //Only one byte available: the continuation bit is set but the read stops at the limit
+        assertEquals(1, VarInt.length(message, 0, 1));
+        assertEquals(4, VarInt.value(message, 0, 1));
+
+        //No bytes available
+        assertEquals(0, VarInt.length(message, 0, 0));
+        assertEquals(0, VarInt.value(message, 0, 0));
+    }
+
+    @Test
+    public void maximumLength()
+    {
+        //A run of continuation bits longer than MAX_BYTES stops at MAX_BYTES
+        CorrectedBinaryMessage message = hex("FFFFFFFFFFFFFF");
+        assertEquals(VarInt.MAX_BYTES, VarInt.length(message, 0, 10));
+    }
+}

src/test/java/io/github/dsheirer/module/decode/p25/phase1/message/pdu/PDUMessageFactoryTest.java

@@ -0,0 +1,229 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2025 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+
+package io.github.dsheirer.module.decode.p25.phase1.message.pdu;
+
+import io.github.dsheirer.bits.BinaryMessage;
+import io.github.dsheirer.bits.CorrectedBinaryMessage;
+import io.github.dsheirer.module.decode.ip.IPacket;
+import io.github.dsheirer.module.decode.ip.ipv4.IPV4Packet;
+import io.github.dsheirer.module.decode.ip.mototrbo.ars.ARSPacket;
+import io.github.dsheirer.module.decode.ip.mototrbo.ars.RegistrationAcknowledgement;
+import io.github.dsheirer.module.decode.ip.udp.UDPPacket;
+import io.github.dsheirer.module.decode.p25.phase1.message.P25P1Message;
+import io.github.dsheirer.module.decode.p25.phase1.message.pdu.block.DataBlock;
+import io.github.dsheirer.module.decode.p25.phase1.message.pdu.packet.PacketHeader;
+import io.github.dsheirer.module.decode.p25.phase1.message.pdu.packet.PacketMessage;
+import io.github.dsheirer.module.decode.p25.reference.PDUFormat;
+import io.github.dsheirer.module.decode.p25.reference.PDUType;
+import io.github.dsheirer.module.decode.p25.reference.ServiceAccessPoint;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertInstanceOf;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+/**
+ * Tests for PDU header and message creation, in particular that an unconfirmed data header (format 0x15) that
+ * carries a packet data SAP is processed as an IP packet and not as unconfirmed multi-block trunking control.
+ */
+public class PDUMessageFactoryTest
+{
+    private static final int NAC = 0x460;
+
+    /**
+     * Outbound unconfirmed data header: format 0x15, SAP 4 (PACKET DATA), MFID 0, LLID 4006527, 4 blocks to
+     * follow, 10 pad octets, data header offset 2.  The header CRC octets are zero; the header factory derives
+     * the CRC result from the corrected bit count and does not evaluate them.
+     */
+    private static final String UNCONFIRMED_SAP_4_HEADER = "3504003D227F840A00020000";
+    private static final String UNCONFIRMED_SAP_0_HEADER = "3500003D227F840A00020000";
+    private static final String UNCONFIRMED_SAP_6_HEADER = "3506003D227F840A00020000";
+    private static final String UNCONFIRMED_SAP_61_HEADER = "353D003D227F840A00020000";
+    private static final String UNCONFIRMED_SAP_63_HEADER = "353F003D227F840A00020000";
+    /** Same as UNCONFIRMED_SAP_4_HEADER with LLID 4001080 and 5 pad octets */
+    private static final String UNCONFIRMED_SAP_4_HEADER_PAD_5 = "3504003D0D38840500020000";
+    /** Outbound confirmed data header: format 0x16, SAP 0, LLID 4006527, 4 blocks, 10 pad octets, offset 2 */
+    private static final String CONFIRMED_SAP_0_HEADER = "7600003D227F840A00020000";
+
+    /**
+     * Unconfirmed (1/2 rate, 12 octet) data blocks captured from a Motorola P25 Phase 1 control channel, as logged
+     * by the PDUSequence MSG: field.  SNDCP header 0x4100 (RF UNCONFIRMED DATA, NSAPI 1), IPv4/UDP from
+     * 10.51.4.116:49516 to 10.71.213.29:4005, ARS registration acknowledgement (refresh 8 x 30 minutes),
+     * 10 pad octets (0xAA) and the 32-bit packet CRC.
+     */
+    private static final String[] ARS_ACK_BLOCKS = {"410045000020280200008011", "24C00A3304740A47D51DC16C",
+        "0FA5000C81AE0002BF08AAAA", "AAAAAAAAAAAAAAAAC0F19102"};
+
+    /**
+     * As above, to 10.71.212.139 with a 5 octet trailer (0x04 + 32-bit time) after the ARS extension octet and
+     * 5 pad octets.
+     */
+    private static final String[] ARS_ACK_WITH_TRAILER_BLOCKS = {"4100450000255F7E00008011", "EDD00A3304740A47D48BC16C",
+        "0FA5001113E60007BF08046A", "D3E096AAAAAAAAAA8675BA00"};
+
+    @Test
+    public void unconfirmedDataHeaderWithPacketDataSapIsPacketHeader()
+    {
+        for(String hex : new String[]{UNCONFIRMED_SAP_0_HEADER, UNCONFIRMED_SAP_4_HEADER, UNCONFIRMED_SAP_6_HEADER})
+        {
+            PDUHeader header = PDUHeaderFactory.getPDUHeader(CorrectedBinaryMessage.loadHex(hex));
+            assertEquals(PDUFormat.UNCONFIRMED_MULTI_BLOCK_TRUNKING_CONTROL, header.getFormat(), hex);
+            assertInstanceOf(PacketHeader.class, header, hex);
+            assertFalse(header.isConfirmationRequired(), hex);
+            assertTrue(header.isOutbound(), hex);
+        }
+
+        PacketHeader header = (PacketHeader)PDUHeaderFactory.getPDUHeader(CorrectedBinaryMessage.loadHex(UNCONFIRMED_SAP_4_HEADER));
+        assertEquals(ServiceAccessPoint.PACKET_DATA, header.getServiceAccessPoint());
+        assertEquals(4, header.getBlocksToFollowCount());
+        assertEquals(10, header.getPadOctetCount());
+        assertEquals(2, header.getDataHeaderOffset());
+    }
+
+    @Test
+    public void unconfirmedDataHeaderWithTrunkingControlSapIsNotPacketHeader()
+    {
+        for(String hex : new String[]{UNCONFIRMED_SAP_61_HEADER, UNCONFIRMED_SAP_63_HEADER})
+        {
+            PDUHeader header = PDUHeaderFactory.getPDUHeader(CorrectedBinaryMessage.loadHex(hex));
+            assertEquals(PDUFormat.UNCONFIRMED_MULTI_BLOCK_TRUNKING_CONTROL, header.getFormat(), hex);
+            assertFalse(header instanceof PacketHeader, hex);
+
+            P25P1Message message = PDUMessageFactory.create(new PDUSequence(header, 0, NAC), NAC, 0);
+            assertInstanceOf(PDUSequenceMessage.class, message, hex);
+        }
+    }
+
+    @Test
+    public void confirmedPacketDataHeaderIsPacketHeader()
+    {
+        PDUHeader header = PDUHeaderFactory.getPDUHeader(CorrectedBinaryMessage.loadHex(CONFIRMED_SAP_0_HEADER));
+        assertEquals(PDUFormat.PACKET_DATA, header.getFormat());
+        assertInstanceOf(PacketHeader.class, header);
+        assertTrue(header.isConfirmationRequired());
+    }
+
+    @Test
+    public void unconfirmedPacketDataDecodesAsIpPacket()
+    {
+        PacketMessage packetMessage = createPacketMessage(UNCONFIRMED_SAP_4_HEADER, ARS_ACK_BLOCKS);
+
+        assertEquals(PDUType.OUTBOUND_SNDCP_RF_UNCONFIRMED_DATA, packetMessage.getSNDCPPacketHeader().getPDUType());
+        assertEquals(1, packetMessage.getSNDCPPacketHeader().getNSAPI());
+        //2 octets SNDCP header + 32 octet IP packet + 10 pad octets + 4 CRC octets = 48 octets = 4 x 12 octet blocks
+        assertEquals(32 * 8, packetMessage.getPacketMessage().size());
+
+        RegistrationAcknowledgement acknowledgement = getRegistrationAcknowledgement(packetMessage);
+        assertTrue(acknowledgement.isValid());
+        assertTrue(acknowledgement.isSuccessful());
+        assertEquals(8, acknowledgement.getPayloadValue());
+
+        String text = packetMessage.toString();
+        assertTrue(text.contains(" IPPKT "), text);
+        assertTrue(text.contains("LLID:4006527"), text);
+        assertTrue(text.contains("NSAPI:1"), text);
+        assertTrue(text.contains("IP FROM:10.51.4.116 TO:10.71.213.29"), text);
+        assertTrue(text.contains("UDP PORT FROM:49516 TO:4005"), text);
+        assertTrue(text.contains("ARS REGISTRATION SUCCESS REFRESH IN:240mins"), text);
+    }
+
+    @Test
+    public void unconfirmedPacketDataWithArsTrailerDecodesAsIpPacket()
+    {
+        PacketMessage packetMessage = createPacketMessage(UNCONFIRMED_SAP_4_HEADER_PAD_5, ARS_ACK_WITH_TRAILER_BLOCKS);
+
+        //2 octets SNDCP header + 37 octet IP packet + 5 pad octets + 4 CRC octets = 48 octets
+        assertEquals(37 * 8, packetMessage.getPacketMessage().size());
+
+        RegistrationAcknowledgement acknowledgement = getRegistrationAcknowledgement(packetMessage);
+        assertTrue(acknowledgement.isValid());
+        assertTrue(acknowledgement.isSuccessful());
+        assertEquals(8, acknowledgement.getPayloadValue());
+
+        String text = packetMessage.toString();
+        assertTrue(text.contains("LLID:4001080"), text);
+        assertTrue(text.contains("IP FROM:10.51.4.116 TO:10.71.212.139"), text);
+        assertTrue(text.contains("UDP PORT FROM:49516 TO:4005"), text);
+        assertTrue(text.contains("ARS REGISTRATION SUCCESS REFRESH IN:240mins"), text);
+    }
+
+    /**
+     * Creates a PDU sequence from the header and data blocks and processes it with the PDU message factory.
+     */
+    private static PacketMessage createPacketMessage(String headerHex, String[] blocksHex)
+    {
+        PDUHeader header = PDUHeaderFactory.getPDUHeader(CorrectedBinaryMessage.loadHex(headerHex));
+        PDUSequence sequence = new PDUSequence(header, 0, NAC);
+
+        for(String blockHex : blocksHex)
+        {
+            sequence.addDataBlock(dataBlock(blockHex));
+        }
+
+        assertTrue(sequence.isComplete());
+
+        P25P1Message message = PDUMessageFactory.create(sequence, NAC, 0);
+        assertInstanceOf(PacketMessage.class, message);
+        return (PacketMessage)message;
+    }
+
+    private static RegistrationAcknowledgement getRegistrationAcknowledgement(PacketMessage packetMessage)
+    {
+        IPacket packet = packetMessage.getPacket();
+        assertInstanceOf(IPV4Packet.class, packet);
+        IPacket udp = ((IPV4Packet)packet).getPayload();
+        assertInstanceOf(UDPPacket.class, udp);
+        assertEquals(4005, ((UDPPacket)udp).getHeader().getDestinationPort().getValue());
+        IPacket ars = ((UDPPacket)udp).getPayload();
+        assertInstanceOf(ARSPacket.class, ars);
+        assertInstanceOf(RegistrationAcknowledgement.class, ((ARSPacket)ars).getHeader());
+        return (RegistrationAcknowledgement)((ARSPacket)ars).getHeader();
+    }
+
+    /**
+     * Data block that returns an already decoded (1/2 rate, 96-bit) payload.
+     */
+    private static DataBlock dataBlock(String hex)
+    {
+        BinaryMessage message = BinaryMessage.loadHex(hex);
+
+        return new DataBlock()
+        {
+            @Override
+            public BinaryMessage getMessage()
+            {
+                return message;
+            }
+
+            @Override
+            public int getBitErrorsCount()
+            {
+                return 0;
+            }
+
+            @Override
+            public boolean isValid()
+            {
+                return true;
+            }
+        };
+    }
+}

src/test/java/io/github/dsheirer/util/DuplicateLibraryDetectorTest.java

@@ -0,0 +1,78 @@
+/*
+ * *****************************************************************************
+ * Copyright (C) 2014-2026 Dennis Sheirer
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ * ****************************************************************************
+ */
+package io.github.dsheirer.util;
+
+import java.nio.file.Path;
+import java.util.List;
+import java.util.Map;
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+public class DuplicateLibraryDetectorTest
+{
+    private static final String LIB = "/opt/sdr-trunk/bin/../lib/";
+
+    /**
+     * Jar names from a clean release image.
+     */
+    private static final List<String> CLEAN = List.of("JLargeArrays-1.7.jar", "JTransforms-3.2.jar", "api-v2.1.1.jar",
+            "commons-lang3-3.21.0.jar", "guava-33.8.0-jre.jar", "jackson-annotations-2.23.jar",
+            "jackson-core-2.23.0.jar", "java-lame-v3.98.4.jar", "javafx-swt.jar", "jhackrf-2026.01.3.1.jar",
+            "jiconfont-1.0.0.jar", "jiconfont-font_awesome-4.7.0.1.jar", "jiconfont-javafx-1.0.0.jar",
+            "jiconfont-swing-1.0.1.jar", "jrt-fs.jar", "jrtl-1.4.0.3.jar", "libresample4j-master.jar",
+            "listenablefuture-9999.0-empty-to-avoid-conflict-with-guava.jar", "logback-classic-1.6.6.jar",
+            "logback-core-1.6.6.jar", "sdr-trunk-nightly.jar");
+
+    private static List<String> paths(List<String> names)
+    {
+        return names.stream().map(n -> LIB + n).toList();
+    }
+
+    @Test
+    void cleanReleaseHasNoDuplicates()
+    {
+        assertTrue(DuplicateLibraryDetector.findDuplicates(paths(CLEAN)).isEmpty());
+        assertNull(DuplicateLibraryDetector.getFolder(Map.of()));
+    }
+
+    @Test
+    void newReleaseUnzippedOverOldReleaseIsDetected()
+    {
+        List<String> names = new java.util.ArrayList<>(CLEAN);
+        names.addAll(List.of("api-v2.1.0.jar", "guava-33.6.0-jre.jar", "jrtl-1.4.0.2.jar", "sdr-trunk-0.6.1.jar"));
+
+        Map<String,List<String>> duplicates = DuplicateLibraryDetector.findDuplicates(paths(names));
+
+        assertEquals(List.of("api", "guava", "jrtl", "sdr-trunk"), List.copyOf(duplicates.keySet()));
+        assertEquals(List.of(LIB + "jrtl-1.4.0.2.jar", LIB + "jrtl-1.4.0.3.jar"), duplicates.get("jrtl"));
+        assertTrue(DuplicateLibraryDetector.describe(duplicates).contains("jrtl: jrtl-1.4.0.2.jar, jrtl-1.4.0.3.jar"));
+        //Windows resolves a rooted path without a drive letter against the current drive, e.g. C:\opt\sdr-trunk\lib
+        assertEquals(Path.of("/opt/sdr-trunk/lib").toAbsolutePath(), DuplicateLibraryDetector.getFolder(duplicates));
+    }
+
+    @Test
+    void sameJarListedTwiceIsNotADuplicate()
+    {
+        assertTrue(DuplicateLibraryDetector.findDuplicates(List.of(LIB + "jrtl-1.4.0.3.jar", LIB + "jrtl-1.4.0.3.jar",
+                "", "/some/classes/dir")).isEmpty());
+    }
+}